cert-manager-operator icon indicating copy to clipboard operation
cert-manager-operator copied to clipboard

CM-340,CM-285: Bump deps, use upstream cert-manager v1.14.5

Open swghosh opened this issue 1 year ago • 5 comments

[v1.14.5] Rebase Checklist:

  • [x] go dependencies
* openshift/library-go @ release-4.16
* k8s.io/* @ v0.29.4
* sig.k8s.io/controller-runtime @ v0.17.5
* sig.k8s.io/controller-tools @ v0.14.0
  • [ ] downstream fork: https://github.com/openshift/jetstack-cert-manager
    • [ ] v1.14.5 tag
    • [x] commits
  • [x] update bundle description to include upstream version of cert-manager
  • [ ] depends on CI changes
    • [ ] https://github.com/openshift/release/pull/52416
    • [x] https://github.com/openshift/release/pull/52096
  • [x] skipRange: ">=1.13.1 <1.14.0", replaces: "1.13.1"
  • [ ] check if kube-rbac-proxy latest image have http2 CVE-2023-45288 remediated, else disable http2 for kube-rbac-proxy

swghosh avatar May 15 '24 10:05 swghosh

@swghosh: This pull request references CM-285 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

[v1.14.5] Rebase Checklist:

  • [x] go dependencies
* openshift/library-go @ release-4.16
* k8s.io/* @ v0.29.4
* sig.k8s.io/controller-runtime @ v0.17.5
* sig.k8s.io/controller-tools @ v0.14.0
  • [ ] downstream fork: https://github.com/openshift/jetstack-cert-manager
    • [ ] v1.14.5 tag
    • [x] commits
  • [x] update bundle description to include upstream version of cert-manager
  • [ ] depends on CI PRs
    • [ ] WIP
  • [x] skipRange: ">=1.13.1 <1.14.0", replaces: "1.13.1"
  • [ ] check if kube-rbac-proxy latest image have http2 CVE-2023-45288 remediated, else disable http2 for kube-rbac-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 15 '24 10:05 openshift-ci-robot

@swghosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 15 '24 12:05 openshift-ci[bot]

@swghosh: This pull request references CM-340 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

This pull request references CM-285 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

[v1.14.5] Rebase Checklist:

  • [x] go dependencies
* openshift/library-go @ release-4.16
* k8s.io/* @ v0.29.4
* sig.k8s.io/controller-runtime @ v0.17.5
* sig.k8s.io/controller-tools @ v0.14.0
  • [ ] downstream fork: https://github.com/openshift/jetstack-cert-manager
    • [ ] v1.14.5 tag
    • [x] commits
  • [x] update bundle description to include upstream version of cert-manager
  • [ ] depends on CI PRs
    • [ ] WIP
  • [x] skipRange: ">=1.13.1 <1.14.0", replaces: "1.13.1"
  • [ ] check if kube-rbac-proxy latest image have http2 CVE-2023-45288 remediated, else disable http2 for kube-rbac-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 21 '24 11:05 openshift-ci-robot

@swghosh: This pull request references CM-340 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

This pull request references CM-285 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

[v1.14.5] Rebase Checklist:

  • [x] go dependencies
* openshift/library-go @ release-4.16
* k8s.io/* @ v0.29.4
* sig.k8s.io/controller-runtime @ v0.17.5
* sig.k8s.io/controller-tools @ v0.14.0
  • [ ] downstream fork: https://github.com/openshift/jetstack-cert-manager
    • [ ] v1.14.5 tag
    • [x] commits
  • [x] update bundle description to include upstream version of cert-manager
  • [ ] depends on CI changes
    • [ ] https://github.com/openshift/release/pull/52416
    • [x] https://github.com/openshift/release/pull/52096
  • [x] skipRange: ">=1.13.1 <1.14.0", replaces: "1.13.1"
  • [ ] check if kube-rbac-proxy latest image have http2 CVE-2023-45288 remediated, else disable http2 for kube-rbac-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 23 '24 11:05 openshift-ci-robot

@swghosh: This pull request references CM-340 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

This pull request references CM-285 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

[v1.14.5] Rebase Checklist:

  • [x] go dependencies
* openshift/library-go @ release-4.16
* k8s.io/* @ v0.29.4
* sig.k8s.io/controller-runtime @ v0.17.5
* sig.k8s.io/controller-tools @ v0.14.0
  • [ ] downstream fork: https://github.com/openshift/jetstack-cert-manager
    • [ ] v1.14.5 tag
    • [x] commits
  • [x] update bundle description to include upstream version of cert-manager
  • [x] depends on CI changes
    • [x] https://github.com/openshift/release/pull/52416
    • [x] https://github.com/openshift/release/pull/52096
  • [x] skipRange: ">=1.13.1 <1.14.0", replaces: "1.13.1"
  • [ ] check if kube-rbac-proxy latest image have http2 CVE-2023-45288 remediated, else disable http2 for kube-rbac-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 27 '24 07:05 openshift-ci-robot

@swghosh: This pull request references CM-340 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

This pull request references CM-285 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

[v1.14.5] Rebase Checklist:

  • [x] go dependencies
* openshift/library-go @ release-4.16
* k8s.io/* @ v0.29.4
* sig.k8s.io/controller-runtime @ v0.17.5
* sig.k8s.io/controller-tools @ v0.14.0
  • [ ] downstream fork: https://github.com/openshift/jetstack-cert-manager
    • [ ] v1.14.5 tag
    • [x] commits
  • [x] update bundle description to include upstream version of cert-manager
  • [x] depends on CI changes
    • [x] https://github.com/openshift/release/pull/52416
    • [x] https://github.com/openshift/release/pull/52096
  • [x] skipRange: ">=1.13.1 <1.14.0", replaces: "1.13.1"
  • [x] check if kube-rbac-proxy latest image have http2 CVE-2023-45288 remediated, else disable http2 for kube-rbac-proxy
    • [ ] https://github.com/openshift/kube-rbac-proxy/pull/100

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 28 '24 20:05 openshift-ci-robot

/lgtm /approve

TrilokGeer avatar May 29 '24 10:05 TrilokGeer

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh, TrilokGeer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 29 '24 10:05 openshift-ci[bot]

/label docs-approved docs-approved already received in CM-242

swghosh avatar May 29 '24 10:05 swghosh

/cc @davemulford for px-approved label /cc @lunarwhite @xingxingxia for qe-approved label

Thanks!

swghosh avatar May 29 '24 11:05 swghosh

@swghosh: This pull request references CM-340 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

This pull request references CM-285 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

[v1.14.5] Rebase Checklist:

  • [x] go dependencies
* openshift/library-go @ release-4.16
* k8s.io/* @ v0.29.4
* sig.k8s.io/controller-runtime @ v0.17.5
* sig.k8s.io/controller-tools @ v0.14.0
  • [ ] downstream fork: https://github.com/openshift/jetstack-cert-manager
    • [ ] v1.14.5 tag
    • [x] commits
  • [x] update bundle description to include upstream version of cert-manager
  • [x] depends on CI changes
    • [x] https://github.com/openshift/release/pull/52416
    • [x] https://github.com/openshift/release/pull/52096
  • [x] skipRange: ">=1.13.1 <1.14.0", replaces: "1.13.1"
  • [x] check if kube-rbac-proxy latest image have http2 CVE-2023-45288 remediated, else disable http2 for kube-rbac-proxy
    • [ ] https://github.com/openshift/kube-rbac-proxy/pull/100

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 29 '24 12:05 openshift-ci-robot

/label px-approved 1.14 was previously approved in https://github.com/openshift/cert-manager-operator/pull/174#issuecomment-1956817128.

swghosh avatar May 29 '24 12:05 swghosh