cert-manager-operator
cert-manager-operator copied to clipboard
CM-318,CM-261: Add case to use explicit credentials in ACME DNS-01 on GCP
Configuring an ACME issuer by using explicit credentials for GCP CloudDNS
Similair to "should obtain a valid LetsEncrypt certificate", but change to use CloudDNS DNS-01 solver
Also change the origin case title.
Pass log
Running Suite: Cert Manager Suite - /Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e
============================================================================================================
Random Seed: 1712666438
Will run 2 of 21 specs
------------------------------
[BeforeSuite]
/Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e/suite_test.go:85
STEP: creating Kubernetes client set @ 04/09/24 20:40:38.393
STEP: creating cert-manager operator client @ 04/09/24 20:40:38.394
STEP: verifying operator and cert-manager deployments status is available @ 04/09/24 20:40:38.394
STEP: creating dynamic resources client @ 04/09/24 20:40:39.215
STEP: creating openshift config client @ 04/09/24 20:40:39.219
STEP: creating cert-manager client @ 04/09/24 20:40:39.219
[BeforeSuite] PASSED [0.828 seconds]
------------------------------
SSSSSSSSSSSSSSSS
------------------------------
ACME Certificate dns-01 challenge using explicit credentials should obtain a valid LetsEncrypt certificate on GCP cluster
/Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e/certificates_test.go:178
STEP: creating Kube clients @ 04/09/24 20:40:39.22
STEP: adding override args to cert-manager controller @ 04/09/24 20:40:39.453
STEP: waiting for operator status to become available @ 04/09/24 20:40:39.887
STEP: creating a test namespace @ 04/09/24 20:40:42.296
STEP: obtaining GCP credentials from kube-system namespace @ 04/09/24 20:40:43.003
STEP: copying GCP secret service account to test namespace @ 04/09/24 20:40:43.225
STEP: getting GCP project id from Infrastructure object @ 04/09/24 20:40:43.489
STEP: creating new certificate Issuer @ 04/09/24 20:40:43.701
STEP: creating new certificate @ 04/09/24 20:40:43.956
STEP: waiting for certificate to get ready @ 04/09/24 20:40:44.166
STEP: checking for certificate validity from secret contents @ 04/09/24 20:42:27.585
• [117.380 seconds]
------------------------------
SS
------------------------------
ACME Certificate dns-01 challenge using ambient credentials should obtain a valid LetsEncrypt certificate using ClusterIssuer on GCP mint/passthrough cluster
/Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e/certificates_test.go:483
STEP: waiting for operator status to become available @ 04/09/24 20:42:36.601
STEP: Getting Infrastructure object @ 04/09/24 20:42:37.003
STEP: Check cloud credential in cluster @ 04/09/24 20:42:37.215
STEP: Creating CredentialsRequest object @ 04/09/24 20:42:37.442
STEP: Waiting for cloud secret to be available @ 04/09/24 20:42:40.528
STEP: Configure cert-manager to use credential, setting this credential secret name in subscription object @ 04/09/24 20:42:56.978
STEP: Creating new certificate ClusterIssuer @ 04/09/24 20:42:57.428
STEP: Creating a test namespace @ 04/09/24 20:42:59.92
STEP: Creating new certificate @ 04/09/24 20:43:00.151
STEP: Waiting for certificate to get ready @ 04/09/24 20:43:02.381
STEP: checking for certificate validity from secret contents @ 04/09/24 20:45:50.794
STEP: resetting cert-manager state @ 04/09/24 20:45:59.698
• [204.037 seconds]
------------------------------
S
------------------------------
[ReportAfterSuite] Autogenerated ReportAfterSuite for --json-report --junit-report
autogenerated by Ginkgo
[ReportAfterSuite] PASSED [0.011 seconds]
------------------------------
Ran 2 of 21 Specs in 322.247 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 19 Skipped
@lunarwhite: This pull request references CM-318 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.
In response to this:
Configuring an ACME issuer by using explicit credentials for GCP CloudDNS
Similair to "should obtain a valid LetsEncrypt certificate", but change to use CloudDNS DNS-01 solver
Also change the origin case title.
Pass log
Running Suite: Cert Manager Suite - /Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e ============================================================================================================ Random Seed: 1712666438 Will run 2 of 21 specs ------------------------------ [BeforeSuite] /Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e/suite_test.go:85 STEP: creating Kubernetes client set @ 04/09/24 20:40:38.393 STEP: creating cert-manager operator client @ 04/09/24 20:40:38.394 STEP: verifying operator and cert-manager deployments status is available @ 04/09/24 20:40:38.394 STEP: creating dynamic resources client @ 04/09/24 20:40:39.215 STEP: creating openshift config client @ 04/09/24 20:40:39.219 STEP: creating cert-manager client @ 04/09/24 20:40:39.219 [BeforeSuite] PASSED [0.828 seconds] ------------------------------ SSSSSSSSSSSSSSSS ------------------------------ ACME Certificate dns-01 challenge using explicit credentials should obtain a valid LetsEncrypt certificate on GCP cluster /Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e/certificates_test.go:178 STEP: creating Kube clients @ 04/09/24 20:40:39.22 STEP: adding override args to cert-manager controller @ 04/09/24 20:40:39.453 STEP: waiting for operator status to become available @ 04/09/24 20:40:39.887 STEP: creating a test namespace @ 04/09/24 20:40:42.296 STEP: obtaining GCP credentials from kube-system namespace @ 04/09/24 20:40:43.003 STEP: copying GCP secret service account to test namespace @ 04/09/24 20:40:43.225 STEP: getting GCP project id from Infrastructure object @ 04/09/24 20:40:43.489 STEP: creating new certificate Issuer @ 04/09/24 20:40:43.701 STEP: creating new certificate @ 04/09/24 20:40:43.956 STEP: waiting for certificate to get ready @ 04/09/24 20:40:44.166 STEP: checking for certificate validity from secret contents @ 04/09/24 20:42:27.585 • [117.380 seconds] ------------------------------ SS ------------------------------ ACME Certificate dns-01 challenge using ambient credentials should obtain a valid LetsEncrypt certificate using ClusterIssuer on GCP mint/passthrough cluster /Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e/certificates_test.go:483 STEP: waiting for operator status to become available @ 04/09/24 20:42:36.601 STEP: Getting Infrastructure object @ 04/09/24 20:42:37.003 STEP: Check cloud credential in cluster @ 04/09/24 20:42:37.215 STEP: Creating CredentialsRequest object @ 04/09/24 20:42:37.442 STEP: Waiting for cloud secret to be available @ 04/09/24 20:42:40.528 STEP: Configure cert-manager to use credential, setting this credential secret name in subscription object @ 04/09/24 20:42:56.978 STEP: Creating new certificate ClusterIssuer @ 04/09/24 20:42:57.428 STEP: Creating a test namespace @ 04/09/24 20:42:59.92 STEP: Creating new certificate @ 04/09/24 20:43:00.151 STEP: Waiting for certificate to get ready @ 04/09/24 20:43:02.381 STEP: checking for certificate validity from secret contents @ 04/09/24 20:45:50.794 STEP: resetting cert-manager state @ 04/09/24 20:45:59.698 • [204.037 seconds] ------------------------------ S ------------------------------ [ReportAfterSuite] Autogenerated ReportAfterSuite for --json-report --junit-report autogenerated by Ginkgo [ReportAfterSuite] PASSED [0.011 seconds] ------------------------------ Ran 2 of 21 Specs in 322.247 seconds SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 19 Skipped
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/test e2e-operator
Async /cc @swghosh @xingxingxia
/lgtm /label qe-approved @swghosh help review/merge when having some chance. Thanks!
@lunarwhite: This pull request references CM-318 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.
In response to this:
Configuring an ACME issuer by using explicit credentials for GCP CloudDNS
Similair to "should obtain a valid LetsEncrypt certificate", but change to use CloudDNS DNS-01 solver
Also change the origin case title.
Pass log
Running Suite: Cert Manager Suite - /Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e ============================================================================================================ Random Seed: 1712666438 Will run 2 of 21 specs ------------------------------ [BeforeSuite] /Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e/suite_test.go:85 STEP: creating Kubernetes client set @ 04/09/24 20:40:38.393 STEP: creating cert-manager operator client @ 04/09/24 20:40:38.394 STEP: verifying operator and cert-manager deployments status is available @ 04/09/24 20:40:38.394 STEP: creating dynamic resources client @ 04/09/24 20:40:39.215 STEP: creating openshift config client @ 04/09/24 20:40:39.219 STEP: creating cert-manager client @ 04/09/24 20:40:39.219 [BeforeSuite] PASSED [0.828 seconds] ------------------------------ SSSSSSSSSSSSSSSS ------------------------------ ACME Certificate dns-01 challenge using explicit credentials should obtain a valid LetsEncrypt certificate on GCP cluster /Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e/certificates_test.go:178 STEP: creating Kube clients @ 04/09/24 20:40:39.22 STEP: adding override args to cert-manager controller @ 04/09/24 20:40:39.453 STEP: waiting for operator status to become available @ 04/09/24 20:40:39.887 STEP: creating a test namespace @ 04/09/24 20:40:42.296 STEP: obtaining GCP credentials from kube-system namespace @ 04/09/24 20:40:43.003 STEP: copying GCP secret service account to test namespace @ 04/09/24 20:40:43.225 STEP: getting GCP project id from Infrastructure object @ 04/09/24 20:40:43.489 STEP: creating new certificate Issuer @ 04/09/24 20:40:43.701 STEP: creating new certificate @ 04/09/24 20:40:43.956 STEP: waiting for certificate to get ready @ 04/09/24 20:40:44.166 STEP: checking for certificate validity from secret contents @ 04/09/24 20:42:27.585 • [117.380 seconds] ------------------------------ SS ------------------------------ ACME Certificate dns-01 challenge using ambient credentials should obtain a valid LetsEncrypt certificate using ClusterIssuer on GCP mint/passthrough cluster /Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e/certificates_test.go:483 STEP: waiting for operator status to become available @ 04/09/24 20:42:36.601 STEP: Getting Infrastructure object @ 04/09/24 20:42:37.003 STEP: Check cloud credential in cluster @ 04/09/24 20:42:37.215 STEP: Creating CredentialsRequest object @ 04/09/24 20:42:37.442 STEP: Waiting for cloud secret to be available @ 04/09/24 20:42:40.528 STEP: Configure cert-manager to use credential, setting this credential secret name in subscription object @ 04/09/24 20:42:56.978 STEP: Creating new certificate ClusterIssuer @ 04/09/24 20:42:57.428 STEP: Creating a test namespace @ 04/09/24 20:42:59.92 STEP: Creating new certificate @ 04/09/24 20:43:00.151 STEP: Waiting for certificate to get ready @ 04/09/24 20:43:02.381 STEP: checking for certificate validity from secret contents @ 04/09/24 20:45:50.794 STEP: resetting cert-manager state @ 04/09/24 20:45:59.698 • [204.037 seconds] ------------------------------ S ------------------------------ [ReportAfterSuite] Autogenerated ReportAfterSuite for --json-report --junit-report autogenerated by Ginkgo [ReportAfterSuite] PASSED [0.011 seconds] ------------------------------ Ran 2 of 21 Specs in 322.247 seconds SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 19 Skipped
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/test fips-image-scan
@swghosh @TrilokGeer help approve when you have a chance :) Same for https://github.com/openshift/cert-manager-operator/pull/179 . Thanks!
/test fips-image-scan
@lunarwhite: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/fips-image-scan | ba7781c5977adf6334f7eb6a7cd160fbc78455c0 | link | true | /test fips-image-scan |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lunarwhite, swghosh, xingxingxia Once this PR has been reviewed and has the lgtm label, please assign trilokgeer for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/label docs-approved /label px-approved No docs and px required for these changes - only e2e test cases are being added.
@lunarwhite: This pull request references CM-318 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.
This pull request references CM-261 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Configuring an ACME issuer by using explicit credentials for GCP CloudDNS
Similair to "should obtain a valid LetsEncrypt certificate", but change to use CloudDNS DNS-01 solver
Also change the origin case title.
Pass log
Running Suite: Cert Manager Suite - /Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e ============================================================================================================ Random Seed: 1712666438 Will run 2 of 21 specs ------------------------------ [BeforeSuite] /Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e/suite_test.go:85 STEP: creating Kubernetes client set @ 04/09/24 20:40:38.393 STEP: creating cert-manager operator client @ 04/09/24 20:40:38.394 STEP: verifying operator and cert-manager deployments status is available @ 04/09/24 20:40:38.394 STEP: creating dynamic resources client @ 04/09/24 20:40:39.215 STEP: creating openshift config client @ 04/09/24 20:40:39.219 STEP: creating cert-manager client @ 04/09/24 20:40:39.219 [BeforeSuite] PASSED [0.828 seconds] ------------------------------ SSSSSSSSSSSSSSSS ------------------------------ ACME Certificate dns-01 challenge using explicit credentials should obtain a valid LetsEncrypt certificate on GCP cluster /Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e/certificates_test.go:178 STEP: creating Kube clients @ 04/09/24 20:40:39.22 STEP: adding override args to cert-manager controller @ 04/09/24 20:40:39.453 STEP: waiting for operator status to become available @ 04/09/24 20:40:39.887 STEP: creating a test namespace @ 04/09/24 20:40:42.296 STEP: obtaining GCP credentials from kube-system namespace @ 04/09/24 20:40:43.003 STEP: copying GCP secret service account to test namespace @ 04/09/24 20:40:43.225 STEP: getting GCP project id from Infrastructure object @ 04/09/24 20:40:43.489 STEP: creating new certificate Issuer @ 04/09/24 20:40:43.701 STEP: creating new certificate @ 04/09/24 20:40:43.956 STEP: waiting for certificate to get ready @ 04/09/24 20:40:44.166 STEP: checking for certificate validity from secret contents @ 04/09/24 20:42:27.585 • [117.380 seconds] ------------------------------ SS ------------------------------ ACME Certificate dns-01 challenge using ambient credentials should obtain a valid LetsEncrypt certificate using ClusterIssuer on GCP mint/passthrough cluster /Users/yuewu/Documents/workspace/fork/ocp-cert-manager-operator/test/e2e/certificates_test.go:483 STEP: waiting for operator status to become available @ 04/09/24 20:42:36.601 STEP: Getting Infrastructure object @ 04/09/24 20:42:37.003 STEP: Check cloud credential in cluster @ 04/09/24 20:42:37.215 STEP: Creating CredentialsRequest object @ 04/09/24 20:42:37.442 STEP: Waiting for cloud secret to be available @ 04/09/24 20:42:40.528 STEP: Configure cert-manager to use credential, setting this credential secret name in subscription object @ 04/09/24 20:42:56.978 STEP: Creating new certificate ClusterIssuer @ 04/09/24 20:42:57.428 STEP: Creating a test namespace @ 04/09/24 20:42:59.92 STEP: Creating new certificate @ 04/09/24 20:43:00.151 STEP: Waiting for certificate to get ready @ 04/09/24 20:43:02.381 STEP: checking for certificate validity from secret contents @ 04/09/24 20:45:50.794 STEP: resetting cert-manager state @ 04/09/24 20:45:59.698 • [204.037 seconds] ------------------------------ S ------------------------------ [ReportAfterSuite] Autogenerated ReportAfterSuite for --json-report --junit-report autogenerated by Ginkgo [ReportAfterSuite] PASSED [0.011 seconds] ------------------------------ Ran 2 of 21 Specs in 322.247 seconds SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 19 Skipped
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
generally looking fine on the contents of the test case, might need some re-work on the ginkgo /hold please consider merging this only after #194 also, that should take care of the merge conflict IMO
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.