cert-manager-operator icon indicating copy to clipboard operation
cert-manager-operator copied to clipboard

Fix link to metrics documentation in README.md

Open johankok opened this issue 1 year ago • 6 comments

The link returns 404 Not Found, the resource was renamed in 7e670e4. This Pull Request fixes the link in README.md.

johankok avatar Apr 08 '24 10:04 johankok

Hi @johankok. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 08 '24 10:04 openshift-ci[bot]

/lgtm

swghosh avatar Apr 09 '24 09:04 swghosh

/ok-to-test

swghosh avatar Apr 22 '24 07:04 swghosh

/label docs-approved /label px-approved /label qe-approved Self-adding labels, as this is a very minor doc only change, and doesn't alter any operator functionality.

swghosh avatar Apr 22 '24 08:04 swghosh

/retest

johankok avatar Jun 11 '24 09:06 johankok

Is there anything I can do to get this minor doc change approved and merged? Thanks!

johankok avatar Jun 11 '24 09:06 johankok

/cc @TrilokGeer can you help merge this, it's a minor change.

swghosh avatar Jun 12 '24 10:06 swghosh

/test fips-image-scan

swghosh avatar Jun 25 '24 14:06 swghosh

/retest

johankok avatar Jul 11 '24 04:07 johankok

/lgtm /approve

TrilokGeer avatar Jul 16 '24 00:07 TrilokGeer

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johankok, swghosh, TrilokGeer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 16 '24 00:07 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 9cf15f15fa56c1146f6b466077c650af6b3905d9 and 2 for PR HEAD 55c2451a7d06d5e7605f59a8fcb7478cbcade159 in total

openshift-ci-robot avatar Jul 16 '24 05:07 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 46a3d03dc8c018a87138f5a32fd8ed3868329e9b and 1 for PR HEAD 55c2451a7d06d5e7605f59a8fcb7478cbcade159 in total

openshift-ci-robot avatar Jul 16 '24 09:07 openshift-ci-robot

@johankok: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 16 '24 12:07 openshift-ci[bot]