cert-manager-operator
cert-manager-operator copied to clipboard
openshift
MULTIARCH-3780: Added Test Case Modification for IBMCloud and Power
Issue: https://issues.redhat.com/browse/MULTIARCH-3780 updated https://github.com/openshift/cert-manager-operator/blob/master/test/e2e/certificates_test.go
Added new tests:
- dns-01 challenge using explicit credentials on ibm cloud CIS
Modified existing tests:
- dns-01 challenge using explicit credentials
- dns-01 challenge using ambient credentials
Hi @pranitaT. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@lunarwhite @geliu2016 would you like to also help review when available?
@pranitaT: This pull request references MULTIARCH-3780 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.
In response to this:
Issue: https://issues.redhat.com/browse/MULTIARCH-3780 updated https://github.com/openshift/cert-manager-operator/blob/master/test/e2e/certificates_test.go
Added new tests:
- dns-01 challenge using explicit credentials on ibm cloud CIS
- dns-01 challenge using ambient credentials on ibm cloud CIS
Modified existing tests:
- dns-01 challenge using explicit credentials
- dns-01 challenge using ambient credentials
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
If I'm not wrong, we don't have CI setup to run tests on IBM Power yet. Are there any plans to also add CI as follow-up PRs? also cc: @swghosh
If I'm not wrong, we don't have CI setup to run tests on IBM Power yet. Are there any plans to also add CI as follow-up PRs?
Yeah, we dunno have any plans to add CI runs for IBM P/Z systems atleast for now (we can probably look that up in future). However, these tests are intended to be skipped in the normal CI runs which we have for AWS clusters in our current jobs; so it should ideally be really similar to what is being done for GCP in #166. I believe QE intends to run these tests independently in own infra where the necessary cloud provider is available.
Nevertheless, over time we can grow test cases in this same repo and use filters to run e2e tests (i.e. continue to use test/e2e as single source of all e2e cases; irrespective of what's run on pre-sumbits) effectively per platform.
Hey @chiragkyal
If I'm not wrong, we don't have CI setup to run tests on IBM Power yet. Are there any plans to also add CI as follow-up PRs?
That's right
Yeah, we dunno have any plans to add CI runs for IBM P/Z systems atleast for now (we can probably look that up in future). However, these tests are intended to be skipped in the normal CI runs which we have for AWS clusters in our current jobs; so it should ideally be really similar to what is being done for GCP in https://github.com/openshift/cert-manager-operator/pull/166. I believe QE intends to run these tests independently in own infra where the necessary cloud provider is available.
@swghosh we are looking at enabling it as soon as possible.
Thanks
Paul
HI @lunarwhite your comments should be addressed, if acceptable, please let us know. Thank you. Paul
@pranitaT: This pull request references MULTIARCH-3780 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.
In response to this:
Issue: https://issues.redhat.com/browse/MULTIARCH-3780 updated https://github.com/openshift/cert-manager-operator/blob/master/test/e2e/certificates_test.go
Added new tests:
- dns-01 challenge using explicit credentials on ibm cloud CIS
Modified existing tests:
- dns-01 challenge using explicit credentials
- dns-01 challenge using ambient credentials
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@prb112: This pull request references MULTIARCH-3780 which is a valid jira issue.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hey @swghosh Pranita has addressed the code comments, and I have responded in threads to specific points. Please let us know if you need anymore details for the review. Thank you Paul
/cc @TrilokGeer FYI, improvements regarding modularization of test case structure for different cloud providers can be follow-ed up in CM-261.
@prb112 would need https://github.com/openshift/cert-manager-operator/pull/185 to land first in order for that fips-image-scan test to turn green.
/label docs-approved /label px-approved These are non-user facing changes to e2e test cases only. Multi-arch operator already landed in 1.13+.