openshift
add support for virt bundle operators
Adding support for virt bundle in test infra will set up operators required for virt bundle
@bkopilov @danmanor @dudyas6
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: eliajahshan Once this PR has been reviewed and has the lgtm label, please assign rccrdpccl for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @eliajahshan. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@eliajahshan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@eliajahshan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest-required
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@eliajahshan @bkopilov I think it would be better if we will expand this solution to be more generic, then we could use it in our CI as well. For example I think we should add 3 new constants:
virt_bundle_operators = ["cnv", ...]
ai_amd_bundle = [...]
ao_nvidia_bundle = [..]
and add a new installation parameter CLUSTER_BUNDLE that could be set to either ai-amd, ai-nvidia or virtualization, then we will be able to just parameterize a stadard test: @pytest.mark.parametrize("cluster_bundle", [virtualization]).
WDYT ?
@eliajahshan @bkopilov I think it would be better if we will expand this solution to be more generic, then we could use it in our CI as well. For example I think we should add 3 new constants:
virt_bundle_operators = ["cnv", ...] ai_amd_bundle = [...] ao_nvidia_bundle = [..]and add a new installation parameter
CLUSTER_BUNDLEthat could be set to eitherai-amd,ai-nvidiaorvirtualization, then we will be able to just parameterize a stadard test:@pytest.mark.parametrize("cluster_bundle", [virtualization]).WDYT ?
Sounds good to me
@danmanor I like the idea , i can do this starting with the virt bundle
@eliajahshan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-metal-assisted-ha-kube-api-4-19 | f50bd3fd3c4067caa93649cef95e867c78007e1a | link | true | /test e2e-metal-assisted-ha-kube-api-4-19 |
| ci/prow/ansible-lint | f50bd3fd3c4067caa93649cef95e867c78007e1a | link | true | /test ansible-lint |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale