Add natsort package to requirements.txt

[bkopilov]

The package allows us to sort complicated versions with numbers and naming. Using this package in custom ocp tests, getting a list of versions and sorting for last element .

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bkopilov Once this PR has been reviewed and has the lgtm label, please assign omertuc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci[bot]]

Hi @bkopilov. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bkopilov]

@adriengentil , @danmanor

[danmanor]

/ok-te-test

[danmanor]

@bkopilov Why do you add the package but not use it ?

[bkopilov]

@bkopilov Why do you add the package but not use it ?

I am using it in kni-assisted-installer-auto tests which run from podman containers.

[danmanor]

@bkopilov I don't understand, it is not used in this repo, so why add it here ?

[bkopilov]

@bkopilov I don't understand, it is not used in this repo, so why add it here ?

Because here we controll what pip packages are installed on build image. Dockerfile.assisted-test-infra

RUN pip3 install --upgrade pip &&
pip3 install --no-cache-dir -I -r ./requirements.txt -r ./requirements-dev.txt &&
pip3 install --upgrade /build/pip/*

[danmanor]

I mean why not add it to kni-assisted-installer-auto ?

[danmanor]

/ok-to-test

[bkopilov]

/retest

[openshift-ci[bot]]

@bkopilov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-assisted-kube-api-net-suite	95fa27e521fca45463c550a80e572c54e06b6594	link	true	/test e2e-metal-assisted-kube-api-net-suite
ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node	95fa27e521fca45463c550a80e572c54e06b6594	link	false	/test e2e-metal-assisted-kube-api-late-binding-single-node
ci/prow/e2e-metal-assisted	95fa27e521fca45463c550a80e572c54e06b6594	link	true	/test e2e-metal-assisted
ci/prow/e2e-metal-single-node-live-iso	95fa27e521fca45463c550a80e572c54e06b6594	link	true	/test e2e-metal-single-node-live-iso

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[bkopilov]

/restest

[eliorerz]

I mean why not add it to kni-assisted-installer-auto ?

I agree, if it's not used in test-infra I think the best it to add it as a dependency to kni-assisted-installer-auto

[bkopilov]

I mean why not add it to kni-assisted-installer-auto ?

I agree, if it's not used in test-infra I think the best it to add it as a dependency to kni-assisted-installer-auto

Hi , the kni-assisted-installer run from the container (Centos9) the package is part of pip installation on the container. The Dockerfile.assisted-test-infra running the requirements.txt installation .

How can i install the python package from KNI ? Do you mean import pip pip.main(['install', "natsort"])

[bkopilov]

I mean why not add it to kni-assisted-installer-auto ?

I agree, if it's not used in test-infra I think the best it to add it as a dependency to kni-assisted-installer-auto

Hi , the kni-assisted-installer run from the container (Centos9) the package is part of pip installation on the container. The Dockerfile.assisted-test-infra running the requirements.txt installation .

How can i install the python package from KNI ? Do you mean import pip pip.main(['install', "natsort"])

@eliorerz , @lalon4 , Not sure how can i force this package from kni tests , the image docker set by you before we run kni ... and i must update the container package where the code runs from ?

What do you suggest ? the make action is from test-infra... should i call to pip from KNI ?

[eliorerz]

I mean why not add it to kni-assisted-installer-auto ?

I agree, if it's not used in test-infra I think the best it to add it as a dependency to kni-assisted-installer-auto

Hi , the kni-assisted-installer run from the container (Centos9) the package is part of pip installation on the container. The Dockerfile.assisted-test-infra running the requirements.txt installation . How can i install the python package from KNI ? Do you mean import pip pip.main(['install', "natsort"])

@eliorerz , @lalon4 , Not sure how can i force this package from kni tests , the image docker set by you before we run kni ... and i must update the container package where the code runs from ?

What do you suggest ? the make action is from test-infra... should i call to pip from KNI ?

I think that the best approach here is to add another step during kni-auto test-infra image build process, then build a qe-test-infra image using a new Dockerfile with all the dependencies you need.

[bkopilov]

@eliorerz , Ok . i will close it and move the logic to kni-test-infra

[bkopilov]

Moving the logic to kni-test

[bkopilov]

/needs-rebase

[bkopilov]

/retest

[bkopilov]

/retest

[openshift-ci[bot]]

@bkopilov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node	0a8e38032abe108602b23ece731ef56f63c319fa	link	false	/test e2e-metal-assisted-kube-api-late-binding-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[eliorerz]

/retitle NO-ISSUE: Add natsort package to requirements.txt

[openshift-ci-robot]

@bkopilov: This pull request explicitly references no jira issue.

In response to this:

The package allows us to sort complicated versions with numbers and naming. Using this package in custom ocp tests, getting a list of versions and sorting for last element .

Package info: https://pypi.org/project/natsort/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bkopilov, eliorerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [eliorerz]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2fddc7ac1b5643ca896155e1e9c9c6e05c6ae951 and 2 for PR HEAD 0a8e38032abe108602b23ece731ef56f63c319fa in total