assisted-test-infra icon indicating copy to clipboard operation
assisted-test-infra copied to clipboard

WIP MGMT-17250 Replace xinetd with firewallcmd port forwards

Open vrutkovs opened this issue 9 months ago • 9 comments

xinetd is not available on RHEL9, so services need to be port-forwarded with firewallcmd.

TODO:

  • [ ] Fix kill_port_forwardings
  • [ ] Test ipv6

vrutkovs avatar Apr 30 '24 09:04 vrutkovs

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs Once this PR has been reviewed and has the lgtm label, please assign adriengentil for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 30 '24 09:04 openshift-ci[bot]

@vrutkovs I guess most jobs will not pass as openshift-tests will fail, did you tested it works locally ?

danmanor avatar Apr 30 '24 11:04 danmanor

did you tested it works locally

No, I don't have the hardware for this. My plan is:

  • ensure e2e tests pass on rhel8
  • run test with rhel9 via cluster bot to find rhel9-specific issues

vrutkovs avatar Apr 30 '24 11:04 vrutkovs

@vrutkovs I will try as well with RHEL9

danmanor avatar Apr 30 '24 11:04 danmanor

@vrutkovs

make destroy
.
.
.
scripts/utils.sh kill_port_forwardings 'assisted-installer'
usage: 'firewall-cmd --help' for usage information or see firewall-cmd(1) man page
firewall-cmd: error: unrecognized arguments: --remove-forward-ports
usage: 'firewall-cmd --help' for usage information or see firewall-cmd(1) man page
firewall-cmd: error: unrecognized arguments: --remove-forward-ports
usage: 'firewall-cmd --help' for usage information or see firewall-cmd(1) man page
firewall-cmd: error: unrecognized arguments: --remove-forward-ports

danmanor avatar Apr 30 '24 11:04 danmanor

@vrutkovs Also, it is looping on

make run
.
.
.
+ echo 'Verifying URL and port are accessible'
Verifying URL and port are accessible
+ url_reachable http://10.1.178.29:6000
+ curl -s http://10.1.178.29:6000 --max-time 4
+ return 7
+ echo 'Sleeping for 2 seconds'
Sleeping for 2 seconds
+ sleep 2s
+ '[' 11 -eq 0 ']'
+ RETRIES=10
+ echo 'Running given function'
Running given function
+ spawn_port_forwarding_command assisted-service 6000 assisted-installer 0 /root/.kube/config minikube undeclared 8090
+ service_name=assisted-service
+ external_port=6000
+ namespace=assisted-installer
+ namespace_index=0
+ kubeconfig=/root/.kube/config
+ target=minikube
+ ip=undeclared
+ port=8090
+ '[' minikube = minikube ']'
++ kubectl --kubeconfig=/root/.kube/config get nodes '-o=jsonpath={.items[0].status.addresses[0].address}'
+ ip=192.168.39.184
+ '[' -z 8090 ']'
++ kubectl --kubeconfig=/root/.kube/config get svc/assisted-service -n assisted-installer '-o=jsonpath={.spec.ports[?(@.port==8090)].nodePort}'
+ port=31610
+ sudo firewall-cmd --zone=public --add-forward-port=port=6000:proto=tcp:toport=31610:toaddr=192.168.39.184
Warning: ALREADY_ENABLED: '6000:tcp:31610:192.168.39.184' already in 'public'

danmanor avatar Apr 30 '24 11:04 danmanor

@vrutkovs I have an environment with RHEL9.3 ifyou want to test

danmanor avatar Apr 30 '24 11:04 danmanor

@vrutkovs Can you please assign yourself - https://issues.redhat.com/browse/MGMT-17250 ?

danmanor avatar Apr 30 '24 14:04 danmanor

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-assisted-kube-api-net-suite 495a983a0c081346fd33c4af9cda2dbd1dad6da0 link true /test e2e-metal-assisted-kube-api-net-suite
ci/prow/e2e-metal-assisted 495a983a0c081346fd33c4af9cda2dbd1dad6da0 link true /test e2e-metal-assisted
ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node 495a983a0c081346fd33c4af9cda2dbd1dad6da0 link false /test e2e-metal-assisted-kube-api-late-binding-single-node
ci/prow/e2e-metal-single-node-live-iso 495a983a0c081346fd33c4af9cda2dbd1dad6da0 link true /test e2e-metal-single-node-live-iso

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 02 '24 16:05 openshift-ci[bot]