openshift
NO-ISSUE: [master] Bump OCP versions: 4.21, 4.16, 4.12, 4.18, 4.20
OpenShift updates: 4.16.54-multi -> 4.16.55-multi, 4.21.0-rc.1 -> 4.21.0-rc.2, 4.21.0-rc.1-multi -> 4.21.0-rc.2-multi, 4.18.30-multi -> 4.18.31-multi, 4.18.30 -> 4.18.31, 4.16.54 -> 4.16.55, 4.20.8-multi -> 4.20.10-multi, 4.20.8 -> 4.20.10, 4.12.83 -> 4.12.84 RHCOS updates:
/test edge-e2e-metal-assisted-4-21 edge-e2e-metal-assisted-4-16 edge-e2e-metal-assisted-4-12 edge-e2e-metal-assisted-4-18 edge-e2e-metal-assisted-4-20 /cc @rccrdpccl @gamli75
@danmanor: This pull request explicitly references no jira issue.
In response to this:
OpenShift updates: 4.16.54-multi -> 4.16.55-multi, 4.21.0-rc.1 -> 4.21.0-rc.2, 4.21.0-rc.1-multi -> 4.21.0-rc.2-multi, 4.18.30-multi -> 4.18.31-multi, 4.18.30 -> 4.18.31, 4.16.54 -> 4.16.55, 4.20.8-multi -> 4.20.10-multi, 4.20.8 -> 4.20.10, 4.12.83 -> 4.12.84 RHCOS updates:
/test edge-e2e-metal-assisted-4-21 edge-e2e-metal-assisted-4-16 edge-e2e-metal-assisted-4-12 edge-e2e-metal-assisted-4-18 edge-e2e-metal-assisted-4-20 /cc @rccrdpccl @gamli75
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Walkthrough
This pull request updates CRD manifests across multiple locations, downgrades Kubebuilder controller-gen version annotations from v0.17.0 to v0.14.0, adds documentation TODO notes and swagger model annotations to CRD schemas, significantly expands RBAC permissions across multiple API groups and resources, and updates OpenShift release image version references.
Changes
| Cohort / File(s) | Summary |
|---|---|
CRD Base Files config/crd/bases/agent-install.openshift.io_agentclassifications.yaml, config/crd/bases/agent-install.openshift.io_agents.yaml, config/crd/bases/agent-install.openshift.io_agentserviceconfigs.yaml, config/crd/bases/agent-install.openshift.io_hypershiftagentserviceconfigs.yaml, config/crd/bases/agent-install.openshift.io_infraenvs.yaml, config/crd/bases/agent-install.openshift.io_nmstateconfigs.yaml, config/crd/bases/extensions.hive.openshift.io_agentclusterinstalls.yaml |
Kubebuilder controller-gen version downgraded from v0.17.0 to v0.14.0; swagger model annotations and TODO notes added to reference field descriptions for apiVersion/kind/uid fields |
CRD Resources Aggregated File config/crd/resources.yaml |
Consolidated version updates, TODO documentation additions across all referenced CRDs, and swagger model markers (host-role, source\_state, host-stage) added to OpenAPI schema definitions |
RBAC Authorization config/rbac/role.yaml |
ClusterRole permissions significantly expanded across core (""), admission webhooks, agent-install.openshift.io, config.openshift.io, cert-manager.io, apps, rbac.authorization.k8s.io, and route.openshift.io groups; added granular verbs (create/delete/get/list/patch/update/watch) for numerous resources and status/finalizer subresources |
OLM Catalog CRD Manifests deploy/olm-catalog/manifests/agent-install.openshift.io_*.yaml, deploy/olm-catalog/manifests/extensions.hive.openshift.io_agentclusterinstalls.yaml |
Mirrored CRD base changes: controller-gen version downgrade, TODO notes, and swagger model annotations |
OLM Catalog ClusterServiceVersion deploy/olm-catalog/manifests/assisted-service-operator.clusterserviceversion.yaml |
RBAC permissions restructured and expanded identically to config/rbac/role.yaml with broad access across multiple API groups |
Release Image Data data/default_release_images.json, deploy/podman/configmap.yml, openshift/template.yaml |
Release image version entries updated to newer patch versions across multiple architectures (x86\_64, aarch64, multi) |
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~60 minutes
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot] avatar](https://avatars.githubusercontent.com/in/347564?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: danmanor
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [danmanor]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 43.82%. Comparing base (92c71df) to head (ce75293).
Additional details and impacted files
@@ Coverage Diff @@
## master #8763 +/- ##
==========================================
- Coverage 43.83% 43.82% -0.01%
==========================================
Files 414 414
Lines 71753 71753
==========================================
- Hits 31450 31445 -5
- Misses 37446 37449 +3
- Partials 2857 2859 +2
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@danmanor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/edge-verify-generated-code | ce75293aae2ac3fbfb98489ce6afb3b9d44111b2 | link | true | /test edge-verify-generated-code |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Closing as duplicate of https://github.com/openshift/assisted-service/pull/8764