assisted-service icon indicating copy to clipboard operation
assisted-service copied to clipboard
verified publisher icon openshift

OCPBUGS-69811: Updating ose-agent-installer-api-server-container image to be consistent with ART for 4.22

Open openshift-bot opened this issue 2 months ago • 9 comments

Updating ose-agent-installer-api-server-container image to be consistent with ART for 4.22 TLDR: Product builds by ART can be configured for different base and builder images than corresponding CI builds. This automated PR requests a change to CI configuration to align with ART's configuration; please take steps to merge it quickly or contact ART to coordinate changes.

The configuration in the following ART component metadata is driving this alignment request: ose-agent-installer-api-server.yml.

Detail:

This repository is out of sync with the downstream product builds for this component. The CI configuration for at least one image differs from ART's expected product configuration. This should be addressed to ensure that the component's CI testing accurate reflects what customers will experience.

Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a different version, usually prior to GA. The intent is to effect changes in both configurations simultaneously without breaking either CI or ART builds, so usually ART builds are configured to consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may also configure changes in GA releases with CI remaining canonical for a brief grace period to enable CI to succeed and the alignment PR to merge. In either case, ART configuration will be made canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is important to align CI configuration as soon as possible.

PRs are also triggered when CI configuration changes without ART coordination, for instance to change the number of builder images or to use a different golang version. These changes should be coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated first to enable the changes to occur simultaneously in both CI and ART at the same time. This also gives ART a chance to validate the intended changes first. For instance, ART compiles most components with the Golang version being used by the control plane for a given OpenShift release. Exceptions to this convention (i.e. you believe your component must be compiled with a Golang version independent from the control plane) must be granted by the OpenShift staff engineers and communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing tests OR that necessary metadata changes are reported to the ART team: @release-artists in #forum-ocp-art on Slack. If necessary, the changes required by this pull request can be introduced with a separate PR opened by the component team. Once the repository is aligned, this PR will be closed automatically.
  • In particular, it could be that a job like verify-deps is complaining. In that case, please open a new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
  • Patch-manager or those with sufficient privileges within this repository may add any required labels to ensure the PR merges once tests are passing. In cases where ART config is canonical, downstream builds are already being built with these changes, and merging this PR only improves the fidelity of our CI. In cases where ART config is not canonical, this provides a grace period for the component team to align their CI with ART's configuration before it becomes canonical in product builds.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
  from_repository: true

Change behavior of future PRs:

  • In case you just want to follow the base images that ART suggests, you can configure additional labels to be set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future. To do so, open a PR to set the auto_label attribute in the image configuration. Example
  • You can set a commit prefix, like UPSTREAM: <carry>: . An example.

If you have any questions about this pull request, please reach out to @release-artists in the #forum-ocp-art coreos slack channel.

openshift-bot avatar Dec 18 '25 11:12 openshift-bot

Created by ART pipeline job run https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/scheduled-builds/job/sync-ci-images/48103

openshift-bot avatar Dec 18 '25 11:12 openshift-bot

Walkthrough

This pull request updates OpenShift container base image versions from 4.21 to 4.22 across CI/CD configuration and Docker build files. The changes involve updating image tag references in the build root image configuration and Dockerfile base layers without modifying build logic or application code.

Changes

Cohort / File(s) Summary
Version tag updates (4.21 → 4.22)
.ci-operator.yaml, Dockerfile.assisted-service.ocp		 Updated image tags from rhel-9-release-golang-1.24-openshift-4.21 to 4.22 in CI operator configuration and Dockerfile builder/base stages

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward version bumps with no logic or control flow changes
  • Consistent pattern applied across limited file set
  • Low risk, configuration-only updates
✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 184287279c2ecbe5df4e83862cb7a3a33977ffc7 and a4c40405c5ee050a91563345225773418e8546e7.

📒 Files selected for processing (2)
  • .ci-operator.yaml (1 hunks)
  • Dockerfile.assisted-service.ocp (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • Dockerfile.assisted-service.ocp
🔇 Additional comments (3)
.ci-operator.yaml (1)

4-4: Build root image tag update is consistent and correct.

The build root image tag has been updated from 4.21 to 4.22, maintaining the same Go 1.24 toolchain on RHEL 9. This change is consistent with the Dockerfile updates and successfully aligns the CI configuration with ART's product build configuration for OpenShift 4.22.

The version updates are properly synchronized across:

  • .ci-operator.yaml: build root image → 4.22
  • Dockerfile.assisted-service.ocp: builder image → 4.22
  • Dockerfile.assisted-service.ocp: base image → 4.22

As noted in the PR description, ensure all CI tests pass before merging and coordinate with ART (@release-artists in #forum-ocp-art) if any issues arise.

Dockerfile.assisted-service.ocp (2)

14-14: Base image version is consistent across builder, runtime, and CI configuration.

The base image at line 14 (registry.ci.openshift.org/ocp/4.22:base-rhel9) aligns with the builder image (line 2: openshift-4.22) and CI configuration (.ci-operator.yaml: openshift-4.22). The runtime dependencies (postgresql-server, libvirt-libs, nmstate, skopeo, openshift-clients) are appropriate for the base image.

2-2: Builder image version is consistent across configuration files.

The builder image in the Dockerfile (line 2) and .ci-operator.yaml both reference rhel-9-golang-1.24-openshift-4.22, maintaining consistency in the build configuration. No code logic changes are present.

Ensure that:

  1. The registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22 image exists and is accessible
  2. All CI tests pass with the updated builder image before merging

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 18 '25 11:12 coderabbitai[bot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-69811, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Updating ose-agent-installer-api-server-container image to be consistent with ART for 4.22 TLDR: Product builds by ART can be configured for different base and builder images than corresponding CI builds. This automated PR requests a change to CI configuration to align with ART's configuration; please take steps to merge it quickly or contact ART to coordinate changes.

The configuration in the following ART component metadata is driving this alignment request: ose-agent-installer-api-server.yml.

Detail:

This repository is out of sync with the downstream product builds for this component. The CI configuration for at least one image differs from ART's expected product configuration. This should be addressed to ensure that the component's CI testing accurate reflects what customers will experience.

Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a different version, usually prior to GA. The intent is to effect changes in both configurations simultaneously without breaking either CI or ART builds, so usually ART builds are configured to consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may also configure changes in GA releases with CI remaining canonical for a brief grace period to enable CI to succeed and the alignment PR to merge. In either case, ART configuration will be made canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is important to align CI configuration as soon as possible.

PRs are also triggered when CI configuration changes without ART coordination, for instance to change the number of builder images or to use a different golang version. These changes should be coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated first to enable the changes to occur simultaneously in both CI and ART at the same time. This also gives ART a chance to validate the intended changes first. For instance, ART compiles most components with the Golang version being used by the control plane for a given OpenShift release. Exceptions to this convention (i.e. you believe your component must be compiled with a Golang version independent from the control plane) must be granted by the OpenShift staff engineers and communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing tests OR that necessary metadata changes are reported to the ART team: @release-artists in #forum-ocp-art on Slack. If necessary, the changes required by this pull request can be introduced with a separate PR opened by the component team. Once the repository is aligned, this PR will be closed automatically.
  • In particular, it could be that a job like verify-deps is complaining. In that case, please open a new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
  • Patch-manager or those with sufficient privileges within this repository may add any required labels to ensure the PR merges once tests are passing. In cases where ART config is canonical, downstream builds are already being built with these changes, and merging this PR only improves the fidelity of our CI. In cases where ART config is not canonical, this provides a grace period for the component team to align their CI with ART's configuration before it becomes canonical in product builds.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
 from_repository: true

Change behavior of future PRs:

  • In case you just want to follow the base images that ART suggests, you can configure additional labels to be set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future. To do so, open a PR to set the auto_label attribute in the image configuration. Example
  • You can set a commit prefix, like UPSTREAM: <carry>: . An example.

If you have any questions about this pull request, please reach out to @release-artists in the #forum-ocp-art coreos slack channel.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 18 '25 11:12 openshift-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-bot Once this PR has been reviewed and has the lgtm label, please assign omertuc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Dec 18 '25 11:12 openshift-ci[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 43.48%. Comparing base (1842872) to head (a4c4040). :warning: Report is 75 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8601      +/-   ##
==========================================
- Coverage   43.49%   43.48%   -0.01%     
==========================================
  Files         411      411              
  Lines       71244    71244              
==========================================
- Hits        30987    30984       -3     
- Misses      37497    37499       +2     
- Partials     2760     2761       +1

see 2 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 18 '25 12:12 codecov[bot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-69811, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @mhanss

In response to this:

Updating ose-agent-installer-api-server-container image to be consistent with ART for 4.22 TLDR: Product builds by ART can be configured for different base and builder images than corresponding CI builds. This automated PR requests a change to CI configuration to align with ART's configuration; please take steps to merge it quickly or contact ART to coordinate changes.

The configuration in the following ART component metadata is driving this alignment request: ose-agent-installer-api-server.yml.

Detail:

This repository is out of sync with the downstream product builds for this component. The CI configuration for at least one image differs from ART's expected product configuration. This should be addressed to ensure that the component's CI testing accurate reflects what customers will experience.

Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a different version, usually prior to GA. The intent is to effect changes in both configurations simultaneously without breaking either CI or ART builds, so usually ART builds are configured to consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may also configure changes in GA releases with CI remaining canonical for a brief grace period to enable CI to succeed and the alignment PR to merge. In either case, ART configuration will be made canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is important to align CI configuration as soon as possible.

PRs are also triggered when CI configuration changes without ART coordination, for instance to change the number of builder images or to use a different golang version. These changes should be coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated first to enable the changes to occur simultaneously in both CI and ART at the same time. This also gives ART a chance to validate the intended changes first. For instance, ART compiles most components with the Golang version being used by the control plane for a given OpenShift release. Exceptions to this convention (i.e. you believe your component must be compiled with a Golang version independent from the control plane) must be granted by the OpenShift staff engineers and communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing tests OR that necessary metadata changes are reported to the ART team: @release-artists in #forum-ocp-art on Slack. If necessary, the changes required by this pull request can be introduced with a separate PR opened by the component team. Once the repository is aligned, this PR will be closed automatically.
  • In particular, it could be that a job like verify-deps is complaining. In that case, please open a new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
  • Patch-manager or those with sufficient privileges within this repository may add any required labels to ensure the PR merges once tests are passing. In cases where ART config is canonical, downstream builds are already being built with these changes, and merging this PR only improves the fidelity of our CI. In cases where ART config is not canonical, this provides a grace period for the component team to align their CI with ART's configuration before it becomes canonical in product builds.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
 from_repository: true

Change behavior of future PRs:

  • In case you just want to follow the base images that ART suggests, you can configure additional labels to be set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future. To do so, open a PR to set the auto_label attribute in the image configuration. Example
  • You can set a commit prefix, like UPSTREAM: <carry>: . An example.

If you have any questions about this pull request, please reach out to @release-artists in the #forum-ocp-art coreos slack channel.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 19 '25 03:12 openshift-ci-robot

/test e2e-agent-compact-ipv4

bfournie avatar Dec 22 '25 14:12 bfournie

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Jan 09 '26 12:01 openshift-merge-robot

@openshift-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-e2e-metal-assisted-4-21 a4c40405c5ee050a91563345225773418e8546e7 link true /test edge-e2e-metal-assisted-4-21

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jan 27 '26 07:01 openshift-ci[bot]