AGENT-538: For ABI, also allow early retrieval of kubeadmin-password

[bfournie]

In https://github.com/openshift/assisted-service/pull/7391 changes were made to allow the kubeconfig to be retrieved in the Ready state for ABI only, in order to be integrate with the OVE UI. This change should also be made for kubeadmin-password, to allow it be retrieved prior to installing the cluster.

Some related changes address additional comments in the PR above.

List all the issues related to this PR

• [ ] New Feature
• [x] Enhancement
• [] Bug fix
• [ ] Tests
• [ ] Documentation
• [ ] CI/CD

What environments does this code impact?

• [ ] Automation (CI, tools, etc)
• [ ] Cloud
• [ ] Operator Managed Deployments
• [x] None

How was this code tested?

• [ ] assisted-test-infra environment
• [x] dev-scripts environment
• [ ] Reviewer's test appreciated
• [ ] Waiting for CI to do a full test run
• [ ] Manual (Elaborate on how it was tested)
• [x] No tests needed

Checklist

• [ ] Title and description added to both, commit and PR.
• [ ] Relevant issues have been associated (see CONTRIBUTING guide)
• [ ] This change does not require a documentation update (docstring, docs, README, etc)
• [ ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@bfournie: This pull request references AGENT-538 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

In https://github.com/openshift/assisted-service/pull/7391 changes were made to allow the kubeconfig to be retrieved in the Ready state for ABI only, in order to be integrate with the OVE UI. This change should also be made for kubeadmin-password, to allow it be retrieved prior to installing the cluster.

Some related changes address additional comments in the PR above.

List all the issues related to this PR

• [ ] New Feature
• [x] Enhancement
• [] Bug fix
• [ ] Tests
• [ ] Documentation
• [ ] CI/CD

What environments does this code impact?

• [ ] Automation (CI, tools, etc)
• [ ] Cloud
• [ ] Operator Managed Deployments
• [x] None

How was this code tested?

• [ ] assisted-test-infra environment
• [x] dev-scripts environment
• [ ] Reviewer's test appreciated
• [ ] Waiting for CI to do a full test run
• [ ] Manual (Elaborate on how it was tested)
• [x] No tests needed

Checklist

• [ ] Title and description added to both, commit and PR.
• [ ] Relevant issues have been associated (see CONTRIBUTING guide)
• [ ] This change does not require a documentation update (docstring, docs, README, etc)
• [ ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bfournie]

/cc @andfasano @danielerez

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 6.45161% with 29 lines in your changes missing coverage. Please review.

Project coverage is 67.28%. Comparing base (15f5bc0) to head (92f4048). Report is 19 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/common/error_utils.go	0.00%	13 Missing :warning:
internal/cluster/cluster.go	0.00%	11 Missing :warning:
internal/bminventory/inventory.go	28.57%	4 Missing and 1 partial :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7472      +/-   ##
==========================================
- Coverage   67.40%   67.28%   -0.12%     
==========================================
  Files         329      334       +5     
  Lines       42191    42257      +66     
==========================================
- Hits        28437    28434       -3     
- Misses      11182    11253      +71     
+ Partials     2572     2570       -2     

Files with missing lines	Coverage Δ
internal/bminventory/inventory.go	71.57% <28.57%> (+0.01%)	:arrow_up:
internal/cluster/cluster.go	65.56% <0.00%> (+0.34%)	:arrow_up:
internal/common/error_utils.go	0.00% <0.00%> (ø)

... and 20 files with indirect coverage changes

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[andfasano]

/lgtm

[andfasano]

cc @danielerez

[andfasano]

Thanks @bfournie tested locally the new patch and was working fine!

/lgtm

[andfasano]

cc @danielerez for approval

[danielerez]

/retest

[danielerez]

/retest

[danielerez]

/retest

[danielerez]

Hey @bfournie. Not sure if the subsystem failures related to the change. Have you maybe tried to run them locally?

[bfournie]

Hey @bfournie. Not sure if the subsystem failures related to the change. Have you maybe tried to run them locally? I haven't been able to get subsystem tests to run locally yet.

The subsystem- kubeapi-aws looks likes its failing the same way, sporadically, in other PRs, so this one's probably not an issue. I'm not sure yet about edge-subsystem-aws as I don't see other PRs with this same failure. I wonder if its related to the workdir check as it wasn't failing before that was introduced.

[bfournie]

/retest

[andfasano]

/retest

[andfasano]

@danielerez any idea about the reason of the aws failures?

By looking at the aws failure it looks like at least 37 tests are failing because the installation hang for some reason

[andfasano]

/lgtm

[danielerez]

/approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, danielerez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [danielerez]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci[bot]]

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.