assisted-service icon indicating copy to clipboard operation
assisted-service copied to clipboard

NO-ISSUE: fix kind with rootless user

Open eifrach opened this issue 1 year ago • 8 comments

List all the issues related to this PR

  • [ ] New Feature
  • [ ] Enhancement
  • [ ] Bug fix
  • [ ] Tests
  • [ ] Documentation
  • [ ] CI/CD

What environments does this code impact?

  • [ ] Automation (CI, tools, etc)
  • [ ] Cloud
  • [ ] Operator Managed Deployments
  • [x] None

How was this code tested?

  • [ ] assisted-test-infra environment
  • [ ] dev-scripts environment
  • [ ] Reviewer's test appreciated
  • [ ] Waiting for CI to do a full test run
  • [ ] Manual (Elaborate on how it was tested)
  • [x] No tests needed

Checklist

  • [ ] Title and description added to both, commit and PR.
  • [ ] Relevant issues have been associated (see CONTRIBUTING guide)
  • [ ] This change does not require a documentation update (docstring, docs, README, etc)
  • [ ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

eifrach avatar Sep 02 '24 14:09 eifrach

@eifrach: This pull request explicitly references no jira issue.

In response to this:

List all the issues related to this PR

  • [ ] New Feature
  • [ ] Enhancement
  • [ ] Bug fix
  • [ ] Tests
  • [ ] Documentation
  • [ ] CI/CD

What environments does this code impact?

  • [ ] Automation (CI, tools, etc)
  • [ ] Cloud
  • [ ] Operator Managed Deployments
  • [x] None

How was this code tested?

  • [ ] assisted-test-infra environment
  • [ ] dev-scripts environment
  • [ ] Reviewer's test appreciated
  • [ ] Waiting for CI to do a full test run
  • [ ] Manual (Elaborate on how it was tested)
  • [x] No tests needed

Checklist

  • [ ] Title and description added to both, commit and PR.
  • [ ] Relevant issues have been associated (see CONTRIBUTING guide)
  • [ ] This change does not require a documentation update (docstring, docs, README, etc)
  • [ ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 02 '24 14:09 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 02 '24 14:09 openshift-ci[bot]

/cc @danmanor

eifrach avatar Sep 02 '24 15:09 eifrach

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.61%. Comparing base (28f6c35) to head (e4c5936). Report is 89 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6714      +/-   ##
==========================================
- Coverage   68.62%   68.61%   -0.01%     
==========================================
  Files         246      246              
  Lines       36893    36893              
==========================================
- Hits        25316    25315       -1     
- Misses       9316     9317       +1     
  Partials     2261     2261              

see 3 files with indirect coverage changes

codecov[bot] avatar Sep 02 '24 15:09 codecov[bot]

Where is this coming from ? what error you got ? @eifrach

danmanor avatar Sep 03 '24 08:09 danmanor

Where is this coming from ? what error you got ? @eifrach

when running as a regular user on my laptop ( non-root)

eifrach avatar Sep 04 '24 08:09 eifrach

/test edge-e2e-metal-assisted --


eifrach avatar Sep 04 '24 08:09 eifrach

@eifrach: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-e2e-metal-assisted e4c5936aed1ead62dd83dc051ceb886737cc3352 link true /test edge-e2e-metal-assisted
ci/prow/edge-e2e-metal-assisted-odf-4-17 e4c5936aed1ead62dd83dc051ceb886737cc3352 link true /test edge-e2e-metal-assisted-odf-4-17
ci/prow/edge-e2e-metal-assisted-cnv-4-17 e4c5936aed1ead62dd83dc051ceb886737cc3352 link true /test edge-e2e-metal-assisted-cnv-4-17
ci/prow/edge-e2e-metal-assisted-mtv-4-17 e4c5936aed1ead62dd83dc051ceb886737cc3352 link true /test edge-e2e-metal-assisted-mtv-4-17

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 28 '24 13:10 openshift-ci[bot]