openshift
[WIP] MGMT-18013: Add kube api support for adding mirror registry in agent cluster install
List all the issues related to this PR
- [x] New Feature
- [ ] Enhancement
- [ ] Bug fix
- [ ] Tests
- [ ] Documentation
- [ ] CI/CD
What environments does this code impact?
- [ ] Automation (CI, tools, etc)
- [ ] Cloud
- [x] Operator Managed Deployments
- [ ] None
How was this code tested?
- [ ] assisted-test-infra environment
- [ ] dev-scripts environment
- [ ] Reviewer's test appreciated
- [x] Waiting for CI to do a full test run
- [x] Manual (Elaborate on how it was tested)
- [ ] No tests needed
/cc @eliorerz
@eliorerz: This pull request references MGMT-18013 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
List all the issues related to this PR
- [x] New Feature
- [ ] Enhancement
- [ ] Bug fix
- [ ] Tests
- [ ] Documentation
- [ ] CI/CD
What environments does this code impact?
- [ ] Automation (CI, tools, etc)
- [ ] Cloud
- [x] Operator Managed Deployments
- [ ] None
How was this code tested?
- [ ] assisted-test-infra environment
- [ ] dev-scripts environment
- [ ] Reviewer's test appreciated
- [x] Waiting for CI to do a full test run
- [x] Manual (Elaborate on how it was tested)
- [ ] No tests needed
/cc @eliorerz
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@eliorerz: GitHub didn't allow me to request PR reviews from the following users: eliorerz.
Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
List all the issues related to this PR
- [x] New Feature
- [ ] Enhancement
- [ ] Bug fix
- [ ] Tests
- [ ] Documentation
- [ ] CI/CD
What environments does this code impact?
- [ ] Automation (CI, tools, etc)
- [ ] Cloud
- [x] Operator Managed Deployments
- [ ] None
How was this code tested?
- [ ] assisted-test-infra environment
- [ ] dev-scripts environment
- [ ] Reviewer's test appreciated
- [x] Waiting for CI to do a full test run
- [x] Manual (Elaborate on how it was tested)
- [ ] No tests needed
/cc @eliorerz
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: eliorerz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [eliorerz]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@eliorerz: The following commands are available to trigger required jobs:
/test e2e-agent-compact-ipv4/test edge-assisted-operator-catalog-publish-verify/test edge-ci-index/test edge-e2e-ai-operator-ztp/test edge-e2e-ai-operator-ztp-sno-day2-workers/test edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding/test edge-e2e-metal-assisted/test edge-e2e-metal-assisted-4-12/test edge-e2e-metal-assisted-cnv-4-16/test edge-e2e-metal-assisted-lvm/test edge-e2e-metal-assisted-odf-4-16/test edge-images/test edge-lint/test edge-subsystem-aws/test edge-subsystem-kubeapi-aws/test edge-unit-test/test edge-verify-generated-code/test images/test mce-images
The following commands are available to trigger optional jobs:
/test e2e-agent-ha-dualstack/test e2e-agent-sno-ipv6/test edge-e2e-ai-operator-disconnected-capi/test edge-e2e-ai-operator-ztp-3masters/test edge-e2e-ai-operator-ztp-capi/test edge-e2e-ai-operator-ztp-compact-day2-masters/test edge-e2e-ai-operator-ztp-compact-day2-workers/test edge-e2e-ai-operator-ztp-disconnected/test edge-e2e-ai-operator-ztp-hypershift-zero-nodes/test edge-e2e-ai-operator-ztp-multiarch-3masters-ocp/test edge-e2e-ai-operator-ztp-multiarch-sno-ocp/test edge-e2e-ai-operator-ztp-node-labels/test edge-e2e-ai-operator-ztp-sno-day2-masters/test edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride/test edge-e2e-metal-assisted-4-13/test edge-e2e-metal-assisted-4-14/test edge-e2e-metal-assisted-4-15/test edge-e2e-metal-assisted-4-16/test edge-e2e-metal-assisted-bond/test edge-e2e-metal-assisted-bond-4-14/test edge-e2e-metal-assisted-day2/test edge-e2e-metal-assisted-day2-arm-workers/test edge-e2e-metal-assisted-day2-single-node/test edge-e2e-metal-assisted-external/test edge-e2e-metal-assisted-external-4-14/test edge-e2e-metal-assisted-ipv4v6/test edge-e2e-metal-assisted-ipv6/test edge-e2e-metal-assisted-kube-api-late-binding-single-node/test edge-e2e-metal-assisted-kube-api-late-unbinding-ipv4-single-node/test edge-e2e-metal-assisted-kube-api-net-suite/test edge-e2e-metal-assisted-mce-4-16/test edge-e2e-metal-assisted-mce-sno-4-16/test edge-e2e-metal-assisted-metallb/test edge-e2e-metal-assisted-none/test edge-e2e-metal-assisted-onprem/test edge-e2e-metal-assisted-single-node/test edge-e2e-metal-assisted-static-ip-suite/test edge-e2e-metal-assisted-static-ip-suite-4-14/test edge-e2e-metal-assisted-tang/test edge-e2e-metal-assisted-tpmv2/test edge-e2e-metal-assisted-upgrade-agent/test edge-e2e-nutanix-assisted/test edge-e2e-nutanix-assisted-2workers/test edge-e2e-nutanix-assisted-4-14/test edge-e2e-oci-assisted/test edge-e2e-oci-assisted-4-14/test edge-e2e-oci-assisted-iscsi/test edge-e2e-vsphere-assisted/test edge-e2e-vsphere-assisted-4-14/test edge-e2e-vsphere-assisted-4-15/test edge-e2e-vsphere-assisted-4-16/test edge-e2e-vsphere-assisted-umn/test okd-scos-images/test push-pr-image
Use /test all to run the following jobs that were automatically triggered:
pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4pull-ci-openshift-assisted-service-master-edge-assisted-operator-catalog-publish-verifypull-ci-openshift-assisted-service-master-edge-ci-indexpull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-disconnected-capipull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztppull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-capipull-ci-openshift-assisted-service-master-edge-e2e-metal-assistedpull-ci-openshift-assisted-service-master-edge-imagespull-ci-openshift-assisted-service-master-edge-lintpull-ci-openshift-assisted-service-master-edge-subsystem-awspull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-awspull-ci-openshift-assisted-service-master-edge-unit-testpull-ci-openshift-assisted-service-master-edge-verify-generated-codepull-ci-openshift-assisted-service-master-imagespull-ci-openshift-assisted-service-master-mce-images
In response to this:
/test ?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
Attention: Patch coverage is 60.65574% with 72 lines in your changes missing coverage. Please review.
Project coverage is 66.76%. Comparing base (
63e8b0d) to head (c296dbc). Report is 36 commits behind head on master.
:exclamation: Current head c296dbc differs from pull request most recent head 109fc2a
Please upload reports for the commit 109fc2a to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #6646 +/- ##
==========================================
- Coverage 68.69% 66.76% -1.94%
==========================================
Files 249 220 -29
Lines 37313 27406 -9907
==========================================
- Hits 25633 18298 -7335
+ Misses 9387 7519 -1868
+ Partials 2293 1589 -704
| Flag | Coverage Δ | |
|---|---|---|
66.76% <60.65%> (-1.94%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/bminventory/inventory_v2_handlers.go | 56.60% <100.00%> (ø) |
|
| internal/oc/release.go | 71.48% <100.00%> (ø) |
|
| internal/bminventory/inventory.go | 70.72% <92.30%> (+0.01%) |
:arrow_up: |
| pkg/mirrorregistries/generator.go | 62.50% <66.66%> (-2.09%) |
:arrow_down: |
| internal/installcfg/builder/builder.go | 80.10% <67.79%> (-2.82%) |
:arrow_down: |
| pkg/mirrorregistries/cluster_image_registry.go | 41.97% <41.97%> (ø) |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Just a head's up that Nick is putting in a change for the operator to always include the hub's OCP cluster's CA certificate bundle https://github.com/openshift/assisted-service/pull/6649
Another consideration is if the user supplies an overall Hub Cluster mirror registry CA certificate (that will now be merged with the Hub Cluster's CA bundle from the above PR). We should handle the case where they provide both a per spoke cluster mirror registry CA and a mirror registry CA in the hub cluster.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@eliorerz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/edge-e2e-metal-assisted-odf-4-16 | b8b6761eca975113eb7151514cd34a077d0b580a | link | true | /test edge-e2e-metal-assisted-odf-4-16 |
| ci/prow/edge-e2e-metal-assisted-cnv-4-16 | b8b6761eca975113eb7151514cd34a077d0b580a | link | true | /test edge-e2e-metal-assisted-cnv-4-16 |
| ci/prow/edge-subsystem-kubeapi-aws | c296dbc1cdacd3fd637a41b38640d9c4dae3aaab | link | true | /test edge-subsystem-kubeapi-aws |
| ci/prow/edge-unit-test | c296dbc1cdacd3fd637a41b38640d9c4dae3aaab | link | true | /test edge-unit-test |
| ci/prow/edge-e2e-metal-assisted-odf-4-17 | 109fc2a6c91c9b6f99fc79d60a63ff5ef0cf9227 | link | true | /test edge-e2e-metal-assisted-odf-4-17 |
| ci/prow/edge-e2e-metal-assisted-cnv-4-17 | 109fc2a6c91c9b6f99fc79d60a63ff5ef0cf9227 | link | true | /test edge-e2e-metal-assisted-cnv-4-17 |
| ci/prow/edge-e2e-metal-assisted-mtv-4-17 | 109fc2a6c91c9b6f99fc79d60a63ff5ef0cf9227 | link | true | /test edge-e2e-metal-assisted-mtv-4-17 |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.