openshift
MGMT-18231: Block iSCSI as an installation disk when its holder is multipath
Currently, customers can select an iSCSI disk as an installation disk when its holder is multipath. We have decided to block this option for now.
List all the issues related to this PR
- [ ] New Feature
- [ ] Enhancement
- [X] Bug fix
- [X] Tests
- [ ] Documentation
- [ ] CI/CD
What environments does this code impact?
- [ ] Automation (CI, tools, etc)
- [ ] Cloud
- [ ] Operator Managed Deployments
- [x] None
How was this code tested?
- [X] assisted-test-infra environment
- [ ] dev-scripts environment
- [ ] Reviewer's test appreciated
- [ ] Waiting for CI to do a full test run
- [ ] Manual (Elaborate on how it was tested)
- [x] No tests needed
Checklist
- [X] Title and description added to both, commit and PR.
- [ ] Relevant issues have been associated (see CONTRIBUTING guide)
- [X] This change does not require a documentation update (docstring,
docs, README, etc) - [X] Does this change include unit-tests (note that code changes require unit-tests)
Reviewers Checklist
- Are the title and description (in both PR and commit) meaningful and clear?
- Is there a bug required (and linked) for this change?
- Should this PR be backported?
@linoyaslan: This pull request references MGMT-18231 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.
In response to this:
Currently, customers can select an iSCSI disk as an installation disk when its holder is multipath, which leads to OCP installation failures. My fix blocks this option.
List all the issues related to this PR
- [ ] New Feature
- [ ] Enhancement
- [X] Bug fix
- [X] Tests
- [ ] Documentation
- [ ] CI/CD
What environments does this code impact?
- [ ] Automation (CI, tools, etc)
- [ ] Cloud
- [ ] Operator Managed Deployments
- [x] None
How was this code tested?
- [X] assisted-test-infra environment
- [ ] dev-scripts environment
- [ ] Reviewer's test appreciated
- [ ] Waiting for CI to do a full test run
- [ ] Manual (Elaborate on how it was tested)
- [x] No tests needed
Checklist
- [X] Title and description added to both, commit and PR.
- [ ] Relevant issues have been associated (see CONTRIBUTING guide)
- [X] This change does not require a documentation update (docstring,
docs, README, etc)- [X] Does this change include unit-tests (note that code changes require unit-tests)
Reviewers Checklist
- Are the title and description (in both PR and commit) meaningful and clear?
- Is there a bug required (and linked) for this change?
- Should this PR be backported?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.58%. Comparing base (
77c8d88) to head (aed86ca). Report is 2 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #6612 +/- ##
==========================================
+ Coverage 68.55% 68.58% +0.02%
==========================================
Files 246 246
Lines 36684 36700 +16
==========================================
+ Hits 25148 25169 +21
+ Misses 9297 9294 -3
+ Partials 2239 2237 -2
| Files | Coverage Δ | |
|---|---|---|
| internal/hardware/validator.go | 78.08% <100.00%> (+0.90%) |
:arrow_up: |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@linoyaslan: This pull request references MGMT-18231 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.
In response to this:
Currently, customers can select an iSCSI disk as an installation disk when its holder is multipath. We have decided to block this option for now.
List all the issues related to this PR
- [ ] New Feature
- [ ] Enhancement
- [X] Bug fix
- [X] Tests
- [ ] Documentation
- [ ] CI/CD
What environments does this code impact?
- [ ] Automation (CI, tools, etc)
- [ ] Cloud
- [ ] Operator Managed Deployments
- [x] None
How was this code tested?
- [X] assisted-test-infra environment
- [ ] dev-scripts environment
- [ ] Reviewer's test appreciated
- [ ] Waiting for CI to do a full test run
- [ ] Manual (Elaborate on how it was tested)
- [x] No tests needed
Checklist
- [X] Title and description added to both, commit and PR.
- [ ] Relevant issues have been associated (see CONTRIBUTING guide)
- [X] This change does not require a documentation update (docstring,
docs, README, etc)- [X] Does this change include unit-tests (note that code changes require unit-tests)
Reviewers Checklist
- Are the title and description (in both PR and commit) meaningful and clear?
- Is there a bug required (and linked) for this change?
- Should this PR be backported?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/test edge-e2e-oci-assisted-iscsi
the test will fail, but we should try to perform the installation
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adriengentil, linoyaslan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [adriengentil]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/retest-required
Remaining retests: 0 against base HEAD a53b0e282cc72808e7960c6c57a775cc0f93daba and 2 for PR HEAD aed86ca89a04b2da69bdc5b0763fca3175236a96 in total
@linoyaslan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/edge-e2e-oci-assisted-iscsi | aed86ca89a04b2da69bdc5b0763fca3175236a96 | link | false | /test edge-e2e-oci-assisted-iscsi |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: ose-agent-installer-api-server This PR has been included in build ose-agent-installer-api-server-container-v4.18.0-202408021814.p0.gd67e193.assembly.stream.el9. All builds following this will include this PR.
