assisted-service icon indicating copy to clipboard operation
assisted-service copied to clipboard

[MGMT-18378] allow CNV on ARM as dev preview

Open eifrach opened this issue 1 year ago • 9 comments

  • Enabling CNV for ARM platfrom for versions 4.14+ as tech preview
  • Adding unit-tests for CNV

List all the issues related to this PR

  • [ ] New Feature
  • [X] Enhancement
  • [ ] Bug fix
  • [ ] Tests
  • [ ] Documentation
  • [ ] CI/CD

What environments does this code impact?

  • [ ] Automation (CI, tools, etc)
  • [ ] Cloud
  • [ ] Operator Managed Deployments
  • [x] None

How was this code tested?

  • [X] assisted-test-infra environment
  • [ ] dev-scripts environment
  • [ ] Reviewer's test appreciated
  • [ ] Waiting for CI to do a full test run
  • [ ] Manual (Elaborate on how it was tested)
  • [x] No tests needed

eifrach avatar Jul 15 '24 08:07 eifrach

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Jul 15 '24 08:07 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 15 '24 08:07 openshift-ci[bot]

/test edge-unit-test /test edge-lint

eifrach avatar Jul 15 '24 08:07 eifrach

/test edge-images /test images

eifrach avatar Jul 15 '24 08:07 eifrach

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.50%. Comparing base (72f3ee2) to head (83a0b0a). Report is 32 commits behind head on master.

:exclamation: Current head 83a0b0a differs from pull request most recent head d369965

Please upload reports for the commit d369965 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6571      +/-   ##
==========================================
+ Coverage   68.36%   68.50%   +0.13%     
==========================================
  Files         247      243       -4     
  Lines       36687    36417     -270     
==========================================
- Hits        25082    24947     -135     
+ Misses       9378     9252     -126     
+ Partials     2227     2218       -9     
Files Coverage Δ
internal/featuresupport/features_olm_operators.go 89.11% <100.00%> (+1.88%) :arrow_up:

... and 14 files with indirect coverage changes

codecov[bot] avatar Jul 15 '24 09:07 codecov[bot]

/test edge-lint

eifrach avatar Jul 15 '24 11:07 eifrach

/test edge-unit-test /test edge-lint /test edge-images /test images

eifrach avatar Jul 25 '24 09:07 eifrach

/test edge-subsystem-aws

eifrach avatar Jul 25 '24 09:07 eifrach

@eifrach: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-subsystem-aws 83a0b0ab52fbf5ca79a4b24f3bc88b8015c4b605 link true /test edge-subsystem-aws
ci/prow/edge-unit-test 83a0b0ab52fbf5ca79a4b24f3bc88b8015c4b605 link true /test edge-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 25 '24 10:07 openshift-ci[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Aug 04 '24 08:08 openshift-merge-robot