assisted-service icon indicating copy to clipboard operation
assisted-service copied to clipboard
verified publisher icon openshift

MULTIARCH-4515: Bump version dependency.

Open AmadeusPodvratnik opened this issue 1 year ago • 42 comments

Bump version for MULTIARCH-4515: Add support for ins-file as boot artefact.

go get github.com/openshift/assisted-image-service@d3f8a0398019e0858bf78319156249218912ce09 go mod tidy go mod vendor

List all the issues related to this PR

  • [] New Feature
  • [x] Enhancement
  • [ ] Bug fix
  • [ ] Tests
  • [ ] Documentation
  • [ ] CI/CD

What environments does this code impact?

  • [ ] Automation (CI, tools, etc)
  • [ ] Cloud
  • [ ] Operator Managed Deployments
  • [x] None

How was this code tested?

  • [ ] assisted-test-infra environment
  • [ ] dev-scripts environment
  • [ ] Reviewer's test appreciated
  • [ ] Waiting for CI to do a full test run
  • [ ] Manual (Elaborate on how it was tested)
  • [x] No tests needed

Checklist

  • [x] Title and description added to both, commit and PR.
  • [x] Relevant issues have been associated (see CONTRIBUTING guide)
  • [x] This change does not require a documentation update (docstring, docs, README, etc)
  • [ ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

AmadeusPodvratnik avatar May 27 '24 10:05 AmadeusPodvratnik

@AmadeusPodvratnik: This pull request references MULTIARCH-4515 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Bump version for MULTIARCH-4515: Add support for ins-file as boot artefact.

go get github.com/openshift/assisted-image-service@d3f8a0398019e0858bf78319156249218912ce09 go mod tidy go mod vendor

List all the issues related to this PR

  • [] New Feature
  • [x] Enhancement
  • [ ] Bug fix
  • [ ] Tests
  • [ ] Documentation
  • [ ] CI/CD

What environments does this code impact?

  • [ ] Automation (CI, tools, etc)
  • [ ] Cloud
  • [ ] Operator Managed Deployments
  • [x] None

How was this code tested?

  • [ ] assisted-test-infra environment
  • [ ] dev-scripts environment
  • [ ] Reviewer's test appreciated
  • [ ] Waiting for CI to do a full test run
  • [ ] Manual (Elaborate on how it was tested)
  • [x] No tests needed

Checklist

  • [x] Title and description added to both, commit and PR.
  • [x] Relevant issues have been associated (see CONTRIBUTING guide)
  • [x] This change does not require a documentation update (docstring, docs, README, etc)
  • [ ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 27 '24 10:05 openshift-ci-robot

/lgtm

omertuc avatar May 28 '24 11:05 omertuc

/approve

omertuc avatar May 28 '24 11:05 omertuc

/ok-to-test

omertuc avatar May 28 '24 11:05 omertuc

Hopefully the gomega bump won't lead to any test failures...

omertuc avatar May 28 '24 11:05 omertuc

/retest-required

Remaining retests: 0 against base HEAD ffa8b5c57785f9fd63d892fbee1510676af7d71a and 2 for PR HEAD b8ad3de8431ff257834531202f4bdd8954449b79 in total

openshift-ci-robot avatar May 28 '24 11:05 openshift-ci-robot

@omertuc I see some test failures ... just checking if this is related to gomega ...

What I found so far is this: https://github.com/prometheus/client_golang/releases/tag/v1.19.0 there is an issue with prometheus/common and client_golang but the versions inside go.mod shows the requried version.

AmadeusPodvratnik avatar May 28 '24 11:05 AmadeusPodvratnik

The issues are due to the image-service repo having go 1.21 while the assisted-service repo has go 1.20

omertuc avatar May 28 '24 11:05 omertuc

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.43%. Comparing base (780deff) to head (3103d30). Report is 213 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #6373    +/-   ##
========================================
  Coverage   68.43%   68.43%            
========================================
  Files         244      247     +3     
  Lines       35999    36230   +231     
========================================
+ Hits        24635    24795   +160     
- Misses       9191     9235    +44     
- Partials     2173     2200    +27

see 20 files with indirect coverage changes

codecov[bot] avatar May 28 '24 11:05 codecov[bot]

/retest-required

AmadeusPodvratnik avatar May 28 '24 11:05 AmadeusPodvratnik

/retest-required

AmadeusPodvratnik avatar May 28 '24 12:05 AmadeusPodvratnik

/test edge-images

AmadeusPodvratnik avatar May 28 '24 12:05 AmadeusPodvratnik

/retest

AmadeusPodvratnik avatar May 29 '24 14:05 AmadeusPodvratnik

/retest

AmadeusPodvratnik avatar Jun 03 '24 12:06 AmadeusPodvratnik

/retest

AmadeusPodvratnik avatar Jun 03 '24 12:06 AmadeusPodvratnik

/retest

AmadeusPodvratnik avatar Jun 03 '24 14:06 AmadeusPodvratnik

/retest

AmadeusPodvratnik avatar Jun 03 '24 14:06 AmadeusPodvratnik

/retest

AmadeusPodvratnik avatar Jun 04 '24 08:06 AmadeusPodvratnik

/retest

AmadeusPodvratnik avatar Jun 04 '24 09:06 AmadeusPodvratnik

/retest

AmadeusPodvratnik avatar Jun 04 '24 10:06 AmadeusPodvratnik

/retest

AmadeusPodvratnik avatar Jun 11 '24 10:06 AmadeusPodvratnik

/retest

AmadeusPodvratnik avatar Jun 11 '24 13:06 AmadeusPodvratnik

cc @adriengentil @rccrdpccl @gamli75 do we require anything outside of this for a golang version bump?

carbonin avatar Jun 11 '24 15:06 carbonin

/lgtm /approve

rccrdpccl avatar Jun 12 '24 08:06 rccrdpccl

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AmadeusPodvratnik, omertuc, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [omertuc,rccrdpccl]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 12 '24 08:06 openshift-ci[bot]

/retest

rccrdpccl avatar Jun 12 '24 10:06 rccrdpccl

@carbonin we will need to change golang version is CI as well (this and more)

Btw good point, I think we need to get some other changes in.

@AmadeusPodvratnik can you please change Golang version in dockerfiles (ci-images/ and root dir)?

rccrdpccl avatar Jun 12 '24 10:06 rccrdpccl

/hold

rccrdpccl avatar Jun 12 '24 10:06 rccrdpccl

@eifrach please review

gamli75 avatar Jun 13 '24 06:06 gamli75

cc @adriengentil @rccrdpccl @gamli75 do we require anything outside of this for a golang version bump?

let's change the go version in the DS images as well https://gitlab.cee.redhat.com/rh-ecosystem-edge/assisted-installer/assisted-installer-projects/-/blob/rhai-1.0-rhel-8/distgit/containers/assisted-service/Dockerfile.in?ref_type=heads

@eifrach has a task to do it in all our repositories - I asked him to review it as well.

gamli75 avatar Jun 13 '24 06:06 gamli75