assisted-service icon indicating copy to clipboard operation
assisted-service copied to clipboard

NO-ISSUE: Add 4.16 rhcos images

Open danmanor opened this issue 1 year ago • 6 comments

List all the issues related to this PR

  • [ ] New Feature
  • [x] Enhancement
  • [ ] Bug fix
  • [ ] Tests
  • [ ] Documentation
  • [ ] CI/CD

What environments does this code impact?

  • [x] Automation (CI, tools, etc)
  • [ ] Cloud
  • [ ] Operator Managed Deployments
  • [ ] None

How was this code tested?

  • [ ] assisted-test-infra environment
  • [ ] dev-scripts environment
  • [ ] Reviewer's test appreciated
  • [x] Waiting for CI to do a full test run
  • [ ] Manual (Elaborate on how it was tested)
  • [ ] No tests needed

Checklist

  • [x] Title and description added to both, commit and PR.
  • [x] Relevant issues have been associated (see CONTRIBUTING guide)
  • [x] This change does not require a documentation update (docstring, docs, README, etc)
  • [ ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

danmanor avatar May 16 '24 09:05 danmanor

@danmanor: This pull request explicitly references no jira issue.

In response to this:

List all the issues related to this PR

  • [ ] New Feature
  • [ ] Enhancement
  • [ ] Bug fix
  • [ ] Tests
  • [ ] Documentation
  • [ ] CI/CD

What environments does this code impact?

  • [ ] Automation (CI, tools, etc)
  • [ ] Cloud
  • [ ] Operator Managed Deployments
  • [x] None

How was this code tested?

  • [ ] assisted-test-infra environment
  • [ ] dev-scripts environment
  • [ ] Reviewer's test appreciated
  • [ ] Waiting for CI to do a full test run
  • [ ] Manual (Elaborate on how it was tested)
  • [x] No tests needed

Checklist

  • [ ] Title and description added to both, commit and PR.
  • [ ] Relevant issues have been associated (see CONTRIBUTING guide)
  • [ ] This change does not require a documentation update (docstring, docs, README, etc)
  • [ ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 16 '24 09:05 openshift-ci-robot

/cc @gamli75 @adriengentil

danmanor avatar May 16 '24 09:05 danmanor

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.97%. Comparing base (fdf233a) to head (fa3162e). Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6326      +/-   ##
==========================================
- Coverage   68.27%   67.97%   -0.31%     
==========================================
  Files         241      244       +3     
  Lines       35873    37435    +1562     
==========================================
+ Hits        24493    25447     +954     
- Misses       9215     9715     +500     
- Partials     2165     2273     +108     

see 10 files with indirect coverage changes

codecov[bot] avatar May 16 '24 10:05 codecov[bot]

/retest-required

Remaining retests: 0 against base HEAD fdf233a7439008dec8ee9215f7da05b794d7ea82 and 2 for PR HEAD c7271a4da5fc36461d93170e8c67ffaf1ba50916 in total

openshift-ci-robot avatar May 16 '24 10:05 openshift-ci-robot

/retest

danmanor avatar May 21 '24 09:05 danmanor

/retest

danmanor avatar May 22 '24 06:05 danmanor

/retest

danmanor avatar May 22 '24 08:05 danmanor

/retest

danmanor avatar May 23 '24 07:05 danmanor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 23 '24 08:05 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, gamli75

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [danmanor,gamli75]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 23 '24 09:05 openshift-ci[bot]