assisted-service icon indicating copy to clipboard operation
assisted-service copied to clipboard

[release-ocm-2.10] OCPBUGS-33227: Use openshift-install binary for releases >= 4.16

Open openshift-cherrypick-robot opened this issue 1 year ago • 6 comments

This is an automated cherry-pick of #6304

/assign gamli75

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-33227 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh: /jira refresh

In response to this:

This is an automated cherry-pick of #6304

/assign gamli75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 15 '24 19:05 openshift-ci-robot

@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-33227, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-33227 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-33227 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh: /jira refresh

In response to this:

This is an automated cherry-pick of #6304

/assign gamli75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 15 '24 19:05 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 15 '24 19:05 openshift-ci[bot]

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 68.32%. Comparing base (fb84e51) to head (a416aec). Report is 2 commits behind head on release-ocm-2.10.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-ocm-2.10    #6319   +/-   ##
=================================================
  Coverage             68.32%   68.32%           
=================================================
  Files                   237      237           
  Lines                 35153    35163   +10     
=================================================
+ Hits                  24018    24026    +8     
- Misses                 9059     9060    +1     
- Partials               2076     2077    +1     
Files Coverage Δ
internal/ignition/ignition.go 60.57% <0.00%> (ø)
internal/installercache/installercache.go 68.75% <60.00%> (-1.77%) :arrow_down:
internal/oc/release.go 71.14% <75.00%> (+0.12%) :arrow_up:

... and 1 file with indirect coverage changes

codecov[bot] avatar May 15 '24 19:05 codecov[bot]

/retest-required

gamli75 avatar May 16 '24 06:05 gamli75

/retest-required

gamli75 avatar May 22 '24 09:05 gamli75

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-34209, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-34209 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #6304

/assign gamli75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 22 '24 13:05 openshift-ci-robot

/jira refresh

carbonin avatar May 22 '24 13:05 carbonin

@carbonin: This pull request references Jira Issue OCPBUGS-34209, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-34209 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 22 '24 13:05 openshift-ci-robot

/jira refresh

carbonin avatar May 22 '24 13:05 carbonin

@carbonin: This pull request references Jira Issue OCPBUGS-34209, which is invalid:

  • expected dependent Jira Issue OCPBUGS-33227 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 22 '24 13:05 openshift-ci-robot

/jira refresh

carbonin avatar May 22 '24 17:05 carbonin

@carbonin: This pull request references Jira Issue OCPBUGS-34209, which is valid. The bug has been moved to the POST state.

5 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-33227 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 22 '24 17:05 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 8843c72ec8881ce9e399222b9db0de913edf8280 and 2 for PR HEAD a416aecab894e4e004e1041d914b248d3e782c2b in total

openshift-ci-robot avatar May 22 '24 19:05 openshift-ci-robot

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 22 '24 20:05 openshift-ci[bot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-34209: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34209 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #6304

/assign gamli75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 22 '24 20:05 openshift-ci-robot