assisted-service icon indicating copy to clipboard operation
assisted-service copied to clipboard
verified publisher icon openshift

MGMT-17823: Cleanup the install manifest generator

Open carbonin opened this issue 1 year ago • 6 comments

Remove unused parameters or configs in the install manifest generator.

This PR does the following:

  • Remove Operators API, auth handler, service base URL from the install manifests generator
    • These are all unused
  • Remove Service IPs everywhere
    • This was only ever used for the on-prem ISO which was never released as a product and was eventually removed.
  • Move release image mirror info and ABI tls cert override env var parsing into the generator package rather than being set in main and passed in

Each commit is self-contained, so I'd suggest reviewing them one by one.

List all the issues related to this PR

  • [ ] New Feature
  • [x] Enhancement
  • [ ] Bug fix
  • [ ] Tests
  • [ ] Documentation
  • [ ] CI/CD

What environments does this code impact?

  • [ ] Automation (CI, tools, etc)
  • [x] Cloud
  • [x] Operator Managed Deployments
  • [ ] None

How was this code tested?

Pure refactoring so no manual tests

  • [ ] assisted-test-infra environment
  • [ ] dev-scripts environment
  • [ ] Reviewer's test appreciated
  • [x] Waiting for CI to do a full test run
  • [ ] Manual (Elaborate on how it was tested)
  • [x] No tests needed

Checklist

  • [x] Title and description added to both, commit and PR.
  • [x] Relevant issues have been associated (see [CONTRIBUTING] guide)
  • [x] This change does not require a documentation update (docstring, docs, README, etc)
  • [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

carbonin avatar May 14 '24 20:05 carbonin

@carbonin: This pull request references MGMT-17823 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Remove unused parameters or configs in the install manifest generator.

This PR does the following:

  • Remove Operators API, auth handler, service base URL from the install manifests generator
  • These are all unused
  • Remove Service IPs everywhere
  • This was only ever used for the on-prem ISO which was never released as a product and was eventually removed.
  • Move release image mirror info and ABI tls cert override env var parsing into the generator package rather than being set in main and passed in

List all the issues related to this PR

  • [ ] New Feature
  • [x] Enhancement
  • [ ] Bug fix
  • [ ] Tests
  • [ ] Documentation
  • [ ] CI/CD

What environments does this code impact?

  • [ ] Automation (CI, tools, etc)
  • [x] Cloud
  • [x] Operator Managed Deployments
  • [ ] None

How was this code tested?

Pure refactoring so no manual tests

  • [ ] assisted-test-infra environment
  • [ ] dev-scripts environment
  • [ ] Reviewer's test appreciated
  • [x] Waiting for CI to do a full test run
  • [ ] Manual (Elaborate on how it was tested)
  • [x] No tests needed

Checklist

  • [x] Title and description added to both, commit and PR.
  • [x] Relevant issues have been associated (see [CONTRIBUTING] guide)
  • [x] This change does not require a documentation update (docstring, docs, README, etc)
  • [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 14 '24 20:05 openshift-ci-robot

@carbonin: This pull request references MGMT-17823 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Remove unused parameters or configs in the install manifest generator.

This PR does the following:

  • Remove Operators API, auth handler, service base URL from the install manifests generator
  • These are all unused
  • Remove Service IPs everywhere
  • This was only ever used for the on-prem ISO which was never released as a product and was eventually removed.
  • Move release image mirror info and ABI tls cert override env var parsing into the generator package rather than being set in main and passed in

Each commit is self-contained, so I'd suggest reviewing them one by one.

List all the issues related to this PR

  • [ ] New Feature
  • [x] Enhancement
  • [ ] Bug fix
  • [ ] Tests
  • [ ] Documentation
  • [ ] CI/CD

What environments does this code impact?

  • [ ] Automation (CI, tools, etc)
  • [x] Cloud
  • [x] Operator Managed Deployments
  • [ ] None

How was this code tested?

Pure refactoring so no manual tests

  • [ ] assisted-test-infra environment
  • [ ] dev-scripts environment
  • [ ] Reviewer's test appreciated
  • [x] Waiting for CI to do a full test run
  • [ ] Manual (Elaborate on how it was tested)
  • [x] No tests needed

Checklist

  • [x] Title and description added to both, commit and PR.
  • [x] Relevant issues have been associated (see [CONTRIBUTING] guide)
  • [x] This change does not require a documentation update (docstring, docs, README, etc)
  • [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 14 '24 20:05 openshift-ci-robot

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 68.27%. Comparing base (904ee71) to head (ebc4b3f). Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6316      +/-   ##
==========================================
- Coverage   68.29%   68.27%   -0.02%     
==========================================
  Files         241      241              
  Lines       35863    35837      -26     
==========================================
- Hits        24491    24467      -24     
  Misses       9212     9212              
+ Partials     2160     2158       -2
Files Coverage Δ
internal/bminventory/inventory.go 71.29% <ø> (ø)
internal/host/hostcommands/install_cmd.go 85.16% <ø> (+0.71%) :arrow_up:
internal/host/hostcommands/instruction_manager.go 96.10% <ø> (ø)
internal/ignition/ignition.go 59.83% <0.00%> (-0.74%) :arrow_down:
internal/ignition/dummy.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

codecov[bot] avatar May 14 '24 20:05 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, CrystalChun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [CrystalChun,carbonin]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 15 '24 16:05 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD fdf233a7439008dec8ee9215f7da05b794d7ea82 and 2 for PR HEAD ebc4b3fe50f7aa59c4d856e7a39e7e565d17ae43 in total

openshift-ci-robot avatar May 15 '24 17:05 openshift-ci-robot

@carbonin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-e2e-metal-assisted ebc4b3fe50f7aa59c4d856e7a39e7e565d17ae43 link true /test edge-e2e-metal-assisted
ci/prow/e2e-agent-compact-ipv4 ebc4b3fe50f7aa59c4d856e7a39e7e565d17ae43 link true /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 15 '24 19:05 openshift-ci[bot]

I'm going to close this and rebase onto https://github.com/openshift/assisted-service/pull/6283 since they conflict so heavily.

carbonin avatar May 17 '24 12:05 carbonin