MGMT-17811: Do not create local cluster namespace

[paul-maidment]

The code in master to create the local cluster namespace is not working due to a copy/paste error (it's really creating a clusterImageSet) While looking into this, I considered that the local-cluster namespace does not need to be managed or updated by us as it is owned by ACM. So I am removing the code to create/update a namespace in production code.

In tests, we will create a local-cluster namespace for the purpose of testing.

List all the issues related to this PR

• [ ] New Feature
• [ ] Enhancement
• [x] Bug fix
• [ ] Tests
• [ ] Documentation
• [ ] CI/CD

What environments does this code impact?

• [x] Automation (CI, tools, etc)
• [x] Cloud
• [x] Operator Managed Deployments
• [x] None

How was this code tested?

• [ ] assisted-test-infra environment
• [x] dev-scripts environment
• [ ] Reviewer's test appreciated
• [x] Waiting for CI to do a full test run
• [ ] Manual (Elaborate on how it was tested)
• [x] No tests needed

Checklist

• [x] Title and description added to both, commit and PR.
• [x] Relevant issues have been associated (see CONTRIBUTING guide)
• [x] This change does not require a documentation update (docstring, docs, README, etc)
• [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@paul-maidment: This pull request references MGMT-17811 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

This is due to an error in the namespace creation code. Additionally I considered that we do not need to create the local cluster namespace as ACM owns this.

So I have removed the namespace creation code.

List all the issues related to this PR

• [ ] New Feature
• [ ] Enhancement
• [x] Bug fix
• [ ] Tests
• [ ] Documentation
• [ ] CI/CD

What environments does this code impact?

• [x] Automation (CI, tools, etc)
• [x] Cloud
• [x] Operator Managed Deployments
• [x] None

How was this code tested?

• [ ] assisted-test-infra environment
• [x] dev-scripts environment
• [ ] Reviewer's test appreciated
• [x] Waiting for CI to do a full test run
• [ ] Manual (Elaborate on how it was tested)
• [x] No tests needed

Checklist

• [x] Title and description added to both, commit and PR.
• [x] Relevant issues have been associated (see CONTRIBUTING guide)
• [x] This change does not require a documentation update (docstring, docs, README, etc)
• [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@paul-maidment: This pull request references MGMT-17811 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

The code in master to create the local cluster namespace is not working due to a copy/paste error (it's really creating a clusterImageSet) While looking into this, I considered that the local-cluster namespace does not need to be managed or updated by us as it is owned by ACM. So I am removing the code to create/update a namespace in production code.

In tests, we will create a local-cluster namespace for the purpose of testing.

List all the issues related to this PR

• [ ] New Feature
• [ ] Enhancement
• [x] Bug fix
• [ ] Tests
• [ ] Documentation
• [ ] CI/CD

What environments does this code impact?

• [x] Automation (CI, tools, etc)
• [x] Cloud
• [x] Operator Managed Deployments
• [x] None

How was this code tested?

• [ ] assisted-test-infra environment
• [x] dev-scripts environment
• [ ] Reviewer's test appreciated
• [x] Waiting for CI to do a full test run
• [ ] Manual (Elaborate on how it was tested)
• [x] No tests needed

Checklist

• [x] Title and description added to both, commit and PR.
• [x] Relevant issues have been associated (see CONTRIBUTING guide)
• [x] This change does not require a documentation update (docstring, docs, README, etc)
• [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.34%. Comparing base (904ee71) to head (07847ba). Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6314      +/-   ##
==========================================
+ Coverage   68.29%   68.34%   +0.05%     
==========================================
  Files         241      242       +1     
  Lines       35863    36643     +780     
==========================================
+ Hits        24491    25042     +551     
- Misses       9212     9418     +206     
- Partials     2160     2183      +23     

Files	Coverage Δ
...ler/controllers/local_cluster_import_controller.go	60.43% <60.00%> (-0.46%)	:arrow_down:

... and 8 files with indirect coverage changes

[paul-maidment]

/cc @carbonin

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, paul-maidment

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [carbonin,paul-maidment]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 904ee715faa05ede09fad39718fc64ece60a18d0 and 2 for PR HEAD 07847bac51d37266c60ead224b5c9fe96e7e1c74 in total

[paul-maidment]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD fdf233a7439008dec8ee9215f7da05b794d7ea82 and 1 for PR HEAD 07847bac51d37266c60ead224b5c9fe96e7e1c74 in total

[paul-maidment]

/retest

[paul-maidment]

/retest

[paul-maidment]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD fad8782951cad6b8c0424c58be4012df4f2bee1f and 0 for PR HEAD 07847bac51d37266c60ead224b5c9fe96e7e1c74 in total

[openshift-ci-robot]

/hold

Revision 07847bac51d37266c60ead224b5c9fe96e7e1c74 was retested 3 times: holding

[gamli75]

/test e2e-agent-compact-ipv4

[gamli75]

/unhold

[openshift-ci[bot]]

@paul-maidment: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[paul-maidment]

/retest

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.17.0-202405230209.p0.g201d9f2.assembly.stream.el9 for distgit ose-agent-installer-api-server. All builds following this will include this PR.