Remove provisioning paused annotation

[carbonin]

This was added to avoid a race between the provisioning stack running on the bootstrap control plane and the real one running in the installed cluster. During IPI this annotation is removed when bootstrap is finished, but for assisted and agent installs it was never getting removed.

This was causing baremetal operator to never start in the installed cluster which prevented the machine API from recognizing that all machines were running. This, in turn, resulted in the cluster never being able to finish finalizing with the machine API operator reporting an degraded condition like:

- lastTransitionTime: "2024-05-09T22:11:21Z"
  message: 'Failed when progressing towards operator: 4.16.0-0.nightly-2024-05-08-222442
    because minimum worker replica count (2) not yet met: current running replicas
    0, waiting for [test-infra-cluster-96-64zpj-worker-0-59bzh test-infra-cluster-96-64zpj-worker-0-cktvz]'
  reason: SyncingFailed
  status: "True"
  type: Degraded

List all the issues related to this PR

Caused by https://issues.redhat.com/browse/OCPBUGS-33157 Related to https://issues.redhat.com/browse/OCPBUGS-33493

• [ ] New Feature
• [ ] Enhancement
• [x] Bug fix
• [ ] Tests
• [ ] Documentation
• [ ] CI/CD

What environments does this code impact?

• [ ] Automation (CI, tools, etc)
• [x] Cloud
• [x] Operator Managed Deployments
• [ ] None

How was this code tested?

• [ ] assisted-test-infra environment
• [ ] dev-scripts environment
• [ ] Reviewer's test appreciated
• [x] Waiting for CI to do a full test run
• [ ] Manual (Elaborate on how it was tested)
• [ ] No tests needed

Checklist

• [x] Title and description added to both, commit and PR.
• [x] Relevant issues have been associated (see [CONTRIBUTING] guide)
• [x] This change does not require a documentation update (docstring, docs, README, etc)
• [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [carbonin]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 60.52632% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 68.28%. Comparing base (904ee71) to head (5e534e3).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6306      +/-   ##
==========================================
- Coverage   68.29%   68.28%   -0.01%     
==========================================
  Files         241      241              
  Lines       35863    35878      +15     
==========================================
+ Hits        24491    24499       +8     
- Misses       9212     9215       +3     
- Partials     2160     2164       +4     

Files	Coverage Δ
internal/ignition/ignition.go	60.30% <60.52%> (-0.28%)	:arrow_down:

... and 1 file with indirect coverage changes

[openshift-ci[bot]]

@carbonin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[carbonin]

Closing this as the issue was fixed in the most recent 4.16 payloads