MGMT-17770: Split ignition handling file

[carbonin]

This PR splits the mostly unrelated logic in ignition/ignition.go into three files.

• ignition/discovery.go: discovery ignition builder and helpers
• ignition/installmanifests.go: runs installer binary to create host ignition files and cluster manifests
• ignition/ignition.go: ignition parsing and a single common helper function

List all the issues related to this PR

https://issues.redhat.com/browse/MGMT-17770

• [ ] New Feature
• [x] Enhancement
• [ ] Bug fix
• [ ] Tests
• [ ] Documentation
• [ ] CI/CD

What environments does this code impact?

• [ ] Automation (CI, tools, etc)
• [ ] Cloud
• [ ] Operator Managed Deployments
• [x] None

How was this code tested?

It's a refactoring so unit tests and CI tests passing should be sufficient

• [ ] assisted-test-infra environment
• [ ] dev-scripts environment
• [ ] Reviewer's test appreciated
• [x] Waiting for CI to do a full test run
• [ ] Manual (Elaborate on how it was tested)
• [ ] No tests needed

Checklist

• [x] Title and description added to both, commit and PR.
• [x] Relevant issues have been associated (see [CONTRIBUTING] guide)
• [x] This change does not require a documentation update (docstring, docs, README, etc)
• [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@carbonin: This pull request references MGMT-17770 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

This PR splits the mostly unrelated logic in ignition/ignition.go into three files.

• ignition/discovery.go: discovery ignition builder and helpers
• ignition/installmanifests.go: runs installer binary to create host ignition files and cluster manifests
• ignition/ignition.go: ignition parsing and a single common helper function

List all the issues related to this PR

https://issues.redhat.com/browse/MGMT-17770

• [ ] New Feature
• [x] Enhancement
• [ ] Bug fix
• [ ] Tests
• [ ] Documentation
• [ ] CI/CD

What environments does this code impact?

• [ ] Automation (CI, tools, etc)
• [ ] Cloud
• [ ] Operator Managed Deployments
• [x] None

How was this code tested?

It's a refactoring so unit tests and CI tests passing should be sufficient

• [ ] assisted-test-infra environment
• [ ] dev-scripts environment
• [ ] Reviewer's test appreciated
• [x] Waiting for CI to do a full test run
• [ ] Manual (Elaborate on how it was tested)
• [ ] No tests needed

Checklist

• [x] Title and description added to both, commit and PR.
• [x] Relevant issues have been associated (see [CONTRIBUTING] guide)
• [x] This change does not require a documentation update (docstring, docs, README, etc)
• [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 60.52142% with 424 lines in your changes are missing coverage. Please review.

Project coverage is 68.37%. Comparing base (cb69eb2) to head (859bb96). Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6283      +/-   ##
==========================================
+ Coverage   68.25%   68.37%   +0.11%     
==========================================
  Files         242      244       +2     
  Lines       35902    35996      +94     
==========================================
+ Hits        24506    24611     +105     
+ Misses       9229     9218      -11     
  Partials     2167     2167              

Files	Coverage Δ
internal/ignition/ignition.go	78.94% <94.59%> (+18.59%)	:arrow_up:
internal/ignition/discovery.go	72.24% <72.24%> (ø)
internal/ignition/installmanifests.go	55.67% <55.67%> (ø)

... and 3 files with indirect coverage changes

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 904ee715faa05ede09fad39718fc64ece60a18d0 and 2 for PR HEAD d6519d5dbd575ff641621188e93f6ded34c04753 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD fdf233a7439008dec8ee9215f7da05b794d7ea82 and 1 for PR HEAD d6519d5dbd575ff641621188e93f6ded34c04753 in total

[gamli75]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD fdf233a7439008dec8ee9215f7da05b794d7ea82 and 2 for PR HEAD cc4ecc5d385537cc0f4ba29f70ae121a2fbe1af1 in total

[carbonin]

/retest-required

[gamli75]

/test edge-e2e-metal-assisted

[carbonin]

/test e2e-agent-compact-ipv4

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD fad8782951cad6b8c0424c58be4012df4f2bee1f and 1 for PR HEAD cc4ecc5d385537cc0f4ba29f70ae121a2fbe1af1 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cb69eb21615f860640318aa6cda98acd1b98f80b and 0 for PR HEAD cc4ecc5d385537cc0f4ba29f70ae121a2fbe1af1 in total

[gamli75]

/test edge-subsystem-kubeapi-aws

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, gamli75

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [carbonin,gamli75]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci[bot]]

@carbonin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.