OCPBUGS-33243: Invalid Pull-Secret when using password which contains a colon character

[pastequo]

Fix the validation rule while parsing pull secret. Fix some typos in test file.

An unit test had been updated to test a problematic input

Will be tested next week

Should be backported in openshift 4.15 (https://issues.redhat.com/browse/OCPBUGS-31727)

List all the issues related to this PR

• [ ] New Feature
• [ ] Enhancement
• [x] Bug fix
• [ ] Tests
• [ ] Documentation
• [ ] CI/CD

What environments does this code impact?

• [ ] Automation (CI, tools, etc)
• [x] Cloud
• [x] Operator Managed Deployments
• [ ] None

I guess

How was this code tested?

• [ ] assisted-test-infra environment
• [ ] dev-scripts environment
• [ ] Reviewer's test appreciated
• [x] Waiting for CI to do a full test run
• [x] Manual (Elaborate on how it was tested)
• [ ] No tests needed

Will see next week how to setup a staging/integration environment to see if I can reproduce w/o the fix & stop reproducing with the fix.

Checklist

• [x] Title and description added to both, commit and PR.
• [x] Relevant issues have been associated (see CONTRIBUTING guide)
• [x] This change does not require a documentation update (docstring, docs, README, etc)
• [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci[bot]]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

[openshift-ci-robot]

@pastequo: This pull request references Jira Issue OCPBUGS-33243, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fix the validation rule while parsing pull secret. Fix some typos in test file.

An unit test had been updated to test a problematic input

Will be tested next week

Should be backported in openshift 4.15 (https://issues.redhat.com/browse/OCPBUGS-31727)

List all the issues related to this PR

• [ ] New Feature
• [ ] Enhancement
• [x] Bug fix
• [ ] Tests
• [ ] Documentation
• [ ] CI/CD

What environments does this code impact?

• [ ] Automation (CI, tools, etc)
• [x] Cloud
• [x] Operator Managed Deployments
• [ ] None

I guess

How was this code tested?

• [ ] assisted-test-infra environment
• [ ] dev-scripts environment
• [ ] Reviewer's test appreciated
• [x] Waiting for CI to do a full test run
• [x] Manual (Elaborate on how it was tested)
• [ ] No tests needed

Will see next week how to setup a staging/integration environment to see if I can reproduce w/o the fix & stop reproducing with the fix.

Checklist

• [x] Title and description added to both, commit and PR.
• [x] Relevant issues have been associated (see CONTRIBUTING guide)
• [x] This change does not require a documentation update (docstring, docs, README, etc)
• [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pastequo Once this PR has been reviewed and has the lgtm label, please assign eranco74 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[pastequo]

/jira refresh

[openshift-ci-robot]

@pastequo: This pull request references Jira Issue OCPBUGS-33243, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pastequo]

/jira refresh

[openshift-ci-robot]

@pastequo: This pull request references Jira Issue OCPBUGS-33243, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.16%. Comparing base (fdf233a) to head (9961cf5). Report is 9 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6258      +/-   ##
==========================================
- Coverage   68.27%   68.16%   -0.11%     
==========================================
  Files         241      244       +3     
  Lines       35873    37903    +2030     
==========================================
+ Hits        24493    25838    +1345     
- Misses       9215     9770     +555     
- Partials     2165     2295     +130     

Files	Coverage Δ
...rnal/cluster/validations/pull_secret_validation.go	77.47% <100.00%> (+4.50%)	:arrow_up:

... and 10 files with indirect coverage changes

[openshift-ci-robot]

@pastequo: This pull request references Jira Issue OCPBUGS-31727, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fix the validation rule while parsing pull secret. Fix some typos in test file.

An unit test had been updated to test a problematic input

Will be tested next week

Should be backported in openshift 4.15 (https://issues.redhat.com/browse/OCPBUGS-31727)

List all the issues related to this PR

• [ ] New Feature
• [ ] Enhancement
• [x] Bug fix
• [ ] Tests
• [ ] Documentation
• [ ] CI/CD

What environments does this code impact?

• [ ] Automation (CI, tools, etc)
• [x] Cloud
• [x] Operator Managed Deployments
• [ ] None

I guess

How was this code tested?

• [ ] assisted-test-infra environment
• [ ] dev-scripts environment
• [ ] Reviewer's test appreciated
• [x] Waiting for CI to do a full test run
• [x] Manual (Elaborate on how it was tested)
• [ ] No tests needed

Will see next week how to setup a staging/integration environment to see if I can reproduce w/o the fix & stop reproducing with the fix.

Checklist

• [x] Title and description added to both, commit and PR.
• [x] Relevant issues have been associated (see CONTRIBUTING guide)
• [x] This change does not require a documentation update (docstring, docs, README, etc)
• [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pastequo]

/jira refresh

[openshift-ci-robot]

@pastequo: This pull request references Jira Issue OCPBUGS-31727, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pastequo]

/retest

[rccrdpccl]

/retest

[gamli75]

/test e2e-agent-compact-ipv4

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, pastequo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [adriengentil]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[pastequo]

/cherry-pick release-4.16 release-4.15

[openshift-cherrypick-robot]

@pastequo: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16 release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci[bot]]

@pastequo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@pastequo: Jira Issue OCPBUGS-31727: All pull requests linked via external trackers have merged:

• openshift/assisted-service#6258

Jira Issue OCPBUGS-31727 has been moved to the MODIFIED state.

In response to this:

Fix the validation rule while parsing pull secret. Fix some typos in test file.

An unit test had been updated to test a problematic input

Will be tested next week

Should be backported in openshift 4.15 & 4.16

List all the issues related to this PR

• [ ] New Feature
• [ ] Enhancement
• [x] Bug fix
• [ ] Tests
• [ ] Documentation
• [ ] CI/CD

What environments does this code impact?

• [ ] Automation (CI, tools, etc)
• [x] Cloud
• [x] Operator Managed Deployments
• [ ] None

I guess

How was this code tested?

• [ ] assisted-test-infra environment
• [ ] dev-scripts environment
• [ ] Reviewer's test appreciated
• [x] Waiting for CI to do a full test run
• [x] Manual (Elaborate on how it was tested)
• [ ] No tests needed

Started locally assisted-service with podman. Issue was reproduced & fixed with the changes.

However I didn't check if the installation could go until the end with a password containing a ':' Seems to be a legit char tho.

Checklist

• [x] Title and description added to both, commit and PR.
• [x] Relevant issues have been associated (see CONTRIBUTING guide)
• [x] This change does not require a documentation update (docstring, docs, README, etc)
• [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@pastequo: new pull request created: #6362

In response to this:

/cherry-pick release-4.16 release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.