assisted-service icon indicating copy to clipboard operation
assisted-service copied to clipboard

[release-ocm-2.9] NO-ISSUE: Change bare metal host CRD name to a non-uuid format

Open openshift-cherrypick-robot opened this issue 10 months ago • 3 comments

This is an automated cherry-pick of #5972

/assign danmanor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot Once this PR has been reviewed and has the lgtm label, please assign oourfali for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 25 '24 09:04 openshift-ci[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.19%. Comparing base (8e82858) to head (2bf59dd). Report is 15 commits behind head on release-ocm-2.9.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-ocm-2.9    #6240      +/-   ##
===================================================
+ Coverage            67.70%   68.19%   +0.49%     
===================================================
  Files                  232      232              
  Lines                34118    34991     +873     
===================================================
+ Hits                 23099    23862     +763     
- Misses                8974     9010      +36     
- Partials              2045     2119      +74     

see 2 files with indirect coverage changes

codecov[bot] avatar Apr 25 '24 10:04 codecov[bot]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 25 '24 12:04 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jul 25 '24 01:07 openshift-bot

/uncc @romfreiman @gamli75

danmanor avatar Jul 25 '24 07:07 danmanor

/cc @adriengentil @eifrach

danmanor avatar Jul 25 '24 07:07 danmanor

/lgtm

eifrach avatar Jul 25 '24 10:07 eifrach

/jira refresh

danmanor avatar Jul 25 '24 10:07 danmanor

@danmanor: This pull request explicitly references no jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 25 '24 10:07 openshift-ci-robot

/approve

danmanor avatar Jul 25 '24 10:07 danmanor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 25 '24 10:07 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 25 '24 10:07 openshift-ci[bot]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 25 '24 12:07 openshift-ci[bot]