assisted-service
assisted-service copied to clipboard
MGMT-15736: Align feature support level to support HighAvailabilityMode
- Add parameter to api/assisted-install/v2/support-levels/features API so that the features could be filtered also by high_availability
example
Request: High Availability = None
> curl -s \
'http://localhost:6000/api/assisted-install/v2/support-levels/features?
openshift_version=4.15&high_availability_mode=None&cpu_architecture=x86_64' | jq .
Response
{
"features": {
"BAREMETAL_PLATFORM": "supported",
"CLUSTER_MANAGED_NETWORKING": "unavailable",
"CNV": "supported",
"CUSTOM_MANIFEST": "supported",
"DUAL_STACK": "supported",
"DUAL_STACK_VIPS": "supported",
"EXTERNAL_PLATFORM": "supported",
"EXTERNAL_PLATFORM_OCI": "tech-preview",
"FULL_ISO": "supported",
"LSO": "supported",
"LVM": "supported",
"MCE": "supported",
"MINIMAL_ISO": "supported",
"NONE_PLATFORM": "supported",
"NUTANIX_INTEGRATION": "unavailable",
"ODF": "unavailable",
"OVN_NETWORK_TYPE": "supported",
"SDN_NETWORK_TYPE": "unavailable",
"SINGLE_NODE_EXPANSION": "supported",
"SKIP_MCO_REBOOT": "supported",
"SNO": "supported",
"USER_MANAGED_NETWORKING": "supported",
"VIP_AUTO_ALLOC": "unavailable",
"VSPHERE_INTEGRATION": "unavailable"
}
}
Request: High Availability = Full
> curl -s \
'http://localhost:6000/api/assisted-install/v2/support-levels/features?
openshift_version=4.15&high_availability_mode=Full&cpu_architecture=x86_64' | jq .
Response:
{
"features": {
"BAREMETAL_PLATFORM": "supported",
"CLUSTER_MANAGED_NETWORKING": "supported",
"CNV": "supported",
"CUSTOM_MANIFEST": "supported",
"DUAL_STACK": "supported",
"DUAL_STACK_VIPS": "supported",
"EXTERNAL_PLATFORM": "supported",
"EXTERNAL_PLATFORM_OCI": "tech-preview",
"FULL_ISO": "supported",
"LSO": "supported",
"LVM": "supported",
"MCE": "supported",
"MINIMAL_ISO": "supported",
"NONE_PLATFORM": "supported",
"NUTANIX_INTEGRATION": "supported",
"ODF": "supported",
"OVN_NETWORK_TYPE": "supported",
"SDN_NETWORK_TYPE": "unavailable",
"SINGLE_NODE_EXPANSION": "supported",
"SKIP_MCO_REBOOT": "supported",
"SNO": "supported",
"USER_MANAGED_NETWORKING": "supported",
"VIP_AUTO_ALLOC": "unavailable",
"VSPHERE_INTEGRATION": "supported"
}
}
List all the issues related to this PR
- [x] New Feature
- [ ] Enhancement
- [ ] Bug fix
- [x] Tests
- [ ] Documentation
- [ ] CI/CD
What environments does this code impact?
- [ ] Automation (CI, tools, etc)
- [ ] Cloud
- [ ] Operator Managed Deployments
- [x] None
How was this code tested?
- [x] assisted-test-infra environment
- [ ] dev-scripts environment
- [ ] Reviewer's test appreciated
- [ ] Waiting for CI to do a full test run
- [x] Manual (Elaborate on how it was tested)
- [x] No tests needed
Checklist
- [ ] Title and description added to both, commit and PR.
- [ ] Relevant issues have been associated (see CONTRIBUTING guide)
- [ ] This change does not require a documentation update (docstring,
docs
, README, etc) - [ ] Does this change include unit-tests (note that code changes require unit-tests)
Reviewers Checklist
- Are the title and description (in both PR and commit) meaningful and clear?
- Is there a bug required (and linked) for this change?
- Should this PR be backported?
@eifrach: This pull request references MGMT-15736 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.
In response to this:
WIP
example
Request:
> curl -s \ 'http://localhost:6000/api/assisted-install/v2/support-levels/features?openshift_version=4.15&high_availability_mode=None&cpu_architecture=x86_64' | jq .
Response
{ "features": { "BAREMETAL_PLATFORM": "supported", "CLUSTER_MANAGED_NETWORKING": "unavailable", "CNV": "supported", "CUSTOM_MANIFEST": "supported", "DUAL_STACK": "supported", "DUAL_STACK_VIPS": "supported", "EXTERNAL_PLATFORM": "supported", "EXTERNAL_PLATFORM_OCI": "tech-preview", "FULL_ISO": "supported", "LSO": "supported", "LVM": "supported", "MCE": "supported", "MINIMAL_ISO": "supported", "NONE_PLATFORM": "supported", "NUTANIX_INTEGRATION": "unavailable", "ODF": "unavailable", "OVN_NETWORK_TYPE": "supported", "SDN_NETWORK_TYPE": "unavailable", "SINGLE_NODE_EXPANSION": "supported", "SKIP_MCO_REBOOT": "supported", "SNO": "supported", "USER_MANAGED_NETWORKING": "supported", "VIP_AUTO_ALLOC": "unavailable", "VSPHERE_INTEGRATION": "unavailable" } }
List all the issues related to this PR
- [ ] New Feature
- [ ] Enhancement
- [ ] Bug fix
- [ ] Tests
- [ ] Documentation
- [ ] CI/CD
What environments does this code impact?
- [ ] Automation (CI, tools, etc)
- [ ] Cloud
- [ ] Operator Managed Deployments
- [x] None
How was this code tested?
- [ ] assisted-test-infra environment
- [ ] dev-scripts environment
- [ ] Reviewer's test appreciated
- [ ] Waiting for CI to do a full test run
- [ ] Manual (Elaborate on how it was tested)
- [x] No tests needed
Checklist
- [ ] Title and description added to both, commit and PR.
- [ ] Relevant issues have been associated (see CONTRIBUTING guide)
- [ ] This change does not require a documentation update (docstring,
docs
, README, etc)- [ ] Does this change include unit-tests (note that code changes require unit-tests)
Reviewers Checklist
- Are the title and description (in both PR and commit) meaningful and clear?
- Is there a bug required (and linked) for this change?
- Should this PR be backported?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: eifrach
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [eifrach]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@eifrach: This pull request references MGMT-15736 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.
In response to this:
WIP
example
Request:
> curl -s \ 'http://localhost:6000/api/assisted-install/v2/support-levels/features?openshift_version=4.15&high_availability_mode=None&cpu_architecture=x86_64' | jq .
Response
{ "features": { "BAREMETAL_PLATFORM": "supported", "CLUSTER_MANAGED_NETWORKING": "unavailable", "CNV": "supported", "CUSTOM_MANIFEST": "supported", "DUAL_STACK": "supported", "DUAL_STACK_VIPS": "supported", "EXTERNAL_PLATFORM": "supported", "EXTERNAL_PLATFORM_OCI": "tech-preview", "FULL_ISO": "supported", "LSO": "supported", "LVM": "supported", "MCE": "supported", "MINIMAL_ISO": "supported", "NONE_PLATFORM": "supported", "NUTANIX_INTEGRATION": "unavailable", "ODF": "unavailable", "OVN_NETWORK_TYPE": "supported", "SDN_NETWORK_TYPE": "unavailable", "SINGLE_NODE_EXPANSION": "supported", "SKIP_MCO_REBOOT": "supported", "SNO": "supported", "USER_MANAGED_NETWORKING": "supported", "VIP_AUTO_ALLOC": "unavailable", "VSPHERE_INTEGRATION": "unavailable" } }
List all the issues related to this PR
- [x] New Feature
- [ ] Enhancement
- [ ] Bug fix
- [x] Tests
- [ ] Documentation
- [ ] CI/CD
What environments does this code impact?
- [ ] Automation (CI, tools, etc)
- [ ] Cloud
- [ ] Operator Managed Deployments
- [x] None
How was this code tested?
- [x] assisted-test-infra environment
- [ ] dev-scripts environment
- [ ] Reviewer's test appreciated
- [ ] Waiting for CI to do a full test run
- [x] Manual (Elaborate on how it was tested)
- [x] No tests needed
Checklist
- [ ] Title and description added to both, commit and PR.
- [ ] Relevant issues have been associated (see CONTRIBUTING guide)
- [ ] This change does not require a documentation update (docstring,
docs
, README, etc)- [ ] Does this change include unit-tests (note that code changes require unit-tests)
Reviewers Checklist
- Are the title and description (in both PR and commit) meaningful and clear?
- Is there a bug required (and linked) for this change?
- Should this PR be backported?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@eifrach: This pull request references MGMT-15736 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.
In response to this:
- Add parameter to api/assisted-install/v2/support-levels/features API so that the features could be filtered also by high_availability
example
Request:
> curl -s \ 'http://localhost:6000/api/assisted-install/v2/support-levels/features?openshift_version=4.15&high_availability_mode=None&cpu_architecture=x86_64' | jq .
Response
{ "features": { "BAREMETAL_PLATFORM": "supported", "CLUSTER_MANAGED_NETWORKING": "unavailable", "CNV": "supported", "CUSTOM_MANIFEST": "supported", "DUAL_STACK": "supported", "DUAL_STACK_VIPS": "supported", "EXTERNAL_PLATFORM": "supported", "EXTERNAL_PLATFORM_OCI": "tech-preview", "FULL_ISO": "supported", "LSO": "supported", "LVM": "supported", "MCE": "supported", "MINIMAL_ISO": "supported", "NONE_PLATFORM": "supported", "NUTANIX_INTEGRATION": "unavailable", "ODF": "unavailable", "OVN_NETWORK_TYPE": "supported", "SDN_NETWORK_TYPE": "unavailable", "SINGLE_NODE_EXPANSION": "supported", "SKIP_MCO_REBOOT": "supported", "SNO": "supported", "USER_MANAGED_NETWORKING": "supported", "VIP_AUTO_ALLOC": "unavailable", "VSPHERE_INTEGRATION": "unavailable" } }
List all the issues related to this PR
- [x] New Feature
- [ ] Enhancement
- [ ] Bug fix
- [x] Tests
- [ ] Documentation
- [ ] CI/CD
What environments does this code impact?
- [ ] Automation (CI, tools, etc)
- [ ] Cloud
- [ ] Operator Managed Deployments
- [x] None
How was this code tested?
- [x] assisted-test-infra environment
- [ ] dev-scripts environment
- [ ] Reviewer's test appreciated
- [ ] Waiting for CI to do a full test run
- [x] Manual (Elaborate on how it was tested)
- [x] No tests needed
Checklist
- [ ] Title and description added to both, commit and PR.
- [ ] Relevant issues have been associated (see CONTRIBUTING guide)
- [ ] This change does not require a documentation update (docstring,
docs
, README, etc)- [ ] Does this change include unit-tests (note that code changes require unit-tests)
Reviewers Checklist
- Are the title and description (in both PR and commit) meaningful and clear?
- Is there a bug required (and linked) for this change?
- Should this PR be backported?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Codecov Report
Attention: Patch coverage is 76.82927%
with 19 lines
in your changes missing coverage. Please review.
Project coverage is 68.31%. Comparing base (
7080d0d
) to head (674fc2c
). Report is 210 commits behind head on master.
:exclamation: Current head 674fc2c differs from pull request most recent head 58657c1
Please upload reports for the commit 58657c1 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #6077 +/- ##
==========================================
+ Coverage 68.22% 68.31% +0.08%
==========================================
Files 242 242
Lines 35884 35861 -23
==========================================
+ Hits 24481 24497 +16
+ Misses 9276 9233 -43
- Partials 2127 2131 +4
Files with missing lines | Coverage Δ | |
---|---|---|
internal/featuresupport/common.go | 90.90% <100.00%> (+0.58%) |
:arrow_up: |
internal/featuresupport/feature_support_level.go | 96.49% <100.00%> (ø) |
|
internal/featuresupport/features_misc.go | 88.66% <100.00%> (-1.27%) |
:arrow_down: |
internal/featuresupport/features_networking.go | 86.00% <100.00%> (+0.60%) |
:arrow_up: |
internal/featuresupport/features_platforms.go | 92.89% <100.00%> (+0.24%) |
:arrow_up: |
internal/host/hostcommands/install_cmd.go | 84.45% <100.00%> (ø) |
|
internal/provider/nutanix/installConfig.go | 0.00% <0.00%> (ø) |
|
internal/provider/vsphere/installConfig.go | 0.00% <0.00%> (ø) |
|
internal/cluster/validations/validations.go | 26.25% <0.00%> (ø) |
|
...ernal/featuresupport/architecture_support_level.go | 91.66% <77.77%> (-8.34%) |
:arrow_down: |
... and 2 more |
/test edge-subsystem-aws /test edge-subsystem-kubeapi-aws /test edge-e2e-nutanix-assisted-4-14
/test edge-subsystem-kubeapi-aws /test edge-subsystem-aws
/test edge-subsystem-kubeapi-aws /test edge-subsystem-aws
/test edge-e2e-vsphere-assisted /test edge-e2e-vsphere-assisted /test edge-subsystem-aws
/test edge-subsystem-aws /test edge-e2e-nutanix-assisted
@eifrach can you add the response of
curl -s \ 'http://localhost:6000/api/assisted-install/v2/support-levels/features?openshift_version=4.15&high_availability_mode=Full&cpu_architecture=x86_64' | jq .
@eifrach: This pull request references MGMT-15736 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.
In response to this:
- Add parameter to api/assisted-install/v2/support-levels/features API so that the features could be filtered also by high_availability
example
Request: High Availability = None
> curl -s \ 'http://localhost:6000/api/assisted-install/v2/support-levels/features? openshift_version=4.15&high_availability_mode=None&cpu_architecture=x86_64' | jq .
Response
{ "features": { "BAREMETAL_PLATFORM": "supported", "CLUSTER_MANAGED_NETWORKING": "unavailable", "CNV": "supported", "CUSTOM_MANIFEST": "supported", "DUAL_STACK": "supported", "DUAL_STACK_VIPS": "supported", "EXTERNAL_PLATFORM": "supported", "EXTERNAL_PLATFORM_OCI": "tech-preview", "FULL_ISO": "supported", "LSO": "supported", "LVM": "supported", "MCE": "supported", "MINIMAL_ISO": "supported", "NONE_PLATFORM": "supported", "NUTANIX_INTEGRATION": "unavailable", "ODF": "unavailable", "OVN_NETWORK_TYPE": "supported", "SDN_NETWORK_TYPE": "unavailable", "SINGLE_NODE_EXPANSION": "supported", "SKIP_MCO_REBOOT": "supported", "SNO": "supported", "USER_MANAGED_NETWORKING": "supported", "VIP_AUTO_ALLOC": "unavailable", "VSPHERE_INTEGRATION": "unavailable" } }
Request: High Availability = Full
> curl -s \ 'http://localhost:6000/api/assisted-install/v2/support-levels/features? openshift_version=4.15&high_availability_mode=Full&cpu_architecture=x86_64' | jq .
Response:
{ "features": { "BAREMETAL_PLATFORM": "supported", "CLUSTER_MANAGED_NETWORKING": "supported", "CNV": "supported", "CUSTOM_MANIFEST": "supported", "DUAL_STACK": "supported", "DUAL_STACK_VIPS": "supported", "EXTERNAL_PLATFORM": "supported", "EXTERNAL_PLATFORM_OCI": "tech-preview", "FULL_ISO": "supported", "LSO": "supported", "LVM": "supported", "MCE": "supported", "MINIMAL_ISO": "supported", "NONE_PLATFORM": "supported", "NUTANIX_INTEGRATION": "supported", "ODF": "supported", "OVN_NETWORK_TYPE": "supported", "SDN_NETWORK_TYPE": "unavailable", "SINGLE_NODE_EXPANSION": "supported", "SKIP_MCO_REBOOT": "supported", "SNO": "supported", "USER_MANAGED_NETWORKING": "supported", "VIP_AUTO_ALLOC": "unavailable", "VSPHERE_INTEGRATION": "supported" } }
List all the issues related to this PR
- [x] New Feature
- [ ] Enhancement
- [ ] Bug fix
- [x] Tests
- [ ] Documentation
- [ ] CI/CD
What environments does this code impact?
- [ ] Automation (CI, tools, etc)
- [ ] Cloud
- [ ] Operator Managed Deployments
- [x] None
How was this code tested?
- [x] assisted-test-infra environment
- [ ] dev-scripts environment
- [ ] Reviewer's test appreciated
- [ ] Waiting for CI to do a full test run
- [x] Manual (Elaborate on how it was tested)
- [x] No tests needed
Checklist
- [ ] Title and description added to both, commit and PR.
- [ ] Relevant issues have been associated (see CONTRIBUTING guide)
- [ ] This change does not require a documentation update (docstring,
docs
, README, etc)- [ ] Does this change include unit-tests (note that code changes require unit-tests)
Reviewers Checklist
- Are the title and description (in both PR and commit) meaningful and clear?
- Is there a bug required (and linked) for this change?
- Should this PR be backported?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@eifrach can you add the response of
curl -s
'http://localhost:6000/api/assisted-install/v2/support-levels/features?openshift_version=4.15&high_availability_mode=Full&cpu_architecture=x86_64' | jq .
done
rebase and retest
/test edge-subsystem-kubeapi-aws /test edge-subsystem-aws /test edge-e2e-metal-assisted /test edge-e2e-metal-assisted-lvm
@eifrach: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/edge-e2e-vsphere-assisted | 674fc2c09e2cfd3b8886495a1d15cd2e8dabf0cb | link | false | /test edge-e2e-vsphere-assisted |
ci/prow/edge-e2e-nutanix-assisted | 674fc2c09e2cfd3b8886495a1d15cd2e8dabf0cb | link | false | /test edge-e2e-nutanix-assisted |
ci/prow/edge-e2e-nutanix-assisted-4-14 | 674fc2c09e2cfd3b8886495a1d15cd2e8dabf0cb | link | false | /test edge-e2e-nutanix-assisted-4-14 |
ci/prow/edge-subsystem-aws | 58657c1687024638da0b5662ca53f2963ea76fe6 | link | true | /test edge-subsystem-aws |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten /remove-lifecycle stale
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen
.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Exclude this issue from closing again by commenting /lifecycle frozen
.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen
. Mark the issue as fresh by commenting/remove-lifecycle rotten
. Exclude this issue from closing again by commenting/lifecycle frozen
./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.