assisted-service
assisted-service copied to clipboard
openshift
NO-ISSUE-remove-docker-support
The aim of this PR is to reduce maintenance effort for this project, fully supporting only podman/podman-remote over docker. It is already removed from skipper, but docker support was left in place, possibly working for non-skipper usage.
We won't do anything explicit to forbid it, but we will focus on podman for our tooling
List all the issues related to this PR
- [ ] New Feature
- [ ] Enhancement
- [ ] Bug fix
- [ ] Tests
- [ ] Documentation
- [ ] CI/CD
What environments does this code impact?
- [ ] Automation (CI, tools, etc)
- [ ] Cloud
- [ ] Operator Managed Deployments
- [x] None
How was this code tested?
- [ ] assisted-test-infra environment
- [ ] dev-scripts environment
- [ ] Reviewer's test appreciated
- [ ] Waiting for CI to do a full test run
- [ ] Manual (Elaborate on how it was tested)
- [x] No tests needed
Checklist
- [ ] Title and description added to both, commit and PR.
- [ ] Relevant issues have been associated (see CONTRIBUTING guide)
- [ ] This change does not require a documentation update (docstring,
docs, README, etc) - [ ] Does this change include unit-tests (note that code changes require unit-tests)
Reviewers Checklist
- Are the title and description (in both PR and commit) meaningful and clear?
- Is there a bug required (and linked) for this change?
- Should this PR be backported?
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rccrdpccl: The following commands are available to trigger required jobs:
-
/test e2e-agent-compact-ipv4 -
/test edge-assisted-operator-catalog-publish-verify -
/test edge-ci-index -
/test edge-e2e-ai-operator-ztp -
/test edge-e2e-ai-operator-ztp-sno-day2-workers -
/test edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding -
/test edge-e2e-metal-assisted -
/test edge-e2e-metal-assisted-4-11 -
/test edge-e2e-metal-assisted-4-12 -
/test edge-e2e-metal-assisted-cnv -
/test edge-e2e-metal-assisted-lvm -
/test edge-e2e-metal-assisted-odf -
/test edge-images -
/test edge-lint -
/test edge-subsystem-aws -
/test edge-subsystem-kubeapi-aws -
/test edge-unit-test -
/test edge-verify-generated-code -
/test images -
/test mce-images
The following commands are available to trigger optional jobs:
-
/test e2e-agent-ha-dualstack -
/test e2e-agent-sno-ipv6 -
/test edge-e2e-ai-operator-ztp-3masters -
/test edge-e2e-ai-operator-ztp-capi -
/test edge-e2e-ai-operator-ztp-compact-day2-masters -
/test edge-e2e-ai-operator-ztp-compact-day2-workers -
/test edge-e2e-ai-operator-ztp-disconnected -
/test edge-e2e-ai-operator-ztp-hypershift-zero-nodes -
/test edge-e2e-ai-operator-ztp-multiarch-3masters-ocp -
/test edge-e2e-ai-operator-ztp-multiarch-sno-ocp -
/test edge-e2e-ai-operator-ztp-node-labels -
/test edge-e2e-ai-operator-ztp-sno-day2-masters -
/test edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride -
/test edge-e2e-metal-assisted-4-13 -
/test edge-e2e-metal-assisted-4-14 -
/test edge-e2e-metal-assisted-4-15 -
/test edge-e2e-metal-assisted-bond -
/test edge-e2e-metal-assisted-day2 -
/test edge-e2e-metal-assisted-day2-arm-workers -
/test edge-e2e-metal-assisted-day2-single-node -
/test edge-e2e-metal-assisted-external -
/test edge-e2e-metal-assisted-external-4-14 -
/test edge-e2e-metal-assisted-ipv4v6 -
/test edge-e2e-metal-assisted-ipv6 -
/test edge-e2e-metal-assisted-kube-api-late-binding-single-node -
/test edge-e2e-metal-assisted-kube-api-late-unbinding-ipv4-single-node -
/test edge-e2e-metal-assisted-kube-api-net-suite -
/test edge-e2e-metal-assisted-mce-4-11 -
/test edge-e2e-metal-assisted-mce-4-12 -
/test edge-e2e-metal-assisted-mce-4-13 -
/test edge-e2e-metal-assisted-mce-4-14 -
/test edge-e2e-metal-assisted-mce-4-15 -
/test edge-e2e-metal-assisted-mce-sno -
/test edge-e2e-metal-assisted-metallb -
/test edge-e2e-metal-assisted-none -
/test edge-e2e-metal-assisted-onprem -
/test edge-e2e-metal-assisted-single-node -
/test edge-e2e-metal-assisted-static-ip-suite -
/test edge-e2e-metal-assisted-tang -
/test edge-e2e-metal-assisted-tpmv2 -
/test edge-e2e-metal-assisted-upgrade-agent -
/test edge-e2e-nutanix-assisted -
/test edge-e2e-nutanix-assisted-2workers -
/test edge-e2e-nutanix-assisted-4-14 -
/test edge-e2e-oci-assisted -
/test edge-e2e-oci-assisted-4-14 -
/test edge-e2e-oci-assisted-external -
/test edge-e2e-oci-assisted-iscsi -
/test edge-e2e-vsphere-assisted -
/test edge-e2e-vsphere-assisted-4-12 -
/test edge-e2e-vsphere-assisted-4-13 -
/test edge-e2e-vsphere-assisted-4-14 -
/test edge-e2e-vsphere-assisted-umn -
/test edge-push-pr-image -
/test push-pr-image
Use /test all to run the following jobs that were automatically triggered:
-
pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4 -
pull-ci-openshift-assisted-service-master-edge-ci-index -
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp -
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted -
pull-ci-openshift-assisted-service-master-edge-images -
pull-ci-openshift-assisted-service-master-edge-lint -
pull-ci-openshift-assisted-service-master-edge-subsystem-aws -
pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws -
pull-ci-openshift-assisted-service-master-edge-unit-test -
pull-ci-openshift-assisted-service-master-edge-verify-generated-code -
pull-ci-openshift-assisted-service-master-images -
pull-ci-openshift-assisted-service-master-mce-images
In response to this:
/test ?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.07%. Comparing base (
d41f536) to head (f8a3b84). Report is 240 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #5820 +/- ##
==========================================
+ Coverage 67.97% 68.07% +0.10%
==========================================
Files 235 235
Lines 34480 34576 +96
==========================================
+ Hits 23437 23537 +100
+ Misses 8978 8967 -11
- Partials 2065 2072 +7
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rccrdpccl: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: osherdp, rccrdpccl
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [osherdp,rccrdpccl]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.