assisted-installer
assisted-installer copied to clipboard
openshift
MGMT-16843: Restart hostnamed service after replacing hostname
SNO clusters don't restart the hosts before beginning installation so if we generate a random hostname and write it to /etc/hostname, it won't take effect unless the hostname service is restarted.
@CrystalChun: This pull request references MGMT-16843 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
SNO clusters don't restart the hosts before beginning installation so if we generate a random hostname and write it to /etc/hostname, it won't take effect unless the hostname service is restarted.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: CrystalChun
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [CrystalChun]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@CrystalChun: The following commands are available to trigger required jobs:
-
/test e2e-agent-compact-ipv4 -
/test edge-e2e-ai-operator-ztp -
/test edge-e2e-metal-assisted -
/test edge-format-check -
/test edge-images -
/test edge-lint -
/test edge-unit-test -
/test images -
/test mce-images
The following commands are available to trigger optional jobs:
-
/test e2e-agent-ha-dualstack -
/test e2e-agent-sno-ipv6 -
/test edge-e2e-metal-assisted-cnv -
/test edge-e2e-metal-assisted-external -
/test edge-e2e-metal-assisted-ipv6 -
/test edge-e2e-metal-assisted-lvm -
/test edge-e2e-metal-assisted-odf -
/test edge-e2e-metal-assisted-single-node -
/test edge-e2e-oci-assisted -
/test edge-e2e-oci-assisted-4-14 -
/test edge-e2e-vsphere-assisted -
/test edge-e2e-vsphere-assisted-4-13 -
/test edge-e2e-vsphere-assisted-4-14 -
/test edge-publish-multi-arch-images-dry-run
Use /test all to run the following jobs that were automatically triggered:
-
pull-ci-openshift-assisted-installer-master-e2e-agent-compact-ipv4 -
pull-ci-openshift-assisted-installer-master-edge-e2e-ai-operator-ztp -
pull-ci-openshift-assisted-installer-master-edge-e2e-metal-assisted -
pull-ci-openshift-assisted-installer-master-edge-format-check -
pull-ci-openshift-assisted-installer-master-edge-images -
pull-ci-openshift-assisted-installer-master-edge-lint -
pull-ci-openshift-assisted-installer-master-edge-unit-test -
pull-ci-openshift-assisted-installer-master-images -
pull-ci-openshift-assisted-installer-master-mce-images
In response to this:
/test ?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/test edge-unit-test edge-e2e-metal-assisted edge-e2e-metal-assisted-single-node
@CrystalChun: This pull request references MGMT-16843 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
Hosts may not restart before beginning installation so if we generate a random hostname, it won't take effect unless we use hostnamectl to actually replace the hostname live.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Codecov Report
Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.
Project coverage is 55.68%. Comparing base (
f548d32) to head (651ca29).
Additional details and impacted files
@@ Coverage Diff @@
## master #839 +/- ##
==========================================
- Coverage 55.73% 55.68% -0.06%
==========================================
Files 15 15
Lines 3199 3202 +3
==========================================
Hits 1783 1783
- Misses 1245 1247 +2
- Partials 171 172 +1
| Files | Coverage Δ | |
|---|---|---|
| src/ops/ops.go | 43.30% <0.00%> (ø) |
|
| src/installer/installer.go | 69.25% <40.00%> (-0.37%) |
:arrow_down: |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
/test edge-e2e-ai-operator-ztp
Forgot ci/prow/edge-e2e-metal-assisted is actually broken https://issues.redhat.com/browse/OCPBUGS-33493
/retest-required
Remaining retests: 0 against base HEAD f548d3284a438c8e2020253d2250620b095c70a1 and 2 for PR HEAD 651ca29f22f451631cd60bf4baa4f9252bdbb0dd in total
@CrystalChun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-agent-compact-ipv4 | 651ca29f22f451631cd60bf4baa4f9252bdbb0dd | link | true | /test e2e-agent-compact-ipv4 |
| ci/prow/edge-e2e-metal-assisted | 651ca29f22f451631cd60bf4baa4f9252bdbb0dd | link | true | /test edge-e2e-metal-assisted |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@CrystalChun: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
This PR has been included in build ose-agent-installer-orchestrator-container-v4.17.0-202405230209.p0.g9e2f22a.assembly.stream.el9 for distgit ose-agent-installer-orchestrator. All builds following this will include this PR.
/cherry-pick release-ocm-2.10 release-ocm-2.9 release-4.16 release-4.15
@CrystalChun: new pull request created: #848
In response to this:
/cherry-pick release-ocm-2.10 release-ocm-2.9 release-4.16 release-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@CrystalChun: new pull request created: #849
In response to this:
/cherrypick release-ocm-2.9 release-4.16 release-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@CrystalChun: new pull request created: #850
In response to this:
/cherrypick release-4.16 release-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@CrystalChun: new pull request created: #851
In response to this:
/cherrypick release-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.