assisted-installer
assisted-installer copied to clipboard
openshift
MGMT-17353: Debug pod left in ImagePullBackOff after install in disconnected environment
In order to provide the number of reboots for installed node, "oc debug" is used and then the command "last reboot". "oc debug" uses external image called "support-tools". This image is not part of standard installation and it is not available in disconnected environments. Therefore, this notification is removed from the controller.
/cc @tsorya
@ori-amizur: This pull request references MGMT-17353 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
In order to provide the number of reboots for installed node, "oc debug" is used and then the command "last reboot". "oc debug" uses external image called "support-tools". This image is not part of standard installation and it is not available in disconnected environments. Therefore, this notification is removed from the controller.
/cc @tsorya
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ori-amizur
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [ori-amizur]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 55.72%. Comparing base (
f548d32) to head (9935cb9). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #817 +/- ##
==========================================
- Coverage 55.73% 55.72% -0.02%
==========================================
Files 15 15
Lines 3199 3207 +8
==========================================
+ Hits 1783 1787 +4
- Misses 1245 1248 +3
- Partials 171 172 +1
| Files | Coverage Δ | |
|---|---|---|
| ...taller_controller/assisted_installer_controller.go | 75.91% <ø> (ø) |
|
| .../assisted_installer_controller/reboots_notifier.go | 87.93% <100.00%> (+0.65%) |
:arrow_up: |
| src/config/config.go | 70.14% <100.00%> (+0.45%) |
:arrow_up: |
| ...ed-installer-controller/assisted_installer_main.go | 29.60% <0.00%> (ø) |
|
| src/ops/ops.go | 43.22% <0.00%> (-0.08%) |
:arrow_down: |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
/retest-required
Remaining retests: 0 against base HEAD 236a7a09fdce38423fcde97045ad71f79cfb4e1c and 2 for PR HEAD b9f7d31269896b686a2df7e9fa7224fc9fdcd6de in total
@ori-amizur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-agent-compact-ipv4 | b9f7d31269896b686a2df7e9fa7224fc9fdcd6de | link | true | /test e2e-agent-compact-ipv4 |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gamli75, ori-amizur
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [gamli75,ori-amizur]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD 9e2f22a6f36113130b67a86e02fa9be7291cd4f2 and 2 for PR HEAD 9935cb9da146e0716233d64fb75ec8c087116e5c in total
@ori-amizur: Overrode contexts on behalf of ori-amizur: ci/prow/edge-e2e-ai-operator-ztp
In response to this:
/override ci/prow/edge-e2e-ai-operator-ztp
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ori-amizur: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
This PR has been included in build ose-agent-installer-orchestrator-container-v4.17.0-202406021212.p0.gca4ed6d.assembly.stream.el9 for distgit ose-agent-installer-orchestrator. All builds following this will include this PR.
[ART PR BUILD NOTIFIER]
This PR has been included in build ose-agent-installer-csr-approver-container-v4.17.0-202406021212.p0.gca4ed6d.assembly.stream.el9 for distgit ose-agent-installer-csr-approver. All builds following this will include this PR.
@ori-amizur: new pull request created: #879
In response to this:
/cherry-pick release-ocm-2.10
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
