assisted-installer-agent icon indicating copy to clipboard operation
assisted-installer-agent copied to clipboard

MGMT-21454: Align with ART for OCP 4.20

Open yoavsc0302 opened this issue 6 months ago โ€ข 9 comments

Bot PRs to bump images to Go 1.24 and OCP 4.20 failed. This manual PR applies those changes to resolve the issue.

yoavsc0302 avatar Aug 26 '25 11:08 yoavsc0302

@yoavsc0302: This pull request references MGMT-21454 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Bot PRs to bump images to Go 1.24 and OCP 4.20 failed. This manual PR applies those changes to resolve the issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 26 '25 11:08 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yoavsc0302

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 26 '25 11:08 openshift-ci[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 56.54%. Comparing base (8857831) to head (fcb6499). :warning: Report is 18 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
+ Coverage   56.49%   56.54%   +0.04%     
==========================================
  Files          88       88              
  Lines        4310     4310              
==========================================
+ Hits         2435     2437       +2     
+ Misses       1698     1697       -1     
+ Partials      177      176       -1     

see 1 file with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 26 '25 12:08 codecov[bot]

/test edge-e2e-ai-operator-ztp /test edge-e2e-metal-assisted-4-20

yoavsc0302 avatar Aug 27 '25 07:08 yoavsc0302

@yoavsc0302: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 27 '25 10:08 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Nov 26 '25 01:11 openshift-bot

Walkthrough

Updated container image tags across build configuration files from OpenShift 4.19 with Go 1.23 to OpenShift 4.20 with Go 1.24. Builder and base image references were changed to use newer versions. No functional logic modifications.

Changes

Cohort / File(s) Summary
Image tag updates
.ci-operator.yaml, Dockerfile.ocp
Updated container image tags from OpenShift 4.19/Go 1.23 to 4.20/Go 1.24 for builder and base images; release image tag, builder image, and base image references changed accordingly

Estimated code review effort

๐ŸŽฏ 2 (Simple) | โฑ๏ธ ~8 minutes

  • Verify that the new image tags (rhel-9-golang-1.24-openshift-4.20 and 4.20:base-rhel9) are correct and available in the build infrastructure
  • Confirm that updating to Go 1.24 and OpenShift 4.20 does not introduce compatibility issues with the project's codebase or dependencies
โœจ Finishing touches
๐Ÿงช Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

๐Ÿ“œ Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 8857831ffeed8a38c87c7d9c93ce1542216b745a and fcb649957f786d86f1b58dc632671b14ae284b11.

๐Ÿ“’ Files selected for processing (2)
  • .ci-operator.yaml (1 hunks)
  • Dockerfile.ocp (1 hunks)
๐Ÿงฐ Additional context used
๐Ÿ““ Path-based instructions (1)
**

โš™๏ธ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • Dockerfile.ocp
๐Ÿ”‡ Additional comments (1)
Dockerfile.ocp (1)

2-2: Image tag updates are consistent and properly aligned.

Both the builder (Go 1.24, OCP 4.20) and base image (OCP 4.20) have been updated cohesively. The changes align with the .ci-operator.yaml configuration and maintain the build workflow structure.

Also applies to: 8-8


Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 26 '25 01:11 coderabbitai[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Nov 26 '25 01:11 openshift-merge-robot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Dec 26 '25 08:12 openshift-bot