api icon indicating copy to clipboard operation
api copied to clipboard

Add prometheusConfig API

Open marioferh opened this issue 1 month ago โ€ข 7 comments

This commit introduces a new API to be introduced as a part of the migration in CMO from ConfigMap to CRDs

This pr replaces https://github.com/openshift/api/pull/2630 because is broken

marioferh avatar Jan 16 '26 12:01 marioferh

Pipeline controller notification This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot avatar Jan 16 '26 12:01 openshift-ci-robot

Hello @marioferh! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Jan 16 '26 12:01 openshift-ci[bot]

[!NOTE]

Reviews paused

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
๐Ÿ“ Walkthrough

Walkthrough

This pull request introduces comprehensive Prometheus platform configuration capabilities to the cluster monitoring API. It adds multiple new public types for Prometheus settings, including support for remote write endpoints, TLS configuration, authorization, metric relabeling, retention policies, and scheduling constraints. The changes include auto-generated implementations for deep-copy operations and OpenAPI/Swagger documentation. Three ClusterMonitoring CRD variants are updated with a new prometheusConfig field, and Alertmanager volumeClaimTemplate descriptions are refined across all CRD files.

๐Ÿšฅ Pre-merge checks | โœ… 2 | โŒ 1
โŒ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage โš ๏ธ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
โœ… Passed checks (2 passed)
Check name Status Explanation
Title check โœ… Passed The title 'Add prometheusConfig API' clearly summarizes the main change: introducing a new prometheusConfig API field to support CMO migration from ConfigMap to CRDs.
Description check โœ… Passed The description is related to the changeset, explaining that this commit introduces a new API for the CMO migration from ConfigMap to CRDs, which aligns with the extensive changes adding prometheusConfig throughout the codebase.

โœ๏ธ Tip: You can configure your own custom pre-merge checks in the settings.

โœจ Finishing touches
๐Ÿงช Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Jan 16 '26 12:01 coderabbitai[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jan 16 '26 12:01 openshift-ci[bot]

@coderabbit ignore

marioferh avatar Jan 16 '26 13:01 marioferh

โœ… Actions performed

Reviews paused.

coderabbitai[bot] avatar Jan 16 '26 13:01 coderabbitai[bot]

@everettraven please take a look to https://github.com/openshift/api/pull/2653/changes/54882a69045a8a6a5aeecb2c660a5697129c6668

marioferh avatar Jan 27 '26 16:01 marioferh

@marioferh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Feb 05 '26 16:02 openshift-ci[bot]