openshift
Promote TNF (Dual Replica) to default
Promote DualReplica to default.
Two nodes with Fencing (DualReplica) allows deploying of a two-node OpenShift cluster with the necessary fencing tooling to prevent split-brain.
Enhancement Proposal: https://github.com/openshift/enhancements/pull/1675
Hello @fonta-rh! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
@fonta-rh Let me know when you believe this is ready for a review. I took a quick look at the promotion verification job and it looks like there is some more runs to be gathered.
Hello @everettraven ! Yeah, we're still missing runs and % of success. I removed the draft as I don't expect any more changes on our side and wanted to make sure the rest of the CI was not hiding some trouble. We'll keep looking at this and contact you when it's passing verify-feature-promotion. Thanks!
PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.
![qodo-code-review[bot] avatar](https://avatars.githubusercontent.com/in/484649?v=4 "Published by a pub.dev verified publisher"){kind=small}
📝 Walkthrough
Walkthrough
This pull request enables the DualReplica feature across multiple configuration layers. The change adds DualReplica as a valid controlPlaneTopology option in two CRD schemas, expands the feature gate's enableIn field to include the default configuration level, and transitions DualReplica from disabled to enabled status in both the Hypershift and SelfManagedHA feature gate configurations. The documentation in features.md is updated to reflect these status changes.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title accurately describes the main change: promoting the DualReplica feature to default configuration across multiple files. |
| Description check | ✅ Passed | The description clearly explains the purpose of the change, providing context about DualReplica's functionality and referencing the relevant enhancement proposal. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
- [ ] 📝 Generate docstrings
🧪 Generate unit tests (beta)
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.
🔧 golangci-lint (2.5.0)
Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot] avatar](https://avatars.githubusercontent.com/in/347564?v=4 "Published by a pub.dev verified publisher"){kind=small}
PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from everettraven. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.
@fonta-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/unit | 3837789e0395c2cf7195ff9ac5f6d1fc52bb7d41 | link | true | /test unit |
| ci/prow/verify | 3837789e0395c2cf7195ff9ac5f6d1fc52bb7d41 | link | true | /test verify |
| ci/prow/verify-feature-promotion | 3837789e0395c2cf7195ff9ac5f6d1fc52bb7d41 | link | true | /test verify-feature-promotion |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.