api icon indicating copy to clipboard operation
api copied to clipboard

Add IngressControllerConfig API for cluster-level ingress management

Open danielmellado opened this issue 5 months ago • 11 comments

Currently, OpenShift cluster administrators lack a unified way to configure operational settings for ingress controllers across the cluster. This introduces a new config/v1/IngressControllerConfig CRD that provides cluster-wide configuration for resource management, node scheduling, operational controls, and performance tuning.

Signed-off-by: Daniel Mellado [email protected]

danielmellado avatar Sep 19 '25 09:09 danielmellado

Hello @danielmellado! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Sep 19 '25 09:09 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 19 '25 09:09 openshift-ci[bot]

cc @joseorpa

danielmellado avatar Sep 19 '25 09:09 danielmellado

@JoelSpeed would I need to create an enhancement to use a new FeatureGate or would it be ok to use legacyFeatureGateWithoutEnhancement? I assume it won't after 4.18 but would like an ack here. Thanks xD

danielmellado avatar Sep 19 '25 11:09 danielmellado

@joseorpa would you be the contact person for this? contactPerson("tbd").

danielmellado avatar Sep 19 '25 11:09 danielmellado

Yes, I will be the owner

joseorpa avatar Sep 19 '25 11:09 joseorpa

An enhancement would be expected as well yes

JoelSpeed avatar Sep 19 '25 11:09 JoelSpeed

/assign

everettraven avatar Sep 19 '25 14:09 everettraven

@danielmellado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration d5cc1da912905b6585f6d23d196fde60a9c4e38a link true /test integration
ci/prow/verify d5cc1da912905b6585f6d23d196fde60a9c4e38a link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 19 '25 15:09 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Dec 23 '25 01:12 openshift-bot

[!IMPORTANT]

Review skipped

Auto reviews are limited based on label configuration.

:no_entry_sign: Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 23 '25 01:12 coderabbitai[bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Jan 22 '26 08:01 openshift-bot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Jan 22 '26 08:01 openshift-merge-robot