openshift
CORS-4096: Add DNS Record Type for IPv6 Domain mapping
operatoringress/v1/types.go:
** Add the new DNS Record Type for "AAAA" which is an RFC 3596 record used to map a domain name to an IPv6 address.
Intention/Function Examples:
** Cluster Ingress operator will use this new record type when a DNS record for IPv6 addresses is to be created. ** Openshift Installer will use this new record type when a DNS record for IPv6 addresses is to be created.
@barbacbd: This pull request references CORS-4096 which is a valid jira issue.
In response to this:
operatoringress/v1/types.go:
** Add the new DNS Record Type for "AAAA" which is an RFC 3596 record used to map a domain name to an IPv6 address.
Intention/Function Examples:
** Cluster Ingress operator will use this new record type when a DNS record for IPv6 addresses is to be created. ** Openshift Installer will use this new record type when a DNS record for IPv6 addresses is to be created.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @barbacbd! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: barbacbd, JoelSpeed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold
We should probably have this addition behind a feature gate, is there an appropriate feature that would own this?
/hold
We should probably have this addition behind a feature gate, is there an appropriate feature that would own this?
https://github.com/openshift/api/pull/2430 contains the feature gates. Running make update is resulting in changes that are unrelated to the PR, requiring manual intervention after the scripts are run. I'll be posting an update soon.
#2340 has now merged, so we should be able to move this forward now by gating it?
@barbacbd: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
[!IMPORTANT]
Review skipped
Auto reviews are limited based on label configuration.
:no_entry_sign: Review skipped — only excluded labels are configured. (1)
- do-not-merge/work-in-progress
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot] avatar](https://avatars.githubusercontent.com/in/347564?v=4 "Published by a pub.dev verified publisher"){kind=small}
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale