api icon indicating copy to clipboard operation
api copied to clipboard

OTA-1339: Add `UpdateStatusAPI` FG for DevPreview

Open petr-muller opened this issue 11 months ago • 5 comments

OTA originally created and used the UpgradeStatus legacy feature gate for the related functionality, enabled in TechPreview. Moving the functionality into the cluster, exposed by an API proved to be more complex and experimental than thought, so it was decided to create and use a new feature gate that is only enabled in DevPreview.

xref: https://github.com/openshift/api/pull/2233

petr-muller avatar Mar 21 '25 15:03 petr-muller

@petr-muller: This pull request references OTA-1339 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

OTA originally created and used the UpgradeStatus legacy feature gate for the related functionality, enabled in TechPreview. Moving the functionality into the cluster, exposed by an API proved to be more complex and experimental than thought, so it was decided to create and use a new feature gate that is only enabled in DevPreview.

xref: https://github.com/openshift/api/pull/2233

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 21 '25 15:03 openshift-ci-robot

Hello @petr-muller! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Mar 21 '25 15:03 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-muller Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 21 '25 15:03 openshift-ci[bot]

/retest

petr-muller avatar Mar 26 '25 16:03 petr-muller

@petr-muller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-out-of-change 95a666400ac19a4e1a60891ee89e7ed2b15b8017 link true /test e2e-upgrade-out-of-change
ci/prow/e2e-aws-serial-techpreview 95a666400ac19a4e1a60891ee89e7ed2b15b8017 link true /test e2e-aws-serial-techpreview
ci/prow/verify-client-go 95a666400ac19a4e1a60891ee89e7ed2b15b8017 link true /test verify-client-go
ci/prow/e2e-aws-ovn 95a666400ac19a4e1a60891ee89e7ed2b15b8017 link true /test e2e-aws-ovn
ci/prow/e2e-aws-serial 95a666400ac19a4e1a60891ee89e7ed2b15b8017 link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn-techpreview 95a666400ac19a4e1a60891ee89e7ed2b15b8017 link true /test e2e-aws-ovn-techpreview
ci/prow/minor-e2e-upgrade-minor 95a666400ac19a4e1a60891ee89e7ed2b15b8017 link true /test minor-e2e-upgrade-minor
ci/prow/e2e-aws-ovn-hypershift 95a666400ac19a4e1a60891ee89e7ed2b15b8017 link true /test e2e-aws-ovn-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 12 '25 02:04 openshift-ci[bot]

/hold /shrug

petr-muller avatar Apr 14 '25 16:04 petr-muller

/close

Proposal was rejected internally

petr-muller avatar Apr 16 '25 13:04 petr-muller

@petr-muller: Closed this PR.

In response to this:

/close

Proposal was rejected internally

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Apr 16 '25 13:04 openshift-ci[bot]