openshift
MCO-1002: Add a flag to allow irreconcilable configs
The flag will tell the operator to skip the irreconcilable fields validation and let the user update/patch conflictive MCs in the cluster at his own risk. This feature is specially thought to allow users to add new nodes in a long standing cluster with newer configuration.
@pablintino: This pull request references MCO-1002 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.
In response to this:
The flag will tell the operator to skip the irreconcilable fields validation and let the user update/patch conflictive MCs in the cluster at his own risk. This feature is specially thought to allow users to add new nodes in a long standing cluster with newer configuration.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @pablintino! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@pablintino: This pull request references MCO-1002 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.
In response to this:
The flag will tell the operator to skip the irreconcilable fields validation and let the user update/patch conflictive MCs in the cluster at his own risk. This feature is specially thought to allow users to add new nodes in a long standing cluster with newer configuration.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@everettraven Thanks for your inputs Bryce. I've updated the patch to match your input.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: pablintino Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: pablintino Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Is there an appropriate enhancement that describes how this is going to work? And in particular I'm concerned about how we will support this?
Is this field supportable?
This will have to go behind a feature gate at first as well
Is there an appropriate enhancement that describes how this is going to work? And in particular I'm concerned about how we will support this?
Is this field supportable?
This will have to go behind a feature gate at first as well
Hi @JoelSpeed. I've updated the patch, adding a feature gate and referencing to the, still draft, enhancement I created.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@pablintino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/verify-crd-schema | 5fb3a30a6ee75d6b512d8e04a53efebb07ed97f2 | link | true | /test verify-crd-schema |
| ci/prow/e2e-aws-ovn-hypershift | 5fb3a30a6ee75d6b512d8e04a53efebb07ed97f2 | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/verify | 5fb3a30a6ee75d6b512d8e04a53efebb07ed97f2 | link | true | /test verify |
| ci/prow/okd-scos-e2e-aws-ovn | 5fb3a30a6ee75d6b512d8e04a53efebb07ed97f2 | link | false | /test okd-scos-e2e-aws-ovn |
| ci/prow/e2e-aws-serial-1of2 | 5fb3a30a6ee75d6b512d8e04a53efebb07ed97f2 | link | true | /test e2e-aws-serial-1of2 |
| ci/prow/e2e-aws-serial-techpreview-1of2 | 5fb3a30a6ee75d6b512d8e04a53efebb07ed97f2 | link | true | /test e2e-aws-serial-techpreview-1of2 |
| ci/prow/e2e-aws-serial-techpreview-2of2 | 5fb3a30a6ee75d6b512d8e04a53efebb07ed97f2 | link | true | /test e2e-aws-serial-techpreview-2of2 |
| ci/prow/e2e-aws-serial-2of2 | 5fb3a30a6ee75d6b512d8e04a53efebb07ed97f2 | link | true | /test e2e-aws-serial-2of2 |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@pablintino: This pull request references MCO-1744 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.
In response to this:
The flag will tell the operator to skip the irreconcilable fields validation and let the user update/patch conflictive MCs in the cluster at his own risk. This feature is specially thought to allow users to add new nodes in a long standing cluster with newer configuration.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@pablintino: This pull request references MCO-1744 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.