openshift
SPLAT-2079: Removed VSphereControlPlaneMachineSet feature gate
Changes
- Removed VSphereControlPlaneMachineSet feature gate
- Fixed CRD to have config available as default
@vr4manta: This pull request references SPLAT-2079 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
Changes
- Removed VSphereControlPlaneMachineSet feature gate
- Fixed CRD to have config available as default
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello @vr4manta! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
@vr4manta: This pull request references SPLAT-2079 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
Changes
- Removed VSphereControlPlaneMachineSet feature gate
- Fixed CRD to have config available as default
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@vr4manta: This pull request references SPLAT-2079 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
Changes
- Removed VSphereControlPlaneMachineSet feature gate
- Fixed CRD to have config available as default
Dependencies
- https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/354
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn
To verify that vSphere clusters will still function/boot without issue
@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
- periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/398f2230-1146-11f0-8097-56c814f65c85-0
This feature has been enabled for more than a year, it's safe to remove now
/lgtm
/hold we need to make sure the CPMS is happy in the payload job I triggered before we allow this to merge
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoelSpeed, vr4manta
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@JoelSpeed , the payload-test has completed and passed. Are you ok with removing the hold?
/retest-required
Remaining retests: 0 against base HEAD 84bcaa112ae705ac3cfd4bdaaf1f309a2c396c56 and 2 for PR HEAD eb58fd16a5a337993cd32fd3ed925ca0b2d9d7a6 in total
/retest-required
Remaining retests: 0 against base HEAD 84bcaa112ae705ac3cfd4bdaaf1f309a2c396c56 and 2 for PR HEAD eb58fd16a5a337993cd32fd3ed925ca0b2d9d7a6 in total
/retest-required
Remaining retests: 0 against base HEAD 84bcaa112ae705ac3cfd4bdaaf1f309a2c396c56 and 2 for PR HEAD eb58fd16a5a337993cd32fd3ed925ca0b2d9d7a6 in total
/retest-required
Remaining retests: 0 against base HEAD aa882942241d4dc2023abedc942e52d092bf22fe and 2 for PR HEAD eb58fd16a5a337993cd32fd3ed925ca0b2d9d7a6 in total
/override ci/prow/e2e-aws-serial-techpreview
This passed but timed out during de-provision
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial-techpreview
In response to this:
/override ci/prow/e2e-aws-serial-techpreview
This passed but timed out during de-provision
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@vr4manta: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.20.0-202504080239.p0.g00e6260.assembly.stream.el9. All builds following this will include this PR.
