openshift
SPLAT-2078: Removed VSphereStaticIPs feature gate
@vr4manta: This pull request references SPLAT-2078 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
Changes
- Removed VSphereStaticIPs feature gate
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello @vr4manta! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
@vr4manta: This pull request references SPLAT-2078 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
Changes
- Removed VSphereStaticIPs feature gate
Dependencies
- https://github.com/openshift/installer/pull/9560
- https://github.com/openshift/machine-api-operator/pull/1346
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
This feature has been enabled for over a year, so is safe to remove
/lgtm
/hold but we do need to check that vSphere payload jobs are still passing with this removed
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn
@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
- periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/554e2420-1147-11f0-8fae-50b1e402517f-0
@JoelSpeed , the payload-test finish, but failed. It looks to have failed during e2e tests that don't seem related. If it looks ok to you, are you good with removing the hold?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jcpowermac, JoelSpeed, vr4manta
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD 00e6260bd8b88542106696c5a3f555256a6146d6 and 2 for PR HEAD d4a3a8c8b74cb0e99e4b97925013f6b59dc38c48 in total
/retest-required
Remaining retests: 0 against base HEAD 00e6260bd8b88542106696c5a3f555256a6146d6 and 2 for PR HEAD d4a3a8c8b74cb0e99e4b97925013f6b59dc38c48 in total
/retest-required
Remaining retests: 0 against base HEAD 00e6260bd8b88542106696c5a3f555256a6146d6 and 2 for PR HEAD d4a3a8c8b74cb0e99e4b97925013f6b59dc38c48 in total
/retest-required
Remaining retests: 0 against base HEAD 6fb534fddf16f9265a5eb02c572599ec373ca2d4 and 1 for PR HEAD d4a3a8c8b74cb0e99e4b97925013f6b59dc38c48 in total
/retest-required
Remaining retests: 0 against base HEAD 6fb534fddf16f9265a5eb02c572599ec373ca2d4 and 2 for PR HEAD d4a3a8c8b74cb0e99e4b97925013f6b59dc38c48 in total
@JoelSpeed it seems the two aws jobs keep failing for what looks like DNS issues.
level=fatal msg=failed to fetch Common Manifests: failed to fetch dependency of "Common Manifests": failed to generate asset "DNS Config": getting public zone for "origin-ci-int-aws.dev.rhcloud.com": no public route53 zone found matching name "origin-ci-int-aws.dev.rhcloud.com"
Can we override these to get changes to merge?
/override ci/prow/e2e-aws-serial /override ci/prow/e2e-aws-serial-techpreview
On going issue with the build cluster, I'm confident this won't be an issue for us
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial, ci/prow/e2e-aws-serial-techpreview
In response to this:
/override ci/prow/e2e-aws-serial /override ci/prow/e2e-aws-serial-techpreview
On going issue with the build cluster, I'm confident this won't be an issue for us
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@vr4manta: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.19.0-202504091811.p0.g8fcc4e7.assembly.stream.el9. All builds following this will include this PR.
