api
api copied to clipboard
openshift
SPLAT-2072: Removed VSphereMultiVCenters feature gate
Changes
- Removed the VSphereMultiVCenter feature gate
- Updated CRD to allow multiple vCenters always
@vr4manta: This pull request references SPLAT-2072 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
Changes
- Removed the VSphereMultiVCenter feature gate
- Updated CRD to allow multiple vCenters always
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @vr4manta! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@vr4manta: This pull request references SPLAT-2072 which is a valid jira issue.
In response to this:
Changes
- Removed the VSphereMultiVCenter feature gate
- Updated CRD to allow multiple vCenters always
Dependencies
- https://github.com/openshift/installer/pull/9553
- https://github.com/openshift/vmware-vsphere-csi-driver-operator/pull/300
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
The past several days tests have been failing due to aws lease issues (too many). I'll try a few more times, but I am not sure these failing jobs matter for the vSphere api featuregate cleanup.
/retest-required
Remaining retests: 0 against base HEAD 1ee228b6ff0d5adf35d223ac24ea745f9772d40a and 2 for PR HEAD ad9f718da3f9a657808e7dc616ed99b445aa50b3 in total
/retest-required
Remaining retests: 0 against base HEAD 1ee228b6ff0d5adf35d223ac24ea745f9772d40a and 2 for PR HEAD ad9f718da3f9a657808e7dc616ed99b445aa50b3 in total
/retest-required
Remaining retests: 0 against base HEAD 18bb3d9ee6c5a479d7d3771140ee53a47cdc856e and 1 for PR HEAD ad9f718da3f9a657808e7dc616ed99b445aa50b3 in total
/retest-required
Remaining retests: 0 against base HEAD 9b80d67473bc15d85312ffda09dcde489c8e0545 and 2 for PR HEAD ad9f718da3f9a657808e7dc616ed99b445aa50b3 in total
/retest-required
Remaining retests: 0 against base HEAD 9b80d67473bc15d85312ffda09dcde489c8e0545 and 2 for PR HEAD ad9f718da3f9a657808e7dc616ed99b445aa50b3 in total
/retest-required
Remaining retests: 0 against base HEAD e577b4d83475e00f762184e90d97f7526681defe and 1 for PR HEAD ad9f718da3f9a657808e7dc616ed99b445aa50b3 in total
/retest-required
Remaining retests: 0 against base HEAD e577b4d83475e00f762184e90d97f7526681defe and 2 for PR HEAD ad9f718da3f9a657808e7dc616ed99b445aa50b3 in total
/retest-required
Remaining retests: 0 against base HEAD e577b4d83475e00f762184e90d97f7526681defe and 2 for PR HEAD ad9f718da3f9a657808e7dc616ed99b445aa50b3 in total
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jcpowermac, JoelSpeed, rvanderp3, vr4manta
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD fb1b1c705326a6b91b18ea11c359697c88dbc776 and 2 for PR HEAD 31cf42803b816b0031da84dcb136b79f0b631dc3 in total
/retest-required
Remaining retests: 0 against base HEAD d22fca85e3b9f77f0cf2b43759a5ff927e605f57 and 1 for PR HEAD 31cf42803b816b0031da84dcb136b79f0b631dc3 in total
/retest-required
Remaining retests: 0 against base HEAD d22fca85e3b9f77f0cf2b43759a5ff927e605f57 and 2 for PR HEAD 31cf42803b816b0031da84dcb136b79f0b631dc3 in total
/retest-required
Remaining retests: 0 against base HEAD d22fca85e3b9f77f0cf2b43759a5ff927e605f57 and 2 for PR HEAD 31cf42803b816b0031da84dcb136b79f0b631dc3 in total
/override ci/prow/e2e-aws-serial
Test suite passed, but hit a timeout right at the end. This gate removal should have no effect on AWS testing anyway
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial
In response to this:
/override ci/prow/e2e-aws-serial
Test suite passed, but hit a timeout right at the end. This gate removal should have no effect on AWS testing anyway
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.