openshift
WIP:DNM: Bpfman operator APIs review
Hello @msherif1234! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: msherif1234 Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@msherif1234: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/verify-deps | e0efe844b8d1c4cc2c91207ece1190dacc0d0720 | link | true | /test verify-deps |
| ci/prow/unit | e0efe844b8d1c4cc2c91207ece1190dacc0d0720 | link | true | /test unit |
| ci/prow/verify | e0efe844b8d1c4cc2c91207ece1190dacc0d0720 | link | true | /test verify |
| ci/prow/unit | e0efe844b8d1c4cc2c91207ece1190dacc0d0720 | link | true | /test unit |
| ci/prow/verify-deps | e0efe844b8d1c4cc2c91207ece1190dacc0d0720 | link | true | /test verify-deps |
| ci/prow/verify-client-go | e0efe844b8d1c4cc2c91207ece1190dacc0d0720 | link | true | /test verify-client-go |
| ci/prow/verify | e0efe844b8d1c4cc2c91207ece1190dacc0d0720 | link | true | /test verify |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@everettraven, Mohamed has left Red Hat, and we still have work to do on this PR. Can someone give other members of the bpfman team permission to update this pr? Thanks, Andre
@anfredette Since the PR came from Mohamed's own repository, he is the only one who can give that access. You could either contact him and ask him to make you a collaborator on his fork of the repo, or you'll have to copy the branch and make a new PR
I’ll see if I can get in contact with Mohamed. Thanks, Andre
On Thu, May 1, 2025 at 4:42 AM Joel Speed @.***> wrote:
JoelSpeed left a comment (openshift/api#2221) https://github.com/openshift/api/pull/2221#issuecomment-2844390701
@anfredette https://github.com/anfredette Since the PR came from Mohamed's own repository, he is the only one who can give that access. You could either contact him and ask him to make you a collaborator on his fork of the repo, or you'll have to copy the branch and make a new PR
— Reply to this email directly, view it on GitHub https://github.com/openshift/api/pull/2221#issuecomment-2844390701, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHY7X6MBTB5E347RG4PQR324HM5HAVCNFSM6AAAAABYP2NEL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBUGM4TANZQGE . You are receiving this because you were mentioned.Message ID: @.***>
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
@frobware @andreaskaris - PTAL Mohamed, Andre and Billy have moved off the project; Andy and Andreas are now managing. Andy/Andreas have been talking about starting another round of reviews. My two cents is that this can be closed and a new PR started when they are ready, but they should chime in.
@frobware @andreaskaris - PTAL Mohamed, Andre and Billy have moved off the project; Andy and Andreas are now managing. Andy/Andreas have been talking about starting another round of reviews. My two cents is that this can be closed and a new PR started when they are ready, but they should chime in.
Given that I haven't been involved in this PR, unaware of the current state, I'd advocate we close and raise a new PR when we're ready for another review.
@everettraven: Closed this PR.
In response to this:
Closing based on input from @frobware and @Billy99
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.