CNTRLPLANE-72: remove RoleBindingRestriction CRD from payload
so that it can be managed by the cluster-authentication-operator instead of cluster-version-operator. This enables the cluster-authentication-operator to remove the CRD from the cluster when intentionally taking down the OpenShift OAuth stack.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Hello @everettraven! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
This needs to wait until we have the changes in place on the cluster-authentication-operator to start managing the CRD.
/hold
@everettraven: This pull request references CNTRLPLANE-72 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
so that it can be managed by the cluster-authentication-operator instead of cluster-version-operator. This enables the cluster-authentication-operator to remove the CRD from the cluster when OIDC authentication is configured.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@everettraven: This pull request references CNTRLPLANE-72 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
so that it can be managed by the cluster-authentication-operator instead of cluster-version-operator. This enables the cluster-authentication-operator to remove the CRD from the cluster when intentionally taking down the OpenShift OAuth stack.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
/lgtm
/retest
https://github.com/openshift/cluster-authentication-operator/pull/748 and https://github.com/openshift/installer/pull/9424 have merged. This should be good to go as long as tests are happy.
/hold cancel
cc @JoelSpeed for whenever you have time to take a look.
This is part of moving the management of the RoleBindingRestriction CRD to the cluster-authentication-operator. Outlined in https://github.com/openshift/enhancements/pull/1726
/approve
/retest-required
Remaining retests: 0 against base HEAD f587fb60f627fcdcff72a34293cb0771a8897338 and 2 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total
/retest-required
Remaining retests: 0 against base HEAD f587fb60f627fcdcff72a34293cb0771a8897338 and 2 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total
/retest-required
Remaining retests: 0 against base HEAD f587fb60f627fcdcff72a34293cb0771a8897338 and 2 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total
/retest-required
Remaining retests: 0 against base HEAD f587fb60f627fcdcff72a34293cb0771a8897338 and 2 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total
/retest-required
Remaining retests: 0 against base HEAD f587fb60f627fcdcff72a34293cb0771a8897338 and 2 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total
/retest-required
Remaining retests: 0 against base HEAD f2caafddf5d3e99e430594cf5d7e08b30af4edb9 and 1 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total
/retest-required
Remaining retests: 0 against base HEAD 422203b26165ccf9c7208b2baeb7a7ec9bfe2cbb and 0 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total
/hold
Revision bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 was retested 3 times: holding
/test-with https://github.com/openshift/hypershift/pull/5819 e2e-aws-ovn-hypershift
/testwith e2e-aws-ovn-hypershift https://github.com/openshift/hypershift/pull/5819
@everettraven, testwith: Error processing request. ERROR:
could not determine job runs: requested job is invalid. needs to be formatted like: <org>/<repo>/<branch>/<variant?>/<job>. instead it was: e2e-aws-ovn-hypershift
/testwith openshift/api/master/e2e-aws-ovn-hypershift https://github.com/openshift/hypershift/pull/5819
/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137
/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137
/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137 openshift/cluster-authentication-operator#770
/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137 openshift/cluster-authentication-operator#770
/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137 openshift/cluster-authentication-operator#770
/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137 openshift/cluster-authentication-operator#770
/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137 openshift/cluster-authentication-operator#770