api icon indicating copy to clipboard operation
api copied to clipboard

CNTRLPLANE-72: remove RoleBindingRestriction CRD from payload

Open everettraven opened this issue 11 months ago • 25 comments

so that it can be managed by the cluster-authentication-operator instead of cluster-version-operator. This enables the cluster-authentication-operator to remove the CRD from the cluster when intentionally taking down the OpenShift OAuth stack.

everettraven avatar Jan 09 '25 14:01 everettraven

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Jan 09 '25 14:01 openshift-ci[bot]

Hello @everettraven! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Jan 09 '25 14:01 openshift-ci[bot]

This needs to wait until we have the changes in place on the cluster-authentication-operator to start managing the CRD.

/hold

everettraven avatar Jan 09 '25 18:01 everettraven

@everettraven: This pull request references CNTRLPLANE-72 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

so that it can be managed by the cluster-authentication-operator instead of cluster-version-operator. This enables the cluster-authentication-operator to remove the CRD from the cluster when OIDC authentication is configured.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jan 29 '25 20:01 openshift-ci-robot

@everettraven: This pull request references CNTRLPLANE-72 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

so that it can be managed by the cluster-authentication-operator instead of cluster-version-operator. This enables the cluster-authentication-operator to remove the CRD from the cluster when intentionally taking down the OpenShift OAuth stack.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jan 29 '25 20:01 openshift-ci-robot

/retest-required

everettraven avatar Jan 30 '25 18:01 everettraven

/lgtm

liouk avatar Feb 07 '25 14:02 liouk

/retest

everettraven avatar Feb 28 '25 15:02 everettraven

https://github.com/openshift/cluster-authentication-operator/pull/748 and https://github.com/openshift/installer/pull/9424 have merged. This should be good to go as long as tests are happy.

/hold cancel

everettraven avatar Feb 28 '25 15:02 everettraven

cc @JoelSpeed for whenever you have time to take a look.

This is part of moving the management of the RoleBindingRestriction CRD to the cluster-authentication-operator. Outlined in https://github.com/openshift/enhancements/pull/1726

everettraven avatar Feb 28 '25 15:02 everettraven

/approve

JoelSpeed avatar Mar 03 '25 10:03 JoelSpeed

/retest-required

Remaining retests: 0 against base HEAD f587fb60f627fcdcff72a34293cb0771a8897338 and 2 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total

openshift-ci-robot avatar Mar 03 '25 10:03 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD f587fb60f627fcdcff72a34293cb0771a8897338 and 2 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total

openshift-ci-robot avatar Mar 03 '25 13:03 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD f587fb60f627fcdcff72a34293cb0771a8897338 and 2 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total

openshift-ci-robot avatar Mar 04 '25 01:03 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD f587fb60f627fcdcff72a34293cb0771a8897338 and 2 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total

openshift-ci-robot avatar Mar 04 '25 11:03 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD f587fb60f627fcdcff72a34293cb0771a8897338 and 2 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total

openshift-ci-robot avatar Mar 04 '25 13:03 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD f2caafddf5d3e99e430594cf5d7e08b30af4edb9 and 1 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total

openshift-ci-robot avatar Mar 04 '25 16:03 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 422203b26165ccf9c7208b2baeb7a7ec9bfe2cbb and 0 for PR HEAD bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 in total

openshift-ci-robot avatar Mar 04 '25 20:03 openshift-ci-robot

/hold

Revision bb85ed64c2b652a1b4b5f421a538d45c4b0a6c51 was retested 3 times: holding

openshift-ci-robot avatar Mar 04 '25 22:03 openshift-ci-robot

/test-with https://github.com/openshift/hypershift/pull/5819 e2e-aws-ovn-hypershift

everettraven avatar Mar 12 '25 19:03 everettraven

/testwith e2e-aws-ovn-hypershift https://github.com/openshift/hypershift/pull/5819

everettraven avatar Mar 12 '25 19:03 everettraven

@everettraven, testwith: Error processing request. ERROR:

could not determine job runs: requested job is invalid. needs to be formatted like: <org>/<repo>/<branch>/<variant?>/<job>. instead it was: e2e-aws-ovn-hypershift

openshift-ci[bot] avatar Mar 12 '25 19:03 openshift-ci[bot]

/testwith openshift/api/master/e2e-aws-ovn-hypershift https://github.com/openshift/hypershift/pull/5819

everettraven avatar Mar 12 '25 19:03 everettraven

/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137

everettraven avatar Jun 02 '25 19:06 everettraven

/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137

everettraven avatar Jun 03 '25 19:06 everettraven

/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137 openshift/cluster-authentication-operator#770

everettraven avatar Jun 04 '25 14:06 everettraven

/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137 openshift/cluster-authentication-operator#770

everettraven avatar Jun 04 '25 15:06 everettraven

/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137 openshift/cluster-authentication-operator#770

everettraven avatar Jun 04 '25 17:06 everettraven

/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137 openshift/cluster-authentication-operator#770

everettraven avatar Jun 04 '25 19:06 everettraven

/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#6137 openshift/cluster-authentication-operator#770

everettraven avatar Jun 05 '25 13:06 everettraven