openshift
OCPBUGS-45295: Make plugins name array items unique
@jhadvig: This pull request references Jira Issue OCPBUGS-45295, which is invalid:
- expected the bug to target the "4.19.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
/assign @JoelSpeed
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @jhadvig! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jhadvig Once this PR has been reviewed and has the lgtm label, please ask for approval from joelspeed. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@jhadvig: This pull request references Jira Issue OCPBUGS-45295, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.19.0) matches configured target version for branch (4.19.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
@jhadvig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/build | 70c33c8c89a93e796029ddd0008c07c85f7999ff | link | true | /test build |
| ci/prow/verify | 70c33c8c89a93e796029ddd0008c07c85f7999ff | link | true | /test verify |
| ci/prow/lint | 70c33c8c89a93e796029ddd0008c07c85f7999ff | link | true | /test lint |
| ci/prow/okd-scos-images | 70c33c8c89a93e796029ddd0008c07c85f7999ff | link | true | /test okd-scos-images |
| ci/prow/verify-client-go | 70c33c8c89a93e796029ddd0008c07c85f7999ff | link | true | /test verify-client-go |
| ci/prow/verify-crd-schema | 70c33c8c89a93e796029ddd0008c07c85f7999ff | link | true | /test verify-crd-schema |
| ci/prow/verify-feature-promotion | 70c33c8c89a93e796029ddd0008c07c85f7999ff | link | true | /test verify-feature-promotion |
| ci/prow/verify-deps | 70c33c8c89a93e796029ddd0008c07c85f7999ff | link | true | /test verify-deps |
| ci/prow/minor-images | 70c33c8c89a93e796029ddd0008c07c85f7999ff | link | true | /test minor-images |
| ci/prow/unit | 70c33c8c89a93e796029ddd0008c07c85f7999ff | link | true | /test unit |
| ci/prow/images | 70c33c8c89a93e796029ddd0008c07c85f7999ff | link | true | /test images |
| ci/prow/integration | 70c33c8c89a93e796029ddd0008c07c85f7999ff | link | true | /test integration |
| ci/prow/verify-crdify | 70c33c8c89a93e796029ddd0008c07c85f7999ff | link | true | /test verify-crdify |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@jhadvig: This pull request references Jira Issue OCPBUGS-45295. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.
In response to this:
/assign @JoelSpeed
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.