openshift
API-1858: Add ModernTLSConfiguration feature gate
Introduce ModernTLSConfiguration as an inaccessible-by-default feature gate.
Hello @sanchezl! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sanchezl Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sanchezl: This pull request references API-1858 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@sanchezl: This pull request references API-1858 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.
In response to this:
Introduce
ModernTLSConfigurationas an inaccessible-by-default feature gate.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.
The list of targets available in JIRA seems to be stale, and 4.18.0 is not allowed as a valid value.
Is there an enhancement describing what this will do and how we'll know it's done? I think I've see a lot around this one in the past and I know it involves at least two teams.
@deads2k: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build/test e2e-aws-ovn/test e2e-aws-ovn-hypershift/test e2e-aws-ovn-techpreview/test e2e-aws-serial/test e2e-aws-serial-techpreview/test e2e-upgrade/test images/test integration/test minor-e2e-upgrade-minor/test minor-images/test unit/test verify/test verify-client-go/test verify-crd-schema/test verify-deps
The following commands are available to trigger optional jobs:
/test e2e-azure/test e2e-gcp/test okd-scos-images
Use /test all to run the following jobs that were automatically triggered:
pull-ci-openshift-api-master-buildpull-ci-openshift-api-master-e2e-aws-ovnpull-ci-openshift-api-master-e2e-aws-ovn-hypershiftpull-ci-openshift-api-master-e2e-aws-ovn-techpreviewpull-ci-openshift-api-master-e2e-aws-serialpull-ci-openshift-api-master-e2e-aws-serial-techpreviewpull-ci-openshift-api-master-e2e-azurepull-ci-openshift-api-master-e2e-gcppull-ci-openshift-api-master-e2e-upgradepull-ci-openshift-api-master-imagespull-ci-openshift-api-master-integrationpull-ci-openshift-api-master-minor-e2e-upgrade-minorpull-ci-openshift-api-master-minor-imagespull-ci-openshift-api-master-unitpull-ci-openshift-api-master-verifypull-ci-openshift-api-master-verify-client-gopull-ci-openshift-api-master-verify-crd-schemapull-ci-openshift-api-master-verify-deps
In response to this:
/test ci/prow/verify
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
@sanchezl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-ovn | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test e2e-aws-ovn |
| ci/prow/okd-scos-images | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test okd-scos-images |
| ci/prow/e2e-aws-serial | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test e2e-aws-serial |
| ci/prow/minor-e2e-upgrade-minor | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test minor-e2e-upgrade-minor |
| ci/prow/e2e-upgrade | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test e2e-upgrade |
| ci/prow/verify | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test verify |
| ci/prow/e2e-upgrade-out-of-change | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test e2e-upgrade-out-of-change |
| ci/prow/build | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test build |
| ci/prow/e2e-aws-serial-techpreview | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test e2e-aws-serial-techpreview |
| ci/prow/verify-deps | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test verify-deps |
| ci/prow/verify-crd-schema | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test verify-crd-schema |
| ci/prow/unit | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test unit |
| ci/prow/lint | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test lint |
| ci/prow/integration | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test integration |
| ci/prow/e2e-aws-ovn-hypershift | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/e2e-aws-ovn-techpreview | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test e2e-aws-ovn-techpreview |
| ci/prow/minor-images | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test minor-images |
| ci/prow/verify-feature-promotion | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test verify-feature-promotion |
| ci/prow/images | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test images |
| ci/prow/verify-client-go | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test verify-client-go |
| ci/prow/e2e-aws-ovn-hypershift-conformance | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test e2e-aws-ovn-hypershift-conformance |
| ci/prow/e2e-aws-serial-techpreview-2of2 | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test e2e-aws-serial-techpreview-2of2 |
| ci/prow/e2e-aws-serial-2of2 | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test e2e-aws-serial-2of2 |
| ci/prow/e2e-aws-serial-techpreview-1of2 | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test e2e-aws-serial-techpreview-1of2 |
| ci/prow/e2e-aws-serial-1of2 | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test e2e-aws-serial-1of2 |
| ci/prow/verify-crdify | 0e98707387d7d00d9541d63167d09da2a0da5a31 | link | true | /test verify-crdify |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@JoelSpeed: Closed this PR.
In response to this:
/close
Please reopen if you feel we still need this
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.