openshift
API-1835: individual operator conditions must be set atomically
/hold
our current testing doesn't allow this to be tested in integration testing. I'll test manually I guess.
@deads2k: This pull request references API-1835 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.
In response to this:
/hold
our current testing doesn't allow this to be tested in integration testing. I'll test manually I guess.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bertinatto, deads2k
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [deads2k]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD 3c700b6cb32b58a619428e246b4ad5040565ac13 and 2 for PR HEAD c1f5237006e8dbbbcd733cfab93852c4344ca1e7 in total
/retest-required
Remaining retests: 0 against base HEAD 3c700b6cb32b58a619428e246b4ad5040565ac13 and 2 for PR HEAD c1f5237006e8dbbbcd733cfab93852c4344ca1e7 in total
/retest-required
Remaining retests: 0 against base HEAD 46b94866c0241a659d0f1a238e01d5c2b354e73a and 1 for PR HEAD c1f5237006e8dbbbcd733cfab93852c4344ca1e7 in total
/retest-required
Remaining retests: 0 against base HEAD 46b94866c0241a659d0f1a238e01d5c2b354e73a and 2 for PR HEAD c1f5237006e8dbbbcd733cfab93852c4344ca1e7 in total
/retest-required
Remaining retests: 0 against base HEAD 46b94866c0241a659d0f1a238e01d5c2b354e73a and 2 for PR HEAD c1f5237006e8dbbbcd733cfab93852c4344ca1e7 in total
/retest-required
Remaining retests: 0 against base HEAD 46b94866c0241a659d0f1a238e01d5c2b354e73a and 2 for PR HEAD c1f5237006e8dbbbcd733cfab93852c4344ca1e7 in total
/retest-required
Remaining retests: 0 against base HEAD f89ab92f1597eaed4de5b947c1781adde2bf42fb and 2 for PR HEAD c1f5237006e8dbbbcd733cfab93852c4344ca1e7 in total
/hold
something else should have failed
deads@fedora:~/workspaces/cluster-debug-tools/src/github.com/openshift/cluster-debug-tools$ ./kubectl-dev_tool audit -f '/home/deads/Downloads/audit-logs(14)/registry-build03-ci-openshift-org-ci-op-5n926cq2-stable-sha256-1bcf20915cd7b01643a5555630e06be72e4fef84cd34d1bdd10242c9fcf6cfdf/audit_logs/kube-apiserver' --resource=authentications.operator.openshift.io -otop --by=verb
had 4074 line read failures
count: 21152, first: 2024-09-26T10:46:01-04:00, last: 2024-09-26T11:36:58-04:00, duration: 50m56.399871s
Top 10 "GET" (of 9994 total hits):
9956x [ 5.314652ms] [200-9955] /apis/operator.openshift.io/v1/authentications/cluster [system:serviceaccount:openshift-authentication-operator:authentication-operator]
33x [ 5.403242ms] [200-32] /apis/operator.openshift.io/v1/authentications/cluster [system:serviceaccount:openshift-cluster-version:default]
3x [ 3.375666ms] [200-2] /apis/operator.openshift.io/v1/authentications/cluster [system:serviceaccount:kube-system:generic-garbage-collector]
1x [ 25.295ms] [] /apis/operator.openshift.io/v1/authentications/cluster [system:serviceaccount:openshift-must-gather-g4mxv:default]
1x [ 38.892ms] [] /apis/operator.openshift.io/v1/authentications/cluster [system:serviceaccount:openshift-insights:operator]
Top 10 "LIST" (of 11 total hits):
6x [ 7.997833ms] [200-5] /apis/operator.openshift.io/v1/authentications?resourceVersion=17788 [system:kube-controller-manager]
5x [ 7.3292ms] [200-4] /apis/operator.openshift.io/v1/authentications?resourceVersion=17788 [system:serviceaccount:openshift-authentication-operator:authentication-operator]
Top 10 "PATCH" (of 6328 total hits):
6328x [ 14.389349ms] [200-6327] /apis/operator.openshift.io/v1/authentications/cluster/status?fieldManager=APIServiceController_openshift-apiserver-updateOperatorStatus&force=true [system:serviceaccount:openshift-authentication-operator:authentication-operator]
Top 10 "UPDATE" (of 4798 total hits):
2787x [ 8.197066ms] [200-15,409-2771] /apis/operator.openshift.io/v1/authentications/cluster/status [system:serviceaccount:openshift-authentication-operator:authentication-operator]
2011x [ 8.434701ms] [200-1,409-2009] /apis/operator.openshift.io/v1/authentications/cluster [system:serviceaccount:openshift-authentication-operator:authentication-operator]
Top 10 "WATCH" (of 21 total hits):
12x [4m7.47246325s] [200-11] /apis/operator.openshift.io/v1/authentications?allowWatchBookmarks=true&resourceVersion=17788&timeout=5m12s&timeoutSeconds=312&watch=true [system:kube-controller-manager]
9x [3m37.424657s] [200-8] /apis/operator.openshift.io/v1/authentications?allowWatchBookmarks=true&resourceVersion=17788&timeoutSeconds=377&watch=true [system:serviceaccount:openshift-authentication-operator:authentication-operator]
oh! the install failed so the monitortest to catch excessive applies didn't happen
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
@deads2k This has been dormant for a while, is this something that should be picked up again?
@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-azure | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | false | /test e2e-azure |
| ci/prow/e2e-gcp | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | false | /test e2e-gcp |
| ci/prow/minor-e2e-upgrade-minor | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test minor-e2e-upgrade-minor |
| ci/prow/e2e-upgrade | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test e2e-upgrade |
| ci/prow/e2e-aws-serial-techpreview | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test e2e-aws-serial-techpreview |
| ci/prow/e2e-aws-ovn | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test e2e-aws-ovn |
| ci/prow/e2e-upgrade-out-of-change | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test e2e-upgrade-out-of-change |
| ci/prow/verify-client-go | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test verify-client-go |
| ci/prow/e2e-aws-ovn-hypershift | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/verify | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test verify |
| ci/prow/e2e-aws-serial | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test e2e-aws-serial |
| ci/prow/e2e-aws-ovn-techpreview | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test e2e-aws-ovn-techpreview |
| ci/prow/e2e-aws-ovn-hypershift-conformance | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test e2e-aws-ovn-hypershift-conformance |
| ci/prow/e2e-aws-serial-2of2 | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test e2e-aws-serial-2of2 |
| ci/prow/e2e-aws-serial-1of2 | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test e2e-aws-serial-1of2 |
| ci/prow/e2e-aws-serial-techpreview-2of2 | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test e2e-aws-serial-techpreview-2of2 |
| ci/prow/e2e-aws-serial-techpreview-1of2 | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test e2e-aws-serial-techpreview-1of2 |
| ci/prow/verify-crdify | c1f5237006e8dbbbcd733cfab93852c4344ca1e7 | link | true | /test verify-crdify |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@JoelSpeed: Closed this PR.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.