openshift
[release-4.17] OCPBUGS-39130: Added checks to prevent vCenters from changing after install past 1 vCenter
This is an automated cherry-pick of #2006
/assign vr4manta
Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@openshift-cherrypick-robot: Jira Issue OCPBUGS-37773 has been cloned as Jira Issue OCPBUGS-39130. Will retitle bug to link to clone. /retitle [release-4.17] OCPBUGS-39130: Added checks to prevent vCenters from changing after install past 1 vCenter
In response to this:
This is an automated cherry-pick of #2006
/assign vr4manta
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-39130, which is invalid:
- release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
This is an automated cherry-pick of #2006
/assign vr4manta
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@vr4manta: This pull request references Jira Issue OCPBUGS-39130, which is valid. The bug has been moved to the POST state.
7 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.17.0) matches configured target version for branch (4.17.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
- release note type set to "Release Note Not Required"
- dependent bug Jira Issue OCPBUGS-37773 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
- dependent Jira Issue OCPBUGS-37773 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
- bug has dependents
Requesting review from QA contact: /cc @gpei
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@vr4manta Is this a bug backport? Previously we could add more vcenters, but that wasn't supported?
What, apart from this API is required here to complete this?
@vr4manta Is this a bug backport? Previously we could add more vcenters, but that wasn't supported?
What, apart from this API is required here to complete this?
@JoelSpeed , Sorry for late reply. Not sure how this one got lost. Yeah, before we were never preventing the user from changing it. We have older clusters that can be upgraded and you can then configure this value to get things working; however, we were letting them change it when we do not support that. Normally you would reinstall into new vCenter. Multi vCenter feature added ability to do multiple. We currently do not have a migration to multi vCenter yet. Only clean install w/ that support.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jcpowermac, JoelSpeed, openshift-cherrypick-robot, pawanpinjarkar
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD 0a88001628266522c84e6c6c25ed5a44aced6d8b and 2 for PR HEAD 2d0aadb00630cdbd617eac68b1e833e069384ee2 in total
@openshift-cherrypick-robot: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@openshift-cherrypick-robot: Jira Issue OCPBUGS-39130: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-39130 has been moved to the MODIFIED state.
In response to this:
This is an automated cherry-pick of #2006
/assign vr4manta
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.17.0-202502141205.p0.g0cfc958.assembly.stream.el9. All builds following this will include this PR.
