openshift
WIP: Manual backport SDN live migration
Hello @pliurh! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@pliurh: This pull request references NP-1090 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set.
In response to this:
WIP
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@pliurh: This pull request references NP-1090 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set.
In response to this:
The feature SDN live migration was introduced in 4.15. Now we want to backport this feature to 4.14.z.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@pliurh: This pull request references NP-1090 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set.
In response to this:
The feature SDN live migration was introduced in 4.15. Now we want to backport this feature to 4.14.z.
The feature backports including the following PRs:
- https://github.com/openshift/ovn-kubernetes/pull/2251
- https://github.com/openshift/sdn/pull/631
- https://github.com/openshift/cluster-network-operator/pull/2469
- https://github.com/openshift/installer/pull/9008
- https://github.com/openshift/cluster-config-operator/pull/425
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
pre-merge tested with build build openshift/api#1994,openshift/sdn#631,openshift/ovn-kubernetes#2251,openshift/cluster-network-operator#2469,openshift/cluster-config-operator#425,openshift/installer#9008
Live migration to ovn from sdn looks good including multicast/egressip/egressfirewall
/label qe-approved
@pliurh: This pull request references NP-1090 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set.
In response to this:
The feature SDN live migration was introduced in 4.15. Now we want to backport this feature to 4.14.z.
The feature backports including the following PRs:
- https://github.com/openshift/ovn-kubernetes/pull/2251
- https://github.com/openshift/sdn/pull/631
- https://github.com/openshift/cluster-network-operator/pull/2469
- https://github.com/openshift/installer/pull/9008
- https://github.com/openshift/cluster-config-operator/pull/425
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@pliurh: This pull request references Jira Issue OCPBUGS-43490, which is valid. The bug has been moved to the POST state.
7 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.14.z) matches configured target version for branch (4.14.z)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
- release note type set to "Release Note Not Required"
- dependent bug Jira Issue OCPBUGS-43492 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
- dependent Jira Issue OCPBUGS-43492 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
- bug has dependents
Requesting review from QA contact: /cc @gangwgr
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
The feature SDN live migration was introduced in 4.15. Now we want to backport this feature to 4.14.z.
The feature backports including the following PRs:
- https://github.com/openshift/ovn-kubernetes/pull/2251
- https://github.com/openshift/sdn/pull/631
- https://github.com/openshift/cluster-network-operator/pull/2469
- https://github.com/openshift/installer/pull/9008
- https://github.com/openshift/cluster-config-operator/pull/425
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@pliurh: This pull request references Jira Issue OCPBUGS-43490, which is valid.
7 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.14.z) matches configured target version for branch (4.14.z)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
- release note type set to "Release Note Not Required"
- dependent bug Jira Issue OCPBUGS-43492 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
- dependent Jira Issue OCPBUGS-43492 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
- bug has dependents
Requesting review from QA contact: /cc @gangwgr
In response to this:
The feature SDN live migration was introduced in 4.15. Now we want to backport this feature to 4.14.z.
The feature backports including the following PRs:
- https://github.com/openshift/ovn-kubernetes/pull/2251
- https://github.com/openshift/sdn/pull/631
- https://github.com/openshift/cluster-network-operator/pull/2469
- ~~https://github.com/openshift/installer/pull/9008~~
- https://github.com/openshift/installer/pull/9105
- https://github.com/openshift/cluster-config-operator/pull/425
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Deepthidharwar: The label(s) /label pm-approved cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?
In response to this:
/label pm-approved
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/hold
Need to include the feature gate in the techpreview feature set otherwise we won't be able to test this
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoelSpeed, knobunc, pliurh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed,knobunc]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema
In response to this:
/lgtm /override ci/prow/verify-crd-schema
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@pliurh: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@pliurh: Jira Issue OCPBUGS-43490: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-43490 has been moved to the MODIFIED state.
In response to this:
The feature SDN live migration was introduced in 4.15. Now we want to backport this feature to 4.14.z.
The feature backports including the following PRs:
- https://github.com/openshift/ovn-kubernetes/pull/2251
- https://github.com/openshift/sdn/pull/631
- https://github.com/openshift/cluster-network-operator/pull/2469
- ~~https://github.com/openshift/installer/pull/9008~~
- https://github.com/openshift/installer/pull/9105
- https://github.com/openshift/cluster-config-operator/pull/425
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.