api icon indicating copy to clipboard operation
api copied to clipboard

[WIP] WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.1

Open atiratree opened this issue 1 year ago • 11 comments

TODO:

  • [x] depends on https://github.com/openshift/kubernetes-sigs-controller-tools/pull/20
  • [x] verify-prerelease-lifecycle-gen.sh should be fixed
  • [ ] not passing the verify-crd-schema-checker.sh: seeing a lot of NoNewRequiredFields
  • [ ] OPTIONAL: the rest of the scripts should be ported to gengo: https://github.com/openshift/api/pull/1776

atiratree avatar Aug 01 '24 18:08 atiratree

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to this:

  • WIP: make update not passing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 01 '24 18:08 openshift-ci-robot

Hello @atiratree! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Aug 01 '24 18:08 openshift-ci[bot]

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to this:

TODO:

  • [ ] depends on https://github.com/openshift/kubernetes-sigs-controller-tools/pull/20
  • [ ] verify-prerelease-lifecycle-gen.sh should be fixed https://github.com/openshift/api/pull/1983/commits/0cbd381a99c4e1383c1a8304845f004c66e38f10
  • [ ] not passing the verify-crd-schema-checker.sh: seeing a lot of NoNewRequiredFields
  • [ ] OPTIONAL: the rest of the scripts should be ported to gengo: https://github.com/openshift/api/pull/1776

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 05 '24 16:08 openshift-ci-robot

The PR passes make update so we can use it as a dependency for now, but there are still TODOs which are mentioned in the description.

atiratree avatar Aug 05 '24 16:08 atiratree

/test verify-client-go

atiratree avatar Aug 05 '24 16:08 atiratree

@atiratree: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

  • /test build
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-hypershift
  • /test e2e-aws-ovn-techpreview
  • /test e2e-aws-serial
  • /test e2e-aws-serial-techpreview
  • /test e2e-upgrade
  • /test e2e-upgrade-minor
  • /test images
  • /test integration
  • /test unit
  • /test verify
  • /test verify-client-go
  • /test verify-crd-schema
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-azure
  • /test e2e-gcp
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-api-master-build
  • pull-ci-openshift-api-master-e2e-aws-ovn
  • pull-ci-openshift-api-master-e2e-aws-ovn-hypershift
  • pull-ci-openshift-api-master-e2e-aws-ovn-techpreview
  • pull-ci-openshift-api-master-e2e-aws-serial
  • pull-ci-openshift-api-master-e2e-aws-serial-techpreview
  • pull-ci-openshift-api-master-e2e-azure
  • pull-ci-openshift-api-master-e2e-gcp
  • pull-ci-openshift-api-master-e2e-upgrade
  • pull-ci-openshift-api-master-e2e-upgrade-minor
  • pull-ci-openshift-api-master-images
  • pull-ci-openshift-api-master-integration
  • pull-ci-openshift-api-master-unit
  • pull-ci-openshift-api-master-verify
  • pull-ci-openshift-api-master-verify-client-go
  • pull-ci-openshift-api-master-verify-crd-schema
  • pull-ci-openshift-api-master-verify-deps

In response to this:

/retest verify-client-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Aug 05 '24 16:08 openshift-ci[bot]

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to this:

TODO:

  • [ ] depends on https://github.com/openshift/kubernetes-sigs-controller-tools/pull/20
  • [ ] verify-prerelease-lifecycle-gen.sh should be fixed
  • [ ] not passing the verify-crd-schema-checker.sh: seeing a lot of NoNewRequiredFields
  • [ ] OPTIONAL: the rest of the scripts should be ported to gengo: https://github.com/openshift/api/pull/1776

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 06 '24 15:08 openshift-ci-robot

/retest

atiratree avatar Aug 06 '24 19:08 atiratree

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

In response to this:

TODO:

  • [x] depends on https://github.com/openshift/kubernetes-sigs-controller-tools/pull/20
  • [x] verify-prerelease-lifecycle-gen.sh should be fixed
  • [ ] not passing the verify-crd-schema-checker.sh: seeing a lot of NoNewRequiredFields
  • [ ] OPTIONAL: the rest of the scripts should be ported to gengo: https://github.com/openshift/api/pull/1776

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 09 '24 12:08 openshift-ci-robot

/test e2e-azure /test minor-e2e-upgrade-minor

atiratree avatar Sep 26 '24 14:09 atiratree

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

In response to this:

TODO:

  • [x] depends on https://github.com/openshift/kubernetes-sigs-controller-tools/pull/20
  • [x] verify-prerelease-lifecycle-gen.sh should be fixed
  • [x] not passing the verify-crd-schema-checker.sh: seeing a lot of NoNewRequiredFields
  • [ ] OPTIONAL: the rest of the scripts should be ported to gengo: https://github.com/openshift/api/pull/1776

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 26 '24 15:09 openshift-ci-robot

/test e2e-azure /test minor-e2e-upgrade-minor /test e2e-aws-ovn-hypershift

atiratree avatar Sep 26 '24 20:09 atiratree

/test e2e-azure

atiratree avatar Sep 27 '24 14:09 atiratree

/test e2e-gcp

atiratree avatar Sep 30 '24 18:09 atiratree

/lgtm /override ci/prow/verify-client-go /override ci/prow/verify-crd-schema

JoelSpeed avatar Oct 01 '24 10:10 JoelSpeed

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-client-go, ci/prow/verify-crd-schema

In response to this:

/lgtm /override ci/prow/verify-client-go /override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Oct 01 '24 10:10 openshift-ci[bot]

verify failed because we need to react to https://github.com/openshift/api/pull/2027/files that merged in the meantime and regenerate the CRDs

atiratree avatar Oct 01 '24 11:10 atiratree

/lgtm /override ci/prow/verify-client-go /override ci/prow/verify-crd-schema

JoelSpeed avatar Oct 01 '24 12:10 JoelSpeed

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-client-go, ci/prow/verify-crd-schema

In response to this:

/lgtm /override ci/prow/verify-client-go /override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Oct 01 '24 12:10 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 01 '24 12:10 openshift-ci[bot]

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 01 '24 15:10 openshift-ci[bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202410011141.p0.ge415140.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Oct 01 '24 20:10 openshift-bot