api icon indicating copy to clipboard operation
api copied to clipboard

AUTH-527: security/v1 - add constant for enforcing psa annotation

Open ibihim opened this issue 1 year ago • 4 comments

What

Add an annotation constant that reveals what the label syncer would enforce.

Why

It is unclear what the label syncer would set, if alert labels are set or the syncer is turned off.

ibihim avatar Jul 31 '24 13:07 ibihim

@ibihim: This pull request references AUTH-527 which is a valid jira issue.

In response to this:

What

Add an annotation constant that reveals what the label syncer would enforce.

Why

It is unclear what the label syncer would set, if alert labels are set or the syncer is turned off.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 31 '24 13:07 openshift-ci-robot

Hello @ibihim! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Jul 31 '24 13:07 openshift-ci[bot]

/lgtm /approve

deads2k avatar Aug 05 '24 12:08 deads2k

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ibihim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 05 '24 12:08 openshift-ci[bot]

@ibihim: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 05 '24 15:08 openshift-ci[bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.17.0-202408051813.p0.g3946b36.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Aug 05 '24 18:08 openshift-bot