openshift
Power VS: Move Power VS to CAPI by default
Hello @mjturek! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@JoelSpeed @patrickdillon We are feeling pretty good about the results of the CAPI job, could we merge this? https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-ovn-ppc64le-powervs-capi
Did we reach a conclusion about whether we are ok not having disconnected support in 4.17?
Do you have a sippy link that shows the jobs over time?
The conclusion from the multiarch PM is that having the disconnected path for 4.17 be install with 4.16 and upgrade to 4.17 is okay.
I believe the recommendation is a week of data from the periodics. The 4.17 CAPI job was broken until recently so sippy would not show the same success we are currently seeing.
So I'm looking at both the capi and terraform runs and you're right, both aren't fantastic if you look back over time 😅
But the CAPI runs do appear to be looking good as far as I can tell.
Is there anyone else you need to get an LGTM from before we promote this? Perhaps @patrickdillon?
absolutely! @patrickdillon I would love your input
This LGTM. I'm happy to see PowerVS go default with CAPI installs.
/lgtm /override ci/prow/verify
/retest-required
Based on test output mentioned in https://github.com/openshift/api/pull/1979#issuecomment-2263379124, LGTM with Patricks approval
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify
In response to this:
/lgtm /override ci/prow/verify
/retest-required
Based on test output mentioned in https://github.com/openshift/api/pull/1979#issuecomment-2263379124, LGTM with Patricks approval
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD e65e6f54eb3c97dfbfb1629cc59646ee43cd6f62 and 2 for PR HEAD c05561f963315bd2bc57e1a30de1ac47ff3a2f9f in total
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify
In response to this:
/override ci/prow/verify
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD 6b4a57ec20b0bfc77cb3909da4f1a9234d498571 and 1 for PR HEAD c05561f963315bd2bc57e1a30de1ac47ff3a2f9f in total
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify
In response to this:
/override ci/prow/verify
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD 3cab566552bbc5c8ce7d11991cbc2bd1f21e1e1b and 0 for PR HEAD c05561f963315bd2bc57e1a30de1ac47ff3a2f9f in total
/hold
Revision c05561f963315bd2bc57e1a30de1ac47ff3a2f9f was retested 3 times: holding
/retest-required
Remaining retests: 0 against base HEAD 3cab566552bbc5c8ce7d11991cbc2bd1f21e1e1b and 2 for PR HEAD c05561f963315bd2bc57e1a30de1ac47ff3a2f9f in total
@mjturek: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build/test e2e-aws-ovn/test e2e-aws-ovn-hypershift/test e2e-aws-ovn-techpreview/test e2e-aws-serial/test e2e-aws-serial-techpreview/test e2e-upgrade/test e2e-upgrade-minor/test images/test integration/test unit/test verify/test verify-client-go/test verify-crd-schema/test verify-deps
The following commands are available to trigger optional jobs:
/test e2e-azure/test e2e-gcp/test okd-scos-images
Use /test all to run the following jobs that were automatically triggered:
pull-ci-openshift-api-master-buildpull-ci-openshift-api-master-e2e-aws-ovnpull-ci-openshift-api-master-e2e-aws-ovn-hypershiftpull-ci-openshift-api-master-e2e-aws-ovn-techpreviewpull-ci-openshift-api-master-e2e-aws-serialpull-ci-openshift-api-master-e2e-aws-serial-techpreviewpull-ci-openshift-api-master-e2e-azurepull-ci-openshift-api-master-e2e-gcppull-ci-openshift-api-master-e2e-upgradepull-ci-openshift-api-master-e2e-upgrade-minorpull-ci-openshift-api-master-imagespull-ci-openshift-api-master-integrationpull-ci-openshift-api-master-unitpull-ci-openshift-api-master-verifypull-ci-openshift-api-master-verify-client-gopull-ci-openshift-api-master-verify-crd-schemapull-ci-openshift-api-master-verify-deps
In response to this:
/test ci/prow/verify-client-go
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD 1ad7d8470d94376ad07078262355e6ed43222fcb and 1 for PR HEAD c05561f963315bd2bc57e1a30de1ac47ff3a2f9f in total