openshift
ETCD-520: add BackendQuotaGiB example
This PR adds an example for a new field BackendQuotaGiB within EtcdSpec type.
Example for https://github.com/openshift/api/pull/1736
see https://issues.redhat.com/browse/ETCD-513
cc @openshift/openshift-team-etcd @JoelSpeed @deads2k
@Elbehery: This pull request references ETCD-520 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
This PR adds an example for a new field
BackendQuotaGiBwithinEtcdSpectype.see https://issues.redhat.com/browse/ETCD-513
cc @openshift/openshift-team-etcd @JoelSpeed @deads2k
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @Elbehery! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Elbehery: This pull request references ETCD-520 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
This PR adds an example for a new field
BackendQuotaGiBwithinEtcdSpectype.Example for https://github.com/openshift/api/pull/1736
see https://issues.redhat.com/browse/ETCD-513
cc @openshift/openshift-team-etcd @JoelSpeed @deads2k
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Example looks good, you'll need to update the existing test cases now though as the new default value is making the expected values wrong
Example looks good, you'll need to update the existing test cases now though as the new default value is making the
expectedvalues wrong
updated 👍🏽
You'll need to update all the cases not just the first one, quite a few will have the new default effect them
You'll need to update all the cases not just the first one, quite a few will have the new default effect them
i dont think all the other cases, because the failure differs on specific case for specific feature gate iiuc
lets see how it goes now, then i update the failures :)
thanks a lot for your quick reviews 🙏🏽 🙏🏽 🙏🏽
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Elbehery, JoelSpeed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@Elbehery: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
This PR has been included in build ose-cluster-config-api-container-v4.17.0-202405072356.p0.g62b890e.assembly.stream.el9 for distgit ose-cluster-config-api. All builds following this will include this PR.
