api
api copied to clipboard
openshift
SDN-4545: [Release 4-15] Add transit switch config to 4.15
"Backport" of https://github.com/openshift/api/pull/1626
The CEL validations used here are not available in 4.15 so we have to use regex to validate the fields
@bpickard22: This pull request references SDN-4545 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.z" version, but no target version was set.
In response to this:
"Backport" of https://github.com/openshift/api/pull/1626
The CEL validations used here are not available in 4.15 so we have to use regex to validate the fields
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @bpickard22! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@bpickard22: This pull request references SDN-4545 which is a valid jira issue.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Validation and structure looks good now. Do we have the relevant QE testing done for the master branch feature? Are we happy that we can backport the feature without introducing any regressions in 4.15?
Have you got ack from a staff eng and your PM for the backport as well?
I grant it Staff Engineer ACK, and PM (Marc Curry) has approved this backport too.
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpickard22, knobunc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [knobunc]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@JoelSpeed relevant testing is done on master and I will ask qe to run regression tests once the cno pr is up
@JoelSpeed relevant testing is done on master and I will ask qe to run regression tests once the cno pr is up
Can the CNO PR not go up prior to this merging? Would that not allow complete testing before we merge anything into the backported branch?
@JoelSpeed cno pr is up and i have asked qe team to run regression tests, will ping you again once that is done
@bpickard22: This pull request references SDN-4545 which is a valid jira issue.
In response to this:
"Backport" of https://github.com/openshift/api/pull/1626
The CEL validations used here are not available in 4.15 so we have to use regex to validate the fields
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Where are we at on this? I see QE approved, is the implementation good to go? Have the team reviewed it and are happy to merge?
Where are we at on this? I see QE approved, is the implementation good to go? Have the team reviewed it and are happy to merge?
just waiting on an approver from my team to apply the needed labels then this should merge @JoelSpeed
@trozet: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]
In response to this:
/label backport-risk-assessed
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@JoelSpeed can you add the necessary labels here. we have staff approval, qe approval, and my team is good with this but does not have the perms to give the labels
@bpickard22: This pull request references SDN-4545 which is a valid jira issue.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@wangke19: This pull request references SDN-4545 which is a valid jira issue.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@zshi-redhat: This pull request references SDN-4545 which is a valid jira issue.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@bpickard22: This pull request references SDN-4545 which is a valid jira issue.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@bpickard22: This pull request references SDN-5026 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.z" version, but no target version was set.
In response to this:
"Backport" of https://github.com/openshift/api/pull/1626
The CEL validations used here are not available in 4.15 so we have to use regex to validate the fields
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.