api
api copied to clipboard
openshift
OCPBUGS-29774: Add hypershift cluster profile
Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS
@ashwindasr: This pull request references Jira Issue OCPBUGS-29774, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @gangwgr
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Since HyperShift / Hosted Control Plane have adopted
include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, theinclude.release.openshift.io/hypershiftaddition will allow Hypershift to express different profile choices than ROKS
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @ashwindasr! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ashwindasr Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@ashwindasr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-ovn-hypershift | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/verify | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test verify |
| ci/prow/integration | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test integration |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ashwindasr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/verify | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test verify |
| ci/prow/integration | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test integration |
| ci/prow/e2e-aws-serial-techpreview | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test e2e-aws-serial-techpreview |
| ci/prow/e2e-aws-ovn | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test e2e-aws-ovn |
| ci/prow/e2e-aws-ovn-hypershift | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/e2e-upgrade | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test e2e-upgrade |
| ci/prow/e2e-aws-serial | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test e2e-aws-serial |
| ci/prow/e2e-upgrade-minor | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test e2e-upgrade-minor |
| ci/prow/e2e-aws-ovn-techpreview | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test e2e-aws-ovn-techpreview |
| ci/prow/minor-images | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test minor-images |
| ci/prow/minor-e2e-upgrade-minor | aaf5161ca7577efb566229e09da1347ac04340a7 | link | true | /test minor-e2e-upgrade-minor |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.